-
-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add multiple zone selection #228
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #228 +/- ##
==========================================
Coverage ? 56.22%
==========================================
Files ? 11
Lines ? 2659
Branches ? 0
==========================================
Hits ? 1495
Misses ? 1164
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
Just checked this out. It's a bit awkward since the action that actually performs the zone update is "close the zone dropdown" AKA click anywhere that's not the zone selection dropdown. Some kind of "Add" or "OK" button would be nice, but it does technically work as-is. It also doesn't seem to work on the Android app at all, but I like that there's an OK button there so it makes more intuitive sense. |
We can think about adding a button in the future, both Klayton and I were having trouble getting a button to look good CSS-wise.
Just tested this in the app and it works as expected. |
Yeah after testing again I don't get the button that I saw before and things work as expected. I must have tested too soon or maybe grabbed an old commit somehow, I'm not sure. |
PR to make zone selector a multiselector.