Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API Changes to simplify Home Assistant integration #242

Closed
wants to merge 6 commits into from
Closed

Conversation

linknum23
Copy link
Contributor

@linknum23 linknum23 commented Dec 29, 2021

  • Add volume and mute aggregate fields to sources
  • Make local RCA inputs look like more streams
  • Investigate Airplay/Spotify client issues

@linknum23 linknum23 added the automation Home Automation plugin/integration (ie Alexa, Homeassistant) label Dec 29, 2021
@linknum23 linknum23 changed the base branch from main to develop December 29, 2021 21:43
@linknum23 linknum23 marked this pull request as draft December 29, 2021 21:43
@codecov-commenter
Copy link

codecov-commenter commented Dec 29, 2021

Codecov Report

Merging #242 (74f3af8) into develop (5052899) will increase coverage by 0.76%.
The diff coverage is 74.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #242      +/-   ##
===========================================
+ Coverage    56.22%   56.99%   +0.76%     
===========================================
  Files           11       12       +1     
  Lines         2659     2681      +22     
===========================================
+ Hits          1495     1528      +33     
+ Misses        1164     1153      -11     
Flag Coverage Δ
unittests 56.99% <74.00%> (+0.76%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
amplipi/extras.py 0.00% <0.00%> (ø)
amplipi/formatter.py 21.73% <21.73%> (ø)
amplipi/rt.py 27.15% <66.66%> (+1.15%) ⬆️
amplipi/app.py 87.04% <79.16%> (+0.16%) ⬆️
amplipi/ctrl.py 82.33% <96.96%> (+0.43%) ⬆️
amplipi/hw.py 35.21% <100.00%> (+2.16%) ⬆️
amplipi/models.py 94.60% <100.00%> (+0.27%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3853dfb...74f3af8. Read the comment docs.

@linknum23 linknum23 closed this Jun 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automation Home Automation plugin/integration (ie Alexa, Homeassistant)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants