Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests #524

Merged
merged 15 commits into from
Nov 1, 2023
Merged

Fix tests #524

merged 15 commits into from
Nov 1, 2023

Conversation

klay2000
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Oct 24, 2023

Codecov Report

Merging #524 (a61bc03) into develop (17390bb) will decrease coverage by 4.42%.
Report is 608 commits behind head on develop.
The diff coverage is 35.69%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@             Coverage Diff             @@
##           develop     #524      +/-   ##
===========================================
- Coverage    56.25%   51.83%   -4.42%     
===========================================
  Files           12       22      +10     
  Lines         2839     5442    +2603     
===========================================
+ Hits          1597     2821    +1224     
- Misses        1242     2621    +1379     
Flag Coverage Δ
unittests 51.83% <35.69%> (-4.42%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
amplipi/__init__.py 100.00% <100.00%> (ø)
amplipi/models.py 95.65% <100.00%> (+0.65%) ⬆️
amplipi/display/__init__.py 0.00% <0.00%> (ø)
amplipi/asgi.py 0.00% <0.00%> (ø)
tests/test_rest.py 94.00% <97.97%> (ø)
amplipi/rt.py 26.30% <23.07%> (-0.13%) ⬇️
amplipi/utils.py 74.45% <66.66%> (+3.23%) ⬆️
amplipi/app.py 71.81% <57.14%> (-13.58%) ⬇️
amplipi/updater/asgi.py 0.00% <0.00%> (ø)
amplipi/display/display.py 0.00% <0.00%> (ø)
... and 8 more

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Lohrer
Copy link
Collaborator

Lohrer commented Oct 25, 2023

How was anything working before if all that stuff was missing from web/static? Is it really all required?

Most if not all of the images under web/static/imgs are duplicates of web/src/assets. Should one or the other be removed?

Copy link
Collaborator

@Lohrer Lohrer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Put the correct year in rest-api-doc.html and this looks good to me. I don't actually have any clue on the new web interface setup so I can't comment from that perspective...

<!-- content at the top -->
<!-- content at the bottom -->
<p slot="footer" style="margin:0; padding:16px 36px; background-color:#47AFE8; color:#fff; text-align:center;">
© Micronova 2022
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not 2022 anymore

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there a reason we have to hard code the year like that?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know, you added this file but did it come from somewhere else?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, it's part of the api docs, they got ripped out by someone at some point

@rtertiaer rtertiaer merged commit 84f6529 into develop Nov 1, 2023
2 checks passed
@rtertiaer rtertiaer deleted the fix-tests branch November 1, 2023 20:48
Lohrer added a commit that referenced this pull request Nov 1, 2023
@Lohrer
Copy link
Collaborator

Lohrer commented Nov 1, 2023

@rtertiaer, next time rebase before merging please!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants