-
-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix tests #524
Conversation
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## develop #524 +/- ##
===========================================
- Coverage 56.25% 51.83% -4.42%
===========================================
Files 12 22 +10
Lines 2839 5442 +2603
===========================================
+ Hits 1597 2821 +1224
- Misses 1242 2621 +1379
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
How was anything working before if all that stuff was missing from Most if not all of the images under |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Put the correct year in rest-api-doc.html and this looks good to me. I don't actually have any clue on the new web interface setup so I can't comment from that perspective...
web/templates/rest-api-doc.html
Outdated
<!-- content at the top --> | ||
<!-- content at the bottom --> | ||
<p slot="footer" style="margin:0; padding:16px 36px; background-color:#47AFE8; color:#fff; text-align:center;"> | ||
© Micronova 2022 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not 2022 anymore
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there a reason we have to hard code the year like that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know, you added this file but did it come from somewhere else?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, it's part of the api docs, they got ripped out by someone at some point
@rtertiaer, next time rebase before merging please! |
No description provided.