Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 1836 - Manual prevalence entry v2 proposal #1838

Merged
merged 25 commits into from
Jun 24, 2023

Conversation

CloudByteKS
Copy link
Collaborator

Includes all the changes we discussed, minus hiding certain boxes under an "advanced mode" checkbox since that was put on hold.

Please let me know if you have any questions!

@CloudByteKS CloudByteKS requested a review from octern April 30, 2023 17:06
@codecov
Copy link

codecov bot commented Apr 30, 2023

Codecov Report

Merging #1838 (9a5fd30) into main (1591ec0) will decrease coverage by 0.26%.
The diff coverage is 27.27%.

@@            Coverage Diff             @@
##             main    #1838      +/-   ##
==========================================
- Coverage   66.26%   66.00%   -0.26%     
==========================================
  Files         104      104              
  Lines        2828     2833       +5     
  Branches      513      513              
==========================================
- Hits         1874     1870       -4     
- Misses        804      813       +9     
  Partials      150      150              
Impacted Files Coverage Δ
src/App.tsx 0.00% <ø> (ø)
src/components/calculator/PersonRiskControls.tsx 50.00% <ø> (-16.67%) ⬇️
src/pages/Calculator.tsx 79.38% <ø> (ø)
.../calculator/prevalence/ManualPrevalenceDetails.tsx 54.83% <27.27%> (-11.83%) ⬇️

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@netlify
Copy link

netlify bot commented Apr 30, 2023

Deploy Preview for microcov ready!

Name Link
🔨 Latest commit 9a5fd30
🔍 Latest deploy log https://app.netlify.com/sites/microcov/deploys/64905ef92b726c0008fceb01
😎 Deploy Preview https://deploy-preview-1838--microcov.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Contributor

@jaraco jaraco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Detailed comments in Slack, but LGTM.

…smoother

* If the number in the total population box is changed from 100,000, then the label for the box above it should change to "total weekly new cases"
* At mobile screen width, the explanatory labels on the slider no longer work. Please set them to wrap properly.
* Please send the instructions on how to edit the presets and their labels.
* See if you can fix microCOVID#1839 (text boxes are unusable and widths between phone and desktop)
* Change the text in the pink bar from "Step 1: Characterize community infection" to "Step 1: Enter COVID rate"
* Change the instructions to:
Use the slider or text box to enter weekly new COVID cases per 100,000 people in your area. You can also estimate whether cases are relatively low or high and use the preset options on the slider.
In the US you can look up weekly new cases on covidactnow.org by clicking your state on the map, and then your county. The first number on the screen is "weekly new reported cases per 100k"
…took out of <Trans> element to be able to insert URL into text)
@octern octern merged commit a44193a into microCOVID:main Jun 24, 2023
@jaraco
Copy link
Contributor

jaraco commented Jun 24, 2023

Woo hoo!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants