-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 1836 - Manual prevalence entry v2 proposal #1838
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1838 +/- ##
==========================================
- Coverage 66.26% 66.00% -0.26%
==========================================
Files 104 104
Lines 2828 2833 +5
Branches 513 513
==========================================
- Hits 1874 1870 -4
- Misses 804 813 +9
Partials 150 150
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
microCOVID#1826 - Manual prevalence entry v1 proposal (microCOVID#1837)
✅ Deploy Preview for microcov ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Detailed comments in Slack, but LGTM.
…smoother * If the number in the total population box is changed from 100,000, then the label for the box above it should change to "total weekly new cases" * At mobile screen width, the explanatory labels on the slider no longer work. Please set them to wrap properly. * Please send the instructions on how to edit the presets and their labels. * See if you can fix microCOVID#1839 (text boxes are unusable and widths between phone and desktop) * Change the text in the pink bar from "Step 1: Characterize community infection" to "Step 1: Enter COVID rate" * Change the instructions to: Use the slider or text box to enter weekly new COVID cases per 100,000 people in your area. You can also estimate whether cases are relatively low or high and use the preset options on the slider. In the US you can look up weekly new cases on covidactnow.org by clicking your state on the map, and then your county. The first number on the screen is "weekly new reported cases per 100k"
…sappear when on mobile to avoid collision
…took out of <Trans> element to be able to insert URL into text)
Woo hoo! |
Includes all the changes we discussed, minus hiding certain boxes under an "advanced mode" checkbox since that was put on hold.
Please let me know if you have any questions!