-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrator: Write migrator for NomAnalysisActivity
documents
#2010
Comments
NomAnalysisActivity
documents
Hi @JamesTessmer, all of the migrators — whether written for the |
Hi @aclum , I have a question. There are a few places in a migrator where schema version numbers are indicated; for example, each migrator's name has the format |
@JamesTessmer, when the person writing a migrator doesn't know what the specific schema versions will be yet, I usually recommend that they either (a) make up some non-sensical versions (e.g. Here's a (hypothetical) example:
The version numbers can remain as placeholders until the migrator is in a PR. In other words, they can remain as placeholder while writing and testing the migrator. |
It will be 10.3.0 to whatever the version release at the end of June for nmdc-schema will be proposed. I propose 10.4.0 unless @turbomam objects. |
Thanks, @aclum. FYI @JamesTessmer, when writing the migrator, I recommend naming it |
Added PR for this issue here: #2059 @aclum @eecavanna What's the best way to test the migrator before marking the PR as ready for review? |
Hi @JamesTessmer, The test approach I consider to be the "lowest-hanging fruit" is to run the doctests. You can do that by running
|
merged with #2059 |
We need a migrator which will search for NomAnalysisActivity which do not have a version appended, for each of those records it should update ID to append a .1 to the existing value in slot ID and move the existing value of ID to alternative_identifiers.
Example before:
example after:
Example migrators can be found https://github.com/microbiomedata/nmdc-schema/tree/main/nmdc_schema/migrators
Target completion for this is 6/17. This migrator is needed for the 6/24 release or the records will be invalid b/c that release will have more stringent pattern matches on IDs. cc @ssarrafan
The text was updated successfully, but these errors were encountered: