Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to enforce including id_version in WorkflowExecutionActivity subclasses #1988

Closed
6 of 7 tasks
aclum opened this issue May 17, 2024 · 6 comments · Fixed by #1989
Closed
6 of 7 tasks

update to enforce including id_version in WorkflowExecutionActivity subclasses #1988

aclum opened this issue May 17, 2024 · 6 comments · Fixed by #1989
Assignees

Comments

@aclum
Copy link
Contributor

aclum commented May 17, 2024

Some NOM workflow execution activity records don't have a ID version and some re-id'd records have multiple workflow ID versions.

@aclum aclum linked a pull request May 20, 2024 that will close this issue
@aclum aclum self-assigned this May 20, 2024
@aclum aclum reopened this May 22, 2024
@aclum
Copy link
Contributor Author

aclum commented May 22, 2024

For what to do we decided to add alternative_identifiers to WokflowExecutionActivity subclasses. That PR is #1993

@kheal

This comment was marked as resolved.

@aclum
Copy link
Contributor Author

aclum commented May 28, 2024

PRs have been merged in to make the workflow IDs pattern matching more stringent and to allow alternative identifiers. This master ticket is expected to span into the next sprint for James' work.

@aclum
Copy link
Contributor Author

aclum commented Jun 10, 2024

@kheal your portion is complete, yes?

@kheal
Copy link
Contributor

kheal commented Jun 10, 2024

@aclum - Yes, in this PR: microbiomedata#177

@ssarrafan
Copy link
Collaborator

Closing this issue
@aclum

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

5 participants