Added images to README.md for #73 #76
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@turbomam This PR failed the validation check. Given how long it has been open is it best to just close the PR at this point? |
Sure. I think @cmungall wanted be to add some images back into the The badges and slideshow link are good. What do you think of adding an NMDC banner? I think I had on in this old PR, but it was awfully big. |
|
I think the NMDC image is fine, although it might need to be reduced. |
|
I decided to include the image but not the "high level overview" diagram |
turbomam
added a commit
that referenced
this pull request
Feb 21, 2024
…vant_protocols add migrator for moving relevant_protocols to protocol_link PR21
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NMDC image may be too big
Still need to find newer/better? schema image or validate the current one.