Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #84 - add links for downloading data collections to README #85

Merged
merged 9 commits into from
Jul 1, 2021

Conversation

turbomam
Copy link
Collaborator

@turbomam turbomam commented Jun 28, 2021

Are you guys OK with the way I have exposed the NMDC JSON downloads (to the public?)

Please read the two notes.

copied and pasted from MongoDB Compass GUI. 

- add links to download these colelctions.
- switch to something from the CLI
- remove commas in numbers?
- use consistent size units (MB?)
@turbomam
Copy link
Collaborator Author

Please also see #76 . It would be nice to close or address both of these at the same time.

could still remove comma separators and report sizes in consistent byte units (MB?)
Copy link
Collaborator

@dwinston dwinston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, these are brittle links. I suggest we link to a timestamped DRS bundle that has, as its contents, a DRS blob for each bzipped json lines collection.

We can have a table of summary statistics, and we can also link directly to the DRS blob for each collection.

The link can be served from the nmdc-runtime dev deployment in the short term (https://api.nmdc-runtime-dev.polyneme.xyz/docs), which implements the DRS API. We should get a nicer CNAME for this, e.g. api.microbiomedata.org.

@wdduncan
Copy link
Contributor

wdduncan commented Jul 1, 2021

I'll go ahead an merge.

@wdduncan
Copy link
Contributor

wdduncan commented Jul 1, 2021

Fixes #84

@wdduncan wdduncan merged commit b18bb2c into main Jul 1, 2021
@wdduncan wdduncan deleted the issue-84 branch July 1, 2021 20:09
@turbomam
Copy link
Collaborator Author

In what ways are we still using DRS? Is it useful to end users, esp. now that we have metadata-download APIs?

@dwinston
Copy link
Collaborator

dwinston commented Sep 27, 2023

Is it useful to end users...?

No idea. I have not been collecting usage logs. That would be step one.

@turbomam
Copy link
Collaborator Author

Would adding logging take much effort?

@dwinston
Copy link
Collaborator

shouldn't be too bad. can add a lightweight middleware to nmdc-runtime based on e.g. https://github.com/tom-draper/api-analytics/tree/main/analytics/python/fastapi.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants