Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Soil sample storage temperature help example fails on validation #121

Closed
Tracked by #587
pvangay opened this issue Apr 26, 2022 · 6 comments
Closed
Tracked by #587

Soil sample storage temperature help example fails on validation #121

pvangay opened this issue Apr 26, 2022 · 6 comments
Assignees

Comments

@pvangay
Copy link

pvangay commented Apr 26, 2022

For reference, DH interface link - admin required.

Using the example provided in the help fails on validation.
image

image

Please either update the help text or the validation rules so that both are consistent with each other.

@pvangay pvangay changed the title sample storage temperature guidance help Soil sample storage temperature help example fails on validation Apr 26, 2022
@turbomam
Copy link
Member

Hmm, I think I can fix this in nmdc-dh-sheets-mam-non-anno sheet modifications_long

Note to self:

  • Google Sheet needs better name
  • Should probably be made view-only do people don't edit it
  • I need to write documentation on how to edit the Sheet

@turbomam
Copy link
Member

Back to the issue at hand:

@pvangay

my pattern ^[-+]?[0-9]*\.?[0-9]+([eE][-+]?[0-9]+)? \S+$ expects

  • a floating point/decimal number
  • then one whitespace
  • then one or more NON-WHITESPACE characters

Do you want me to

  • change the validation rule to accept '-80 degree Celsius'? Like, require a number, followed by a space, followed by a non-space character, followed by 0 or more characters of any type?
  • change the example (which comes from MIxS) to match the existing validation rule? Like '-80 C'?

@pvangay
Copy link
Author

pvangay commented Apr 27, 2022

which one is more in line with MIxS? Or is the issue that their guidance does not match their example?

@mslarae13
Copy link

Note on this, string_serialization does not show in the submission portal. Should it?

@ssarrafan
Copy link

@mslarae13 who is your question above directed to so I can try to get you an answer?

@pkalita-lbl
Copy link
Collaborator

This is working now. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ SubPort 1 - Done
Development

No branches or pull requests

5 participants