Providing resources (simple MySQL implementation) #12

slot · 2017-12-11T15:31:26Z

If a service needs a resource (db, cache, queue etc) which can be provided by a dedicated container running this service the developer can add the resource to .missy.yml

Example:

name: demo
resources:
  - "mysql"

The ides is that missy-controller will spin up the needed resources, configure them and place a config in Kubernetes before starting the service. Meaning when the service comes up the dedicated resources are already there and can be used.

Looking at the API for the developer using resources is very simple. @levrik @gizioo @wojciech12 @pbsmacc please critically check this first draft. I used a singleton pattern to hold the current MySQL session but it can be swopped easily during testing.

The code example looks as follows

package main

import (
	"net/http"
	"time"
	"github.com/microdevs/missy/service"
	"github.com/microdevs/missy/resource"
	"github.com/microdevs/missy/log"
)


func main() {

	s := service.New()

	s.HandleFunc("/log", func(w *service.ResponseWriter, r *http.Request) {

		_, err := resource.MysqlConnection().Exec("INSERT into accesslog (accessTime, agent) values (NOW(),?)", r.UserAgent())
		if err!= nil {
			w.Error("DB query failed", http.StatusInternalServerError)
		}
		w.Write([]byte("OK wrote log"))
	}).Methods(http.MethodPost)

	s.Start()
}

Let me know what you think. In the meantime I will prepare the missy-controller to prove the resource spin up flow works.

…tup() func that will add parameters to config- changed location where config.parseEnv() is being called

… developer

levrik · 2017-12-12T13:44:20Z

resource/resource.go

+		case MysqlResourceName:
+			my := Mysql{}
+			my.Setup(c)
+		}


Can we print a warning here for unknown resources?

mize85 · 2017-12-12T13:59:12Z

@slot would it make sense to change implementation slightly to allow more than one mysql (or any other) resource ?
e.g. add a type and infer settings from resource name?
or would 2 mysql resources in one service be pfui pfui?

coveralls · 2017-12-12T15:53:47Z

Coverage decreased (-1.2%) to 45.779% when pulling 3b709fe on providing-resources into b0aa3a4 on master.

GitCop · 2018-01-02T12:06:09Z

There were the following issues with your Pull Request

Commit: c927b6a
Commits must be in the following format: %{type}(%{scope}): %{description}
Your subject line is longer than 72 characters
Invalid type. Valid types are feat, fix, docs, style, refactor, perf, test, chore, revert
Commit: 9c3af65
Commits must be in the following format: %{type}(%{scope}): %{description}
Commit: eb65525
Commits must be in the following format: %{type}(%{scope}): %{description}
Commit: 1908ff2
Commits must be in the following format: %{type}(%{scope}): %{description}
Your subject line is longer than 72 characters
Commit: 8666314
Commits must be in the following format: %{type}(%{scope}): %{description}
Commit: 3b709fe
Commits must be in the following format: %{type}(%{scope}): %{description}
Commit: 3e69a85
Commits must be in the following format: %{type}(%{scope}): %{description}

Guidelines are available at https://github.com/microdevs/missy

This message was auto-generated by https://gitcop.com

GitCop · 2018-01-02T12:24:23Z

There were the following issues with your Pull Request

Commit: c927b6a
Commits must be in the following format: %{type}(%{scope}): %{description}
Your subject line is longer than 72 characters
Invalid type. Valid types are feat, fix, docs, style, refactor, perf, test, chore, revert
Commit: 9c3af65
Commits must be in the following format: %{type}(%{scope}): %{description}
Commit: eb65525
Commits must be in the following format: %{type}(%{scope}): %{description}
Commit: 1908ff2
Commits must be in the following format: %{type}(%{scope}): %{description}
Your subject line is longer than 72 characters
Commit: 8666314
Commits must be in the following format: %{type}(%{scope}): %{description}
Commit: 3b709fe
Commits must be in the following format: %{type}(%{scope}): %{description}
Commit: 3e69a85
Commits must be in the following format: %{type}(%{scope}): %{description}
Commit: 416ea8a
Commits must be in the following format: %{type}(%{scope}): %{description}

Guidelines are available at https://github.com/microdevs/missy

This message was auto-generated by https://gitcop.com

coveralls · 2018-01-02T12:25:33Z

Coverage increased (+1.3%) to 48.288% when pulling 416ea8a on providing-resources into b0aa3a4 on master.

GitCop · 2018-01-02T12:34:50Z

There were the following issues with your Pull Request

Commit: c927b6a
Commits must be in the following format: %{type}(%{scope}): %{description}
Your subject line is longer than 72 characters
Invalid type. Valid types are feat, fix, docs, style, refactor, perf, test, chore, revert
Commit: 9c3af65
Commits must be in the following format: %{type}(%{scope}): %{description}
Commit: eb65525
Commits must be in the following format: %{type}(%{scope}): %{description}
Commit: 1908ff2
Commits must be in the following format: %{type}(%{scope}): %{description}
Your subject line is longer than 72 characters
Commit: 8666314
Commits must be in the following format: %{type}(%{scope}): %{description}
Commit: 3b709fe
Commits must be in the following format: %{type}(%{scope}): %{description}
Commit: 3e69a85
Commits must be in the following format: %{type}(%{scope}): %{description}
Commit: 416ea8a
Commits must be in the following format: %{type}(%{scope}): %{description}
Commit: f6f06d3
Commits must be in the following format: %{type}(%{scope}): %{description}
Invalid type. Valid types are feat, fix, docs, style, refactor, perf, test, chore, revert

Guidelines are available at https://github.com/microdevs/missy

This message was auto-generated by https://gitcop.com

coveralls · 2018-01-02T12:36:07Z

Coverage increased (+1.3%) to 48.288% when pulling f6f06d3 on providing-resources into b0aa3a4 on master.

GitCop · 2018-01-02T13:10:48Z

There were the following issues with your Pull Request

Commit: c927b6a
Commits must be in the following format: %{type}(%{scope}): %{description}
Your subject line is longer than 72 characters
Invalid type. Valid types are feat, fix, docs, style, refactor, perf, test, chore, revert
Commit: 9c3af65
Commits must be in the following format: %{type}(%{scope}): %{description}
Commit: eb65525
Commits must be in the following format: %{type}(%{scope}): %{description}
Commit: 1908ff2
Commits must be in the following format: %{type}(%{scope}): %{description}
Your subject line is longer than 72 characters
Commit: 8666314
Commits must be in the following format: %{type}(%{scope}): %{description}
Commit: 3b709fe
Commits must be in the following format: %{type}(%{scope}): %{description}
Commit: 3e69a85
Commits must be in the following format: %{type}(%{scope}): %{description}
Commit: 416ea8a
Commits must be in the following format: %{type}(%{scope}): %{description}
Commit: f6f06d3
Commits must be in the following format: %{type}(%{scope}): %{description}
Invalid type. Valid types are feat, fix, docs, style, refactor, perf, test, chore, revert
Commit: 1039c77
Commits must be in the following format: %{type}(%{scope}): %{description}

Guidelines are available at https://github.com/microdevs/missy

This message was auto-generated by https://gitcop.com

GitCop · 2018-01-02T13:11:24Z

There were the following issues with your Pull Request

Commit: c927b6a
Commits must be in the following format: %{type}(%{scope}): %{description}
Your subject line is longer than 72 characters
Invalid type. Valid types are feat, fix, docs, style, refactor, perf, test, chore, revert
Commit: 9c3af65
Commits must be in the following format: %{type}(%{scope}): %{description}
Commit: eb65525
Commits must be in the following format: %{type}(%{scope}): %{description}
Commit: 1908ff2
Commits must be in the following format: %{type}(%{scope}): %{description}
Your subject line is longer than 72 characters
Commit: 8666314
Commits must be in the following format: %{type}(%{scope}): %{description}
Commit: 3b709fe
Commits must be in the following format: %{type}(%{scope}): %{description}
Commit: 3e69a85
Commits must be in the following format: %{type}(%{scope}): %{description}
Commit: 416ea8a
Commits must be in the following format: %{type}(%{scope}): %{description}
Commit: f6f06d3
Commits must be in the following format: %{type}(%{scope}): %{description}
Invalid type. Valid types are feat, fix, docs, style, refactor, perf, test, chore, revert
Commit: 1039c77
Commits must be in the following format: %{type}(%{scope}): %{description}
Commit: 24bad59
Commits must be in the following format: %{type}(%{scope}): %{description}

Guidelines are available at https://github.com/microdevs/missy

This message was auto-generated by https://gitcop.com

coveralls · 2018-01-02T13:12:11Z

Coverage increased (+1.2%) to 48.113% when pulling 24bad59 on providing-resources into b0aa3a4 on master.

coveralls · 2018-01-02T13:12:41Z

Coverage increased (+1.3%) to 48.288% when pulling 24bad59 on providing-resources into b0aa3a4 on master.

levrik · 2018-03-22T18:48:35Z

@wojciech12 Why closed?

wojciech12 · 2018-03-22T20:56:28Z

@levrik We can reopen it when we go back to discussion about implementing standard clients.

levrik · 2018-03-26T09:17:51Z

@wojciech12 Can we please just leave it open so we don't forget about it?

wojciech12 · 2018-03-26T09:27:40Z

@levrik if we forget about it, it would mean we did not need it in the first place. So I will keep it close.

levrik · 2018-03-26T12:41:30Z

@wojciech12 I disagree but okay.

slot added 4 commits December 7, 2017 09:57

- added resource config in config model- added mysql resource with se…

c927b6a

…tup() func that will add parameters to config- changed location where config.parseEnv() is being called

added mysql resource and initi function

9c3af65

Finalized providing simple mysql resource

eb65525

added error handling if resource is not configured but is used by the…

1908ff2

… developer

slot requested a review from wojciech12 December 11, 2017 15:31

slot added 2 commits December 12, 2017 10:34

added slack badge [ci skip]

8666314

merged master

3a28987

levrik reviewed Dec 12, 2017

View reviewed changes

slot added 2 commits December 12, 2017 16:34

merging master

1dd82af

fixed lint issues and go fmt

3b709fe

Provide an example for mongodb

3e69a85

Provide a resource for mongodb

416ea8a

Do not call Session.Clone() in MgoSession()

f6f06d3

Add mgo setup in resource.Setup

1039c77

Add mgo setup in resource.Setup

24bad59

wojciech12 closed this Mar 22, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Providing resources (simple MySQL implementation) #12

Providing resources (simple MySQL implementation) #12

slot commented Dec 11, 2017

levrik Dec 12, 2017

mize85 commented Dec 12, 2017

coveralls commented Dec 12, 2017

GitCop commented Jan 2, 2018

GitCop commented Jan 2, 2018

coveralls commented Jan 2, 2018

GitCop commented Jan 2, 2018

coveralls commented Jan 2, 2018

GitCop commented Jan 2, 2018

GitCop commented Jan 2, 2018

coveralls commented Jan 2, 2018

coveralls commented Jan 2, 2018

levrik commented Mar 22, 2018

wojciech12 commented Mar 22, 2018

levrik commented Mar 26, 2018

wojciech12 commented Mar 26, 2018

levrik commented Mar 26, 2018

Providing resources (simple MySQL implementation) #12

Providing resources (simple MySQL implementation) #12

Conversation

slot commented Dec 11, 2017

levrik Dec 12, 2017

Choose a reason for hiding this comment

mize85 commented Dec 12, 2017

coveralls commented Dec 12, 2017

GitCop commented Jan 2, 2018

GitCop commented Jan 2, 2018

coveralls commented Jan 2, 2018

GitCop commented Jan 2, 2018

coveralls commented Jan 2, 2018

GitCop commented Jan 2, 2018

GitCop commented Jan 2, 2018

coveralls commented Jan 2, 2018

coveralls commented Jan 2, 2018

levrik commented Mar 22, 2018

wojciech12 commented Mar 22, 2018

levrik commented Mar 26, 2018

wojciech12 commented Mar 26, 2018

levrik commented Mar 26, 2018