Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

synchronically commits #25

Merged
merged 1 commit into from
Mar 14, 2018
Merged

synchronically commits #25

merged 1 commit into from
Mar 14, 2018

Conversation

pbrzostowski
Copy link
Contributor

I think that we actually want to have sync commits of the messages. In case that there is an error during commitment we want to know that.

@GitCop
Copy link

GitCop commented Mar 6, 2018

There were the following issues with your Pull Request

  • Commit: 6001503
  • Commits must be in the following format: %{type}(%{scope}): %{description}

Guidelines are available at https://github.com/microdevs/missy


This message was auto-generated by https://gitcop.com

@michalkarolik michalkarolik requested review from michalkarolik and removed request for michalkarolik March 9, 2018 13:22
@michalkarolik
Copy link
Contributor

Just to clarify why we need that: if reader would commit offset asynchronously its very likely that it will fetch the very same message on next poll.

@pbrzostowski pbrzostowski merged commit 5ee5679 into microdevs:master Mar 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants