Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(messaging): added consumer retention duration #71

Merged
merged 1 commit into from
Mar 26, 2019
Merged

feat(messaging): added consumer retention duration #71

merged 1 commit into from
Mar 26, 2019

Conversation

pbrzostowski
Copy link
Contributor

We wan to be able to configure kafka consumer retention duration. This implements this by using env. var.

@pbrzostowski pbrzostowski requested review from mwarzynski, wojciech12 and a team March 26, 2019 11:20
wojciech12
wojciech12 reviewed Mar 26, 2019
View reviewed changes
messaging/config.go Outdated Show resolved Hide resolved
@mwarzynski mwarzynski merged commit 483f1df into microdevs:master Mar 26, 2019
@pbrzostowski pbrzostowski deleted the consumer-retention branch April 9, 2019 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wojciech12 wojciech12 wojciech12 left review comments

@mwarzynski mwarzynski mwarzynski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pbrzostowski @mwarzynski @wojciech12