Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MVP Cast API #555

Merged
merged 19 commits into from
May 27, 2019
Merged

MVP Cast API #555

merged 19 commits into from
May 27, 2019

Conversation

emlove
Copy link
Contributor

@emlove emlove commented Jun 14, 2018

Description

This PR is the next step in the cast implementation, and is capable of playing videos with Google's sample Cast-Videos app. Basic cast functionality is now functional. Device discovery is implemented. Standard cast apps can now connect, start videos, and control playback.

Fixes #79

Still broken

  • There's still something preventing Netflix from starting videos. It must make use of some cast code that isn't yet implemented
  • Volume control is not functional
  • Joining an existing session is not implemented

Dependencies

@emlove
Copy link
Contributor Author

emlove commented Sep 3, 2018

OK, I've got a published branch working for the necessary upstream chromecast APIs. This PR builds and should be testable now.

@csagan5
Copy link

csagan5 commented Nov 11, 2018

There are some new objects missing, probably additions in recent SDKs.

@emlove
Copy link
Contributor Author

emlove commented Nov 12, 2018

@csagan5 Let's please keep this discussion limited to merging this into microG for now. This isn't meant to be 100% complete. Also could you please remove that giant error dump? It's not useful for this PR and is interrupting the thread here.

@csagan5
Copy link

csagan5 commented Nov 12, 2018

@armills I suggest asking project admins to amend the comments next time, it avoids further interruptions of the comments flow.

@emlove
Copy link
Contributor Author

emlove commented Nov 26, 2018

@mar-v-in Is there anything you need before the PR can be reviewed?

@cosmojg
Copy link

cosmojg commented Feb 5, 2019

Will this be merged soon? Also, @armills, how did you accomplish this? Great work!

@ale5000-git
Copy link
Member

ale5000-git commented Feb 5, 2019

Probably in March.

Quote from MaR-V-iN:

I am still alive, but just super busy.

Starting end of February, I set aside 20 hours a week to work solely on microG.

But please don't expect any update earlier than that, I have to ensure that there are no loose ends before I remove myself from some of the obligations I have right now, so probably will be even busier than before.

Thanks for your ongoing support everyone.

@ale5000-git
Copy link
Member

@armills: Could you please resolve conflicts?

@emlove
Copy link
Contributor Author

emlove commented Mar 10, 2019

👍 All set

settings.gradle Outdated Show resolved Hide resolved
@pedro-araujo
Copy link

I just compiled and tested this, I can connect to my TV wirelessly and play videos with audio through the TV. I just have one question: the colors seemed a bit washed off and the frame rate a bit choppy, the audio sounds normal though. Is this expected due to the early implementation of the Cast API?

@emlove
Copy link
Contributor Author

emlove commented Mar 12, 2019

Thanks for testing this out! I know this branch hasn't gotten a lot of real world testing, so it's good to know it's working for you!

The video quality won't really have anything to do with this implementation. The cast API just passes a video URL to the chromecast, which then streams the video directly from the source.

@MrDodojo
Copy link

MrDodojo commented Mar 13, 2019

Thanks for testing this out! I know this branch hasn't gotten a lot of real world testing, so it's good to know it's working for you!

The video quality won't really have anything to do with this implementation. The cast API just passes a video URL to the chromecast, which then streams the video directly from the source.

This means YouTube Casting will work IF merged with MicroG?

@MrDodojo
Copy link

MrDodojo commented Mar 13, 2019

Thanks for testing this out! I know this branch hasn't gotten a lot of real world testing, so it's good to know it's working for you!

The video quality won't really have anything to do with this implementation. The cast API just passes a video URL to the chromecast, which then streams the video directly from the source.

Nice! you could probably ask the YouTube Vanced(dev/staff, Testers) gang to test this

@ale5000-git
Copy link
Member

ale5000-git commented Mar 21, 2019

@armills @mar-v-in
Note => There must be fix #79 in the commit to claim the bounty.

@CFPrulez
Copy link

What is currently preventing the branch from being merged? Is there anything that has to be done before?

@MrDodojo
Copy link

What is currently preventing the branch from being merged? Is there anything that has to be done before?
Devs probs busy

@ivanfilhoz
Copy link

For an MVP, this seems awesome! I will test in my Chromecast 3 and give some more feedback.

@mar-v-in mar-v-in merged commit a80b263 into microg:master May 27, 2019
@ale5000-git
Copy link
Member

ale5000-git commented May 27, 2019

@mar-v-in
@armills
I don't know this code enough to tell it but is <item> expected to be here?

@mar-v-in
Copy link
Member

No, it shouldn't be there, will fix it right away.

@ale5000-git
Copy link
Member

ale5000-git commented May 28, 2019

@armills: Did you claimed the bounty here?

@emlove emlove deleted the cast-mvp branch May 28, 2019 14:43
@emlove
Copy link
Contributor Author

emlove commented May 28, 2019

Submitted!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cast API not implemented [$255 PAID] [$255 awarded]
9 participants