-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MVP Cast API #555
MVP Cast API #555
Conversation
OK, I've got a published branch working for the necessary upstream chromecast APIs. This PR builds and should be testable now. |
There are some new objects missing, probably additions in recent SDKs. |
@csagan5 Let's please keep this discussion limited to merging this into microG for now. This isn't meant to be 100% complete. Also could you please remove that giant error dump? It's not useful for this PR and is interrupting the thread here. |
@armills I suggest asking project admins to amend the comments next time, it avoids further interruptions of the comments flow. |
@mar-v-in Is there anything you need before the PR can be reviewed? |
Will this be merged soon? Also, @armills, how did you accomplish this? Great work! |
Probably in March. Quote from MaR-V-iN:
|
@armills: Could you please resolve conflicts? |
👍 All set |
I just compiled and tested this, I can connect to my TV wirelessly and play videos with audio through the TV. I just have one question: the colors seemed a bit washed off and the frame rate a bit choppy, the audio sounds normal though. Is this expected due to the early implementation of the Cast API? |
Thanks for testing this out! I know this branch hasn't gotten a lot of real world testing, so it's good to know it's working for you! The video quality won't really have anything to do with this implementation. The cast API just passes a video URL to the chromecast, which then streams the video directly from the source. |
This means YouTube Casting will work IF merged with MicroG? |
Nice! you could probably ask the YouTube Vanced(dev/staff, Testers) gang to test this |
What is currently preventing the branch from being merged? Is there anything that has to be done before? |
|
For an MVP, this seems awesome! I will test in my Chromecast 3 and give some more feedback. |
No, it shouldn't be there, will fix it right away. |
Submitted! |
Description
This PR is the next step in the cast implementation, and is capable of playing videos with Google's sample Cast-Videos app. Basic cast functionality is now functional. Device discovery is implemented. Standard cast apps can now connect, start videos, and control playback.
Fixes #79
Still broken
Dependencies