feat: kill & respawn a new browser instance under diconnect (#68)

* build: ensure kill chrome on disconnect

avoid zombie process, it's based on puppeteer/puppeteer#1825

* Update packages/browserless/src/index.js

Co-Authored-By: Luc <luc.leray@gmail.com>

* build: ensure to remove files associated

* build: remove unnecessary dependency

* build: add debug trace

* build: use repo installation

* build: add some node builds

* build: ensure close browser

Author: Kikobeats

.travis.yml

@@ -2,7 +2,8 @@ language: node_js
 
 node_js:
   - lts/*
-  - node
+  - 10
+  - 8
 
 after_success: npm run coverage
 

packages/browserless/package.json

@@ -34,8 +34,12 @@
     "@browserless/goto": "^5.10.2",
     "@browserless/pdf": "^5.10.2",
     "@browserless/screenshot": "^5.10.2",
+    "debug-logfmt": "~1.0.2",
+    "del": "~5.0.0",
+    "fkill": "~6.2.0",
     "p-timeout": "~3.1.0",
-    "require-one-of": "~1.0.11"
+    "require-one-of": "~1.0.11",
+    "waitpid2": "github:joshiggins/node-waitpid2"
   },
   "devDependencies": {
     "@browserless/test": "latest",

packages/browserless/src/index.js

@@ -1,14 +1,27 @@
 'use strict'
 
+const debug = require('debug-logfmt')('browserless:goto')
 const devices = require('@browserless/devices')
 const requireOneOf = require('require-one-of')
 const goto = require('@browserless/goto')
 const pTimeout = require('p-timeout')
+const waitpid2 = require('waitpid2')
+const fkill = require('fkill')
+const del = require('del')
 
 const EVALUATE_TEXT = page => page.evaluate(() => document.body.innerText)
 
 const EVALUATE_HTML = page => page.content()
 
+const killBrowser = async browser => {
+  while (waitpid2.waitpid(-1, 0 | waitpid2.WNOHANG) === -1);
+  await browser.close()
+  const pid = browser.process().pid
+  await fkill(pid)
+  const deletedPaths = await del(['/tmp/core.chromium.*', '/tmp/puppeteer_dev_profile*'])
+  debug('killBrowser', { pid, deletedPaths })
+}
+
 module.exports = ({
   puppeteer = requireOneOf(['puppeteer', 'puppeteer-core', 'puppeteer-firefox']),
   incognito = false,
@@ -17,7 +30,7 @@ module.exports = ({
 } = {}) => {
   let browser
 
-  const createBrowser = async () => {
+  const spawnBrowser = async () => {
     browser = await puppeteer.launch({
       ignoreHTTPSErrors: true,
       args: [
@@ -38,12 +51,15 @@ module.exports = ({
       ...launchOpts
     })
 
-    browser.on('disconnected', createBrowser)
+    browser.on('disconnected', async () => {
+      await killBrowser()
+      spawnBrowser()
+    })
 
     return browser
   }
 
-  browser = createBrowser()
+  browser = spawnBrowser()
 
   const createPage = () =>
     Promise.resolve(browser).then(async browser => {

packages/goto/package.json

@@ -30,7 +30,6 @@
   "dependencies": {
     "@browserless/devices": "^5.5.5",
     "@cliqz/adblocker-puppeteer": "~0.13.2",
-    "debug": "~4.1.1",
     "debug-logfmt": "~1.0.2",
     "got": "~9.6.0",
     "p-timeout": "~3.1.0",