Ensure favicon path is absolute

Author: Kikobeats

packages/metascraper-logo-favicon/.metascraperrc

@@ -0,0 +1,14 @@
+{
+  "rules": [
+    "metascraper-amazon",
+    "metascraper-author",
+    "metascraper-date",
+    "metascraper-description",
+    "metascraper-image",
+    "metascraper-logo",
+    "metascraper-logo-favicon",
+    "metascraper-publisher",
+    "metascraper-title",
+    "metascraper-url"
+  ]
+}

packages/metascraper-logo-favicon/__snapshots__/index.js.snap-shot

@@ -0,0 +1,10 @@
+exports['create an absolute faivcon url if the logo is not present 1'] = {
+  "author": "Mat Follas",
+  "title": "Vegetable Perfection: 100 delicious recipes for roots, bulbs, shoots and stems",
+  "publisher": "Amazon",
+  "image": "https://images-eu.ssl-images-amazon.com/images/I/61Q2c36lYeL._SX218_BO1,204,203,200_QL40_.jpg",
+  "description": "Buy Vegetable Perfection: 100 delicious recipes for roots, bulbs, shoots and stems by Mat Follas (ISBN: 9781849757096) from Amazon’s Book Store. Everyday low prices and free delivery on eligible orders.",
+  "logo": "https://www.amazon.co.uk/favicon.ico",
+  "url": "https://www.amazon.co.uk/Vegetable-Perfection-tasty-recipes-shoots/dp/1849757097/ref=asap_bc?ie=UTF8"
+}
+

packages/metascraper-logo-favicon/index.js

@@ -1,7 +1,12 @@
 'use strict'
 
-const { getUrl } = require('@metascraper/helpers')
+const { resolve: resolveUrl, URL } = require('url')
+
+const getFaviconUrl = url => {
+  const {origin} = new URL(url)
+  return resolveUrl(origin, 'favicon.ico')
+}
 
 module.exports = () => ({
-  logo: [({ htmlDom: $, meta, url }) => getUrl(url, `favicon.ico`)]
+  logo: [({ htmlDom: $, meta, url }) => getFaviconUrl(url)]
 })

packages/metascraper-logo-favicon/package.json

@@ -20,10 +20,13 @@
     "clearbit",
     "metascraper"
   ],
-  "dependencies": {
-    "@metascraper/helpers": "^3.3.0"
-  },
   "devDependencies": {
+    "clear-module": "latest",
+    "lodash": "latest",
+    "mocha": "latest",
+    "nyc": "latest",
+    "should": "latest",
+    "snap-shot": "latest",
     "standard": "latest"
   },
   "engines": {
@@ -33,7 +36,7 @@
     "index.js"
   ],
   "scripts": {
-    "test": "exit 0"
+    "test": "NODE_PATH=.. TZ=UTC NODE_ENV=test nyc mocha test"
   },
   "license": "MIT",
   "lint-staged": {

packages/metascraper-logo-favicon/test/fixtures/input.html

@@ -0,0 +1,32 @@
+'use strict'
+
+const clearModule = require('clear-module')
+const snapshot = require('snap-shot')
+const { promisify } = require('util')
+const { resolve } = require('path')
+const { omit } = require('lodash')
+const fs = require('fs')
+
+const readFile = promisify(fs.readFile)
+
+describe('metascraper amazon integration', () => {
+  before(() => {
+    clearModule.all()
+    process.env.METASCRAPER_CONFIG_CWD = __dirname
+  })
+
+  after(() => {
+    clearModule.all()
+    delete process.env.METASCRAPER_CONFIG_CWD
+  })
+
+  describe('metascraper logo favicon', () => {
+    it('create an absolute faivcon url if the logo is not present', async () => {
+      const metascraper = require('metascraper')
+      const html = await readFile(resolve(__dirname, 'fixtures/input.html'))
+      const url = 'https://www.amazon.co.uk/Vegetable-Perfection-tasty-recipes-shoots/dp/1849757097/ref=asap_bc?ie=UTF8'
+      const meta = omit(await metascraper({ html, url }), ['date'])
+      snapshot(meta)
+    })
+  })
+})

packages/metascraper-logo-favicon/test/index.js

@@ -0,0 +1,6 @@
+--require should
+--reporter spec
+--timeout 120000
+--slow 300
+--bail
+--recursive