Skip to content

Commit 3040379

Browse files
committed
Improve logo detection
1 parent 108e79c commit 3040379

File tree

3 files changed

+2
-2
lines changed

3 files changed

+2
-2
lines changed

__snapshots__/index.js.snap-shot

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -196,7 +196,7 @@ exports['et-tech 1'] = {
196196
"description": "Dell speaks about the complexities of engineering the biggest acquisition in tech history, Dell’s future bets and why he continues to remain bullish..",
197197
"favicon": "http://b2bstatic.iimg.in/Themes/Release/images/tech-favicon.ico",
198198
"image": "http://economictimes.indiatimes.com/photo/michael-dell-on-complexities-involved-in-pulling-off-the-biggest-tech-acquisition-dell-s-future-bets-more/52424992.cms",
199-
"logo": "http://b2bstatic.iimg.in/Themes/Release/images/responsive/tech-logo-footer.png",
199+
"logo": "http://b2bstatic.iimg.in/Themes/Release/images/responsive/tech-logo-square.jpg",
200200
"publisher": "ETtech.com",
201201
"title": "Michael Dell on complexities involved in pulling off the biggest tech acquisition, Dell’s future bets & more | ETtech",
202202
"url": "http://tech.economictimes.indiatimes.com/news/corporate/michael-dell-biggest-tech-acquisition-future-bets/52424992"

src/get-data/rules/logo.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@ const wrap = rule => (htmlDom, baseUrl) => {
2323
module.exports = [
2424
wrap($ => $('meta[property="og:logo"]').attr('content')),
2525
wrap($ => $('meta[itemprop="logo"]').attr('content')),
26+
wrap($ => $('img[itemprop="logo"]').attr('src')),
2627
wrap($ => $('img[src*="logo"]').attr('src')),
2728
wrap($ => $('img[class*="logo"]').attr('src'))
2829
]

test/mocha.opts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,5 +2,4 @@
22
--reporter list
33
--timeout 120000
44
--slow 300
5-
--bail
65
--recursive

0 commit comments

Comments
 (0)