Skip to content

Commit 7a5619f

Browse files
committed
Extract fixed favicon value into separate package
Sort rules based on config priority
1 parent 3e87ec4 commit 7a5619f

File tree

5 files changed

+77
-3
lines changed

5 files changed

+77
-3
lines changed
Lines changed: 23 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,23 @@
1+
# metascraper-logo-favicon
2+
3+
![Last version](https://img.shields.io/github/tag/microlinkhq/metascraper-logo-favicon.svg?style=flat-square)
4+
[![Build Status](https://img.shields.io/travis/microlinkhq/metascraper-logo-favicon/master.svg?style=flat-square)](https://travis-ci.org/microlinkhq/metascraper-logo-favicon)
5+
[![Coverage Status](https://img.shields.io/coveralls/microlinkhq/metascraper-logo-favicon.svg?style=flat-square)](https://coveralls.io/github/microlinkhq/metascraper-logo-favicon)
6+
[![Dependency status](https://img.shields.io/david/microlinkhq/metascraper-logo-favicon.svg?style=flat-square)](https://david-dm.org/microlinkhq/metascraper-logo-favicon)
7+
[![Dev Dependencies Status](https://img.shields.io/david/dev/microlinkhq/metascraper-logo-favicon.svg?style=flat-square)](https://david-dm.org/microlinkhq/metascraper-logo-favicon#info=devDependencies)
8+
[![NPM Status](https://img.shields.io/npm/dm/metascraper-logo-favicon.svg?style=flat-square)](https://www.npmjs.org/package/metascraper-logo-favicon)
9+
10+
> metascraper logo favicon fallback.
11+
12+
## Install
13+
14+
```bash
15+
$ npm install metascraper-logo-favicon --save
16+
```
17+
18+
## License
19+
20+
**metascraper-logo-favicon** © [microlink.io](https://microlink.io), Released under the [MIT](https://github.com/microlinkhq/metascraper-logo-favicon/blob/master/LICENSE.md) License.<br>
21+
Authored and maintained by microlink.io with help from [contributors](https://github.com/microlinkhq/metascraper-logo-favicon/contributors).
22+
23+
> [microlink.io](https://microlink.io) · GitHub [@microlink.io](https://github.com/microlinkhq) · Twitter [@microlinkhq](https://twitter.com/microlinkhq)
Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
'use strict'
2+
3+
module.exports = () => ({
4+
logo: [({ htmlDom: $, meta, url }) => `${url}/favicon.ico`]
5+
})
Lines changed: 47 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,47 @@
1+
{
2+
"name": "metascraper-logo-favicon",
3+
"description": "metascraper logo favicon fallback",
4+
"homepage": "https://documentup.com/microlinkhq/metascraper-logo-favicon",
5+
"version": "0.0.0",
6+
"main": "index.js",
7+
"author": {
8+
"email": "hello@microlink.io",
9+
"name": "microlink.io",
10+
"url": "https://microlink.io"
11+
},
12+
"repository": {
13+
"type": "git",
14+
"url": "git+https://github.com/microlinkhq/metascraper-logo-favicon.git"
15+
},
16+
"bugs": {
17+
"url": "https://github.com/microlinkhq/metascraper-logo-favicon/issues"
18+
},
19+
"keywords": [
20+
"clearbit",
21+
"metascraper"
22+
],
23+
"devDependencies": {
24+
"standard": "latest"
25+
},
26+
"engines": {
27+
"node": ">= 8"
28+
},
29+
"files": [
30+
"index.js"
31+
],
32+
"scripts": {
33+
"test": "exit 0"
34+
},
35+
"license": "MIT",
36+
"lint-staged": {
37+
"*.js": [
38+
"prettier-standard",
39+
"git add"
40+
]
41+
},
42+
"standard": {
43+
"env": [
44+
"mocha"
45+
]
46+
}
47+
}

packages/metascraper-logo/index.js

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,6 @@ module.exports = () => ({
6868
.get('link')
6969
.value()
7070
return size
71-
}),
72-
wrap($ => '/favicon.ico')
71+
})
7372
]
7473
})

packages/metascraper/src/load-rules.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ module.exports = () =>
5252
forEach(rules, function (rule, propName) {
5353
const index = findIndex(acc, item => item[propName])
5454
if (index !== -1) {
55-
acc[index][propName] = rule.concat(acc[index][propName])
55+
acc[index][propName] = acc[index][propName].concat(rule)
5656
} else {
5757
acc.push({ [propName]: rule })
5858
}

0 commit comments

Comments
 (0)