feat: reduce rules on parallel (#157)

* refactor: less code

* feat: reduce rules on parallel

BREAKING CHANGE: 'meta' can't be passed as shared resource

* build: deprecated lang-detector

Author: Kikobeats

README.md

@@ -197,7 +197,6 @@ const metascraper = require('metascraper')([
 | [`@metascraper/helpers`](https://github.com/microlinkhq/metascraper/tree/master/packages/metascraper-helpers) | [![npm](https://img.shields.io/npm/v/@metascraper/helpers.svg?style=flat-square)](https://www.npmjs.com/package/@metascraper/helpers) | [![Dependency Status](https://david-dm.org/microlinkhq/metascraper.svg?path=packages/metascraper-helpers&style=flat-square)](https://david-dm.org/microlinkhq/metascraper?path=packages/metascraper-helpers) |
 | [`metascraper-image`](https://github.com/microlinkhq/metascraper/tree/master/packages/metascraper-image) | [![npm](https://img.shields.io/npm/v/metascraper-image.svg?style=flat-square)](https://www.npmjs.com/package/metascraper-image) | [![Dependency Status](https://david-dm.org/microlinkhq/metascraper.svg?path=packages/metascraper-image&style=flat-square)](https://david-dm.org/microlinkhq/metascraper?path=packages/metascraper-image) |
 | [`metascraper-lang`](https://github.com/microlinkhq/metascraper/tree/master/packages/metascraper-lang) | [![npm](https://img.shields.io/npm/v/metascraper-lang.svg?style=flat-square)](https://www.npmjs.com/package/metascraper-lang) | [![Dependency Status](https://david-dm.org/microlinkhq/metascraper.svg?path=packages/metascraper-lang&style=flat-square)](https://david-dm.org/microlinkhq/metascraper?path=packages/metascraper-lang) |
-| [`metascraper-lang-detector`](https://github.com/microlinkhq/metascraper/tree/master/packages/metascraper-lang-detector) | [![npm](https://img.shields.io/npm/v/metascraper-lang-detector.svg?style=flat-square)](https://www.npmjs.com/package/metascraper-lang-detector) | [![Dependency Status](https://david-dm.org/microlinkhq/metascraper.svg?path=packages/metascraper-lang-detector&style=flat-square)](https://david-dm.org/microlinkhq/metascraper?path=packages/metascraper-lang-detector) |
 | [`metascraper-logo`](https://github.com/microlinkhq/metascraper/tree/master/packages/metascraper-logo) | [![npm](https://img.shields.io/npm/v/metascraper-logo.svg?style=flat-square)](https://www.npmjs.com/package/metascraper-logo) | [![Dependency Status](https://david-dm.org/microlinkhq/metascraper.svg?path=packages/metascraper-logo&style=flat-square)](https://david-dm.org/microlinkhq/metascraper?path=packages/metascraper-logo) |
 | [`metascraper-logo-favicon`](https://github.com/microlinkhq/metascraper/tree/master/packages/metascraper-logo-favicon) | [![npm](https://img.shields.io/npm/v/metascraper-logo-favicon.svg?style=flat-square)](https://www.npmjs.com/package/metascraper-logo-favicon) | [![Dependency Status](https://david-dm.org/microlinkhq/metascraper.svg?path=packages/metascraper-logo-favicon&style=flat-square)](https://david-dm.org/microlinkhq/metascraper?path=packages/metascraper-logo-favicon) |
 | [`metascraper-media-provider`](https://github.com/microlinkhq/metascraper/tree/master/packages/metascraper-media-provider) | [![npm](https://img.shields.io/npm/v/metascraper-media-provider.svg?style=flat-square)](https://www.npmjs.com/package/metascraper-media-provider) | [![Dependency Status](https://david-dm.org/microlinkhq/metascraper.svg?path=packages/metascraper-media-provider&style=flat-square)](https://david-dm.org/microlinkhq/metascraper?path=packages/metascraper-media-provider) |
@@ -209,7 +208,6 @@ const metascraper = require('metascraper')([
 | [`metascraper-video`](https://github.com/microlinkhq/metascraper/tree/master/packages/metascraper-video) | [![npm](https://img.shields.io/npm/v/metascraper-video.svg?style=flat-square)](https://www.npmjs.com/package/metascraper-video) | [![Dependency Status](https://david-dm.org/microlinkhq/metascraper.svg?path=packages/metascraper-video&style=flat-square)](https://david-dm.org/microlinkhq/metascraper?path=packages/metascraper-video) |
 | [`metascraper-youtube`](https://github.com/microlinkhq/metascraper/tree/master/packages/metascraper-youtube) | [![npm](https://img.shields.io/npm/v/metascraper-youtube.svg?style=flat-square)](https://www.npmjs.com/package/metascraper-youtube) | [![Dependency Status](https://david-dm.org/microlinkhq/metascraper.svg?path=packages/metascraper-youtube&style=flat-square)](https://david-dm.org/microlinkhq/metascraper?path=packages/metascraper-youtube) |
 
-
 ### Write your own rules
 
 A rule bundle is the simplest way for extending **metascraper** functionality.
@@ -230,10 +228,9 @@ module.exports = opts => {
       // You can setup more than one rules per prop (priority is important!).
       // They receive as parameter:
       // - `htmlDom`: the cheerio HTML instance.
-      // - `meta`: The current state of the information detected.
       // - `url`: The input URL used for extact the content.
-      ({ htmlDom: $, meta, url: baseUrl }) => wrap($ => $('meta[property="og:logo"]').attr('content')),
-      ({ htmlDom: $, meta, url: baseUrl }) => wrap($ => $('meta[itemprop="logo"]').attr('content'))
+      ({ htmlDom: $, url: baseUrl }) => wrap($ => $('meta[property="og:logo"]').attr('content')),
+      ({ htmlDom: $, url: baseUrl }) => wrap($ => $('meta[itemprop="logo"]').attr('content'))
     ]
   })
 }

packages/metascraper-lang-detector/.npmrc

@@ -55,7 +55,6 @@
     "cheerio": "~1.0.0-rc.2",
     "cheerio-advanced-selectors": "~2.0.1",
     "lodash": "~4.17.11",
-    "p-reduce": "~2.0.0",
     "whoops": "~4.0.2"
   },
   "devDependencies": {

packages/metascraper-lang-detector/CHANGELOG.md

@@ -1,7 +1,6 @@
 'use strict'
 
-const { isEmpty } = require('lodash')
-const pReduce = require('p-reduce')
+const { map, fromPairs, isEmpty } = require('lodash')
 
 const getValue = async ({ htmlDom, url, conditions, meta }) => {
   const size = conditions.length
@@ -15,15 +14,15 @@ const getValue = async ({ htmlDom, url, conditions, meta }) => {
   return value
 }
 
-const getData = ({ rules, htmlDom, url }) =>
-  pReduce(
-    rules,
-    async (acc, [propName, conditions]) => {
-      const value = await getValue({ htmlDom, url, conditions, meta: acc })
-      acc[propName] = !isEmpty(value) ? value : null
-      return acc
-    },
-    {}
+const getData = async ({ rules, htmlDom, url }) => {
+  const data = await Promise.all(
+    map(rules, async ([propName, conditions]) => {
+      const value = await getValue({ htmlDom, url, conditions })
+      return [propName, !isEmpty(value) ? value : null]
+    })
   )
 
+  return fromPairs(data)
+}
+
 module.exports = getData