Ensure to resolve a valid logo url

Author: Kikobeats

packages/metascraper-clearbit-logo/index.js

@@ -1,6 +1,7 @@
 'use strict'
 
 const { URL } = require('url')
+const got = require('got')
 
 const DEFAULTS = {
   size: '128',
@@ -13,9 +14,16 @@ module.exports = opts => {
   opts = Object.assign({}, DEFAULTS, opts)
   const { size, format } = opts
 
-  const clearbitLogo = ({ htmlDom, meta, url: baseUrl }) => {
-    const { hostname } = new URL(baseUrl)
-    return `${ENDPOINT}/${hostname}?size=${size}&format=${format}`
+  const clearbitLogo = async ({ url }) => {
+    const { hostname } = new URL(url)
+    const logoUrl = `${ENDPOINT}/${hostname}?size=${size}&format=${format}`
+
+    try {
+      await got.head(logoUrl)
+      return logoUrl
+    } catch (err) {
+      return null
+    }
   }
 
   return {

packages/metascraper-clearbit-logo/package.json

@@ -25,7 +25,6 @@
     "mocha": "latest",
     "nyc": "latest",
     "should": "latest",
-    "snap-shot": "latest",
     "standard": "latest"
   },
   "engines": {
@@ -48,5 +47,8 @@
     "env": [
       "mocha"
     ]
+  },
+  "dependencies": {
+    "got": "~8.3.0"
   }
 }

packages/metascraper-clearbit-logo/test/index.js

@@ -1,6 +1,6 @@
 'use strict'
 
-const snapshot = require('snap-shot')
+const should = require('should')
 
 const metascraper = require('metascraper').load([
   require('metascraper-author')(),
@@ -15,10 +15,17 @@ const metascraper = require('metascraper').load([
 ])
 
 describe('metascraper-clearbit-logo', () => {
-  it('if logo is not present, fallback to clearbit logo API', async () => {
+  it('returns when is possible resolve logo', async () => {
     const url = 'https://facebook.com'
     const html = '<div></div>'
     const meta = await metascraper({ html, url })
-    snapshot(meta)
+    should(meta.logo.indexOf('clearbit') !== -1).be.true()
+  })
+
+  it('otherwise returns null', async () => {
+    const url = 'https://lolwerhere.com'
+    const html = '<div></div>'
+    const meta = await metascraper({ html, url })
+    should(meta.logo).be.null()
   })
 })