Refactor

Author: Kikobeats

__snapshots__/index.js.snap-shot

@@ -647,7 +647,7 @@ exports['the-verge 1'] = {
   "url": "http://www.theverge.com/2016/5/24/11763836/apple-siri-speaker-amazon-echo-alexa-google-home-ai"
 }
 
-exports['twitter 1'] = {
+exports['twitter (tweet with gif) 1'] = {
   "author": "Kikobeats",
   "date": "2017-06-28T21:01:00.000Z",
   "description": "“Experimenting with Clearbit API + Apple TV 3D Parallax https://t.co/Qsm163k4mJ https://t.co/5bcuqoEyAa”",
@@ -658,7 +658,7 @@ exports['twitter 1'] = {
   "url": "https://twitter.com/Kikobeats/status/880139124791029763"
 }
 
-exports['twitter 2'] = {
+exports['twitter (tweet with image) 1'] = {
   "author": "K4rliky",
   "date": "2017-11-25T19:04:00.000Z",
   "description": "“Lo mejor de @codemotion_es #codemotionMadrid es estar con la gente que quieres 😍@ladyCircus”",

index.js

@@ -1,20 +1,23 @@
 'use strict'
 
-const {reduce} = require('lodash')
+const {isEmpty, reduce} = require('lodash')
 const {ensureAsync} = require('async')
 const {promisify} = require('util')
 
 const getData = require('./src/get-data')
 const loadHtml = require('./src/html')
-const {props} = getData
+const {props, getConnector} = getData
 
 const getMetaData = ensureAsync(({url, html}, cb) => {
   const htmlDom = loadHtml(html)
 
   const output = reduce(props, (acc, conditions, propName) => {
-    const value = getData({htmlDom, url, conditions})
-    // TODO: Avoid response nil values
-    acc[propName] = value
+    const value = Object.assign(
+      getData({htmlDom, url, conditions}) || {},
+      getConnector({htmlDom, url})
+    )
+
+    acc[propName] = !isEmpty(value) ? value : null
     return acc
   }, {})
 

src/get-data/connectors/index.js

@@ -0,0 +1,11 @@
+'use strict'
+
+const reqAll = require('req-all')
+const {find} = require('lodash')
+
+const domains = reqAll('./domains')
+
+module.exports = ({htmlDom, url}) => {
+  const connector = find(domains, domain => domain.test(url))
+  return connector && connector(({htmlDom, url}))
+}

src/get-data/index.js

@@ -1,26 +1,19 @@
 'use strict'
 
 const rules = require('req-all')('./rules')
+const {isEmpty} = require('lodash')
 
-const isValid = result => result !== null && result !== undefined && result !== ''
-
-const getValue = ({htmlDom, url, conditions}) => {
+module.exports = ({htmlDom, url, conditions}) => {
   const size = conditions.length
   let index = -1
-  let value = null
+  let value
 
-  while (!isValid(value) && index++ < size - 1) {
+  while (isEmpty(value) && index++ < size - 1) {
     value = conditions[index](htmlDom, url)
   }
 
   return value
 }
 
-const getData = ({htmlDom, url, conditions}) => {
-  const data = getValue({htmlDom, url, conditions})
-  return isValid(data) ? data : null
-}
-
-getData.props = rules
-
-module.exports = getData
+module.exports.props = rules
+module.exports.getConnector = require('./connectors')

src/html/index.js

@@ -1,25 +1,21 @@
 'use strict'
 
 const sanitizeHtml = require('sanitize-html')
-const {flow} = require('lodash')
+const {flow, isNil} = require('lodash')
 const cheerio = require('cheerio')
 
+const normalizeAttributes = propName => (tagName, attribs) => {
+  if (!isNil(attribs[propName])) attribs[propName] = attribs[propName].toLowerCase()
+  return {tagName, attribs}
+}
+
 const sanitize = html => sanitizeHtml(html, {
   allowedTags: false,
   allowedAttributes: false,
   transformTags: {
-    meta: (tagName, attribs) => {
-      if (attribs.name) attribs.name = attribs.name.toLowerCase()
-      return {tagName, attribs}
-    },
-    a: (tagName, attribs) => {
-      if (attribs.href) attribs.href = attribs.href.toLowerCase()
-      return {tagName, attribs}
-    },
-    link: (tagName, attribs) => {
-      if (attribs.rel) attribs.rel = attribs.rel.toLowerCase()
-      return {tagName, attribs}
-    }
+    meta: normalizeAttributes('name'),
+    a: normalizeAttributes('href'),
+    link: normalizeAttributes('rel')
   }
 })
 

test/web/twitter-gif/index.js

@@ -11,7 +11,7 @@ const readFile = promisify(fs.readFile)
 
 const url = 'https://twitter.com/Kikobeats/status/880139124791029763'
 
-it('twitter', async () => {
+it('twitter (tweet with gif)', async () => {
   const html = await readFile(resolve(__dirname, 'input.html'))
   const metadata = await getMetaData({html, url})
   snapshot(metadata)

test/web/twitter-image/index.js

@@ -11,7 +11,7 @@ const readFile = promisify(fs.readFile)
 
 const url = 'https://twitter.com/k4rliky/status/934482867480121345'
 
-it('twitter', async () => {
+it('twitter (tweet with image)', async () => {
   const html = await readFile(resolve(__dirname, 'input.html'))
   const metadata = await getMetaData({html, url})
   snapshot(metadata)