Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix video PlayButton styles #104

Merged
merged 1 commit into from
May 4, 2018
Merged

Fix video PlayButton styles #104

merged 1 commit into from
May 4, 2018

Conversation

breadadams
Copy link
Member

Closes #102

@Kikobeats
Copy link
Member

I don't understand why so style changes, it adds a lot of noise in the PR

I suppose the important part is here:
https://github.com/microlinkhq/sdk/pull/104/files#diff-216ce2c206559df42ce87fd0f9ec661eR23

My question is: why this change is necessary? in the storybook play button looks as expected 🤔

@breadadams
Copy link
Member Author

Crap, my prettier kicked in 🤦‍♂️. There are only 3 actual style changes @Kikobeats.

  1. left positioning on play button pseudo elements.
  2. top positioning on play button pseudo elements.
  3. backface-visibility on all parts of play button for antialiasing.

As for the reason why, I wish I could say... I haven't been able to fathom that yet.

I understand why it's breaking - because the lack of top/left positioning on the pseudo elements is make them default to a standard position. However I haven't yet worked out why it was working for us before on the Storybook 🤷‍♂️


Actually, after some zooming in on the Storybook, I'm seeing this:

image

So it wasn't perfect 🙂, it is now:

image

@Kikobeats Kikobeats merged commit ce616d2 into master May 4, 2018
@Kikobeats Kikobeats deleted the fix-play-button branch May 4, 2018 09:18
@Kikobeats
Copy link
Member

awesome 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants