Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for categorical "MicrometerSample" eventType to publish New Relic metrics. #1588

Conversation

neiljpowell
Copy link
Contributor

Previous behavior was to publish an eventType per Meter/metric name
(still supported via meterNameEventTypeEnabled=true). NewRelic's own
agents publish metrics to eventTypes aligned with broader categories. To
align with their recommendation the default behavior is to publish
metrics under a "MicrometerSample" category. When doing so, additional
context is provided by including "metricName" and "metricType"
attributes. Also "timeUnit" is now provided as an attribute for all
Timer related metrics regardless, so Insights users can better
understand time-based metrics.
See: https://docs.newrelic.com/docs/insights/insights-data-sources/default-data/insights-default-data-other-new-relic-products

@shakuzen
@breedx-nr

Previous behavior was to publish an eventType per Meter/metric name
(still supported via meterNameEventTypeEnabled=true). NewRelic's own
agents publish metrics to eventTypes aligned with broader categories. To
align with their recommendation the default behavior is to publish
metrics under a "MicrometerSample" category. When doing so, additional
context is provided by including "metricName" and "metricType"
attributes. Also "timeUnit" is now provided as an attribute for all
Timer related metrics regardless, so Insights users can better
understand time-based metrics.
See: https://docs.newrelic.com/docs/insights/insights-data-sources/default-data/insights-default-data-other-new-relic-products
@neiljpowell neiljpowell changed the title Add support for categorical "MicrometerSample" eventType to publish metrics. Add support for categorical "MicrometerSample" eventType to publish New Relic metrics. Sep 16, 2019
@checketts
Copy link
Contributor

It seems like you are still iterating on this PR. Please comment on it when you are ready for a review.

@neiljpowell
Copy link
Contributor Author

@checketts Hi. It's now ready for review. I had recently upgraded my IDE and forgot to adjust the tab/space indentation settings. Resulted in the extra iterations.

Copy link

@breedx-nr breedx-nr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a good change to me, with just a few small/opinionated suggestions. I think this is an interesting step in making the existing Insights/event based exporter more useful.

It should also be noted that New Relic recently published an open source registry that supports dimensional metrics instead of events: https://github.com/newrelic/micrometer-registry-newrelic

Copy link

@breedx-nr breedx-nr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the tweaks!

@shakuzen
Copy link
Member

It should also be noted that New Relic recently published an open source registry that supports dimensional metrics instead of events: https://github.com/newrelic/micrometer-registry-newrelic

@breedx-nr That's great. I didn't know about that. Would you be willing to update our docs to mention this new option? Docs source is at https://github.com/micrometer-metrics/micrometer-docs/

@shakuzen shakuzen added enhancement A general enhancement registry: new relic A New Relic Registry related issue release notes Noteworthy change to call out in the release notes labels Sep 27, 2019
@shakuzen shakuzen added this to the 1.3.0 milestone Sep 27, 2019
@neiljpowell
Copy link
Contributor Author

Ugh. io.micrometer.spring.autoconfigure.export.prometheus.PrometheusMetricsExportAutoConfigurationTest failures. @shakuzen my simple changes are failing to build due to unrelated errors. Thoughts?

@shakuzen shakuzen merged commit 56f275b into micrometer-metrics:master Sep 29, 2019
shakuzen added a commit that referenced this pull request Sep 29, 2019
@neiljpowell neiljpowell deleted the newrelic-MicrometerSample-eventType branch September 30, 2019 01:39
izeye added a commit to izeye/micrometer-docs that referenced this pull request Oct 14, 2019
@izeye
Copy link
Contributor

izeye commented Oct 14, 2019

It should also be noted that New Relic recently published an open source registry that supports dimensional metrics instead of events: https://github.com/newrelic/micrometer-registry-newrelic

@breedx-nr That's great. I didn't know about that. Would you be willing to update our docs to mention this new option? Docs source is at https://github.com/micrometer-metrics/micrometer-docs/

@shakuzen I created micrometer-metrics/micrometer-docs#102 to document it based on its README file.

shakuzen pushed a commit to neiljpowell/micrometer that referenced this pull request Oct 30, 2019
Updates for New Relic properties added in Micrometer v1.3.0 related to
micrometer-metrics#1588<micrometer-metrics#1588>
shakuzen pushed a commit that referenced this pull request Oct 30, 2019
Updates for New Relic properties added in Micrometer v1.3.0 related to
#1588
shakuzen pushed a commit to micrometer-metrics/micrometer-docs that referenced this pull request Dec 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement A general enhancement registry: new relic A New Relic Registry related issue release notes Noteworthy change to call out in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants