Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more media types #10846

Merged
merged 1 commit into from
May 24, 2024
Merged

Add more media types #10846

merged 1 commit into from
May 24, 2024

Conversation

altro3
Copy link
Contributor

@altro3 altro3 commented May 22, 2024 •
edited
Loading

Also order them by group

@graemerocher
Copy link
Contributor

Thanks @altro3 , can you update MediaTypeSpec with the new types?

@altro3 altro3 force-pushed the media-types branch 2 times, most recently from 5c4f8f7 to d3ec239 Compare May 22, 2024 09:50
@altro3 altro3 mentioned this pull request May 22, 2024
Merged
@graemerocher graemerocher added the type: improvement A minor improvement to an existing feature label May 22, 2024
sdelamo
sdelamo requested changes May 23, 2024
View reviewed changes
Copy link
Contributor

@sdelamo sdelamo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What new media types did you add? It is difficult to see since you mixed the reorder of the class in the same PR.

@altro3
Copy link
Contributor Author

altro3 commented May 23, 2024 •
edited
Loading

@sdelamo

application/yang
application/x-cue
application/toml
application/rtf
application/zlib
application/zstd

text/markdown
text/css
text/javascript
text/ecmascript

image/apng
image/bmp
image/x-icon
image/tiff
image/avif
image/svg+xml
image/xbm
image/wmf

@altro3 altro3 force-pushed the media-types branch 2 times, most recently from 841c736 to 43473b3 Compare May 23, 2024 10:55
@graemerocher graemerocher requested a review from sdelamo May 23, 2024 12:12
@graemerocher
Copy link
Contributor

@altro3 pls rebase

@altro3
Copy link
Contributor Author

altro3 commented May 24, 2024

@sdelamo done

@graemerocher graemerocher merged commit c2f6a95 into micronaut-projects:4.5.x May 24, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@graemerocher graemerocher graemerocher approved these changes

@sdelamo sdelamo Awaiting requested review from sdelamo

Assignees
No one assigned
Labels
type: improvement A minor improvement to an existing feature
Projects
No open projects
4.5.0 Release
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@altro3 @graemerocher @sdelamo