Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken images in docs #2914

Closed
sdelamo opened this issue Apr 25, 2024 · 3 comments · Fixed by #2925
Closed

Broken images in docs #2914

sdelamo opened this issue Apr 25, 2024 · 3 comments · Fixed by #2925
Assignees

Comments

@sdelamo
Copy link
Contributor

sdelamo commented Apr 25, 2024

@graemerocher

did something break with images and doc publishing? The image at https://micronaut-projects.github.io/micronaut-data/4.7.0/guide/#querying is broken

That file is gone from 4.7.x finderpattern.svg

@wetted please investigate when that file got removed.

it is in gh-pages branch

@wetted
Copy link
Contributor

wetted commented Apr 26, 2024

ping @sdelamo @graemerocher

This image hasn't been in any gh-pages branch /x.y.z publication since 1.0.x variants (1.0.0.M1, 1.0.0.M2, 1.0.0.M3, 1.0.0.TEST, 1.0.x).

Note, that it is in /latest and /snapshot which is why we were used to seeing it online, until we changed docs pages to stop using latest by default.

Screenshot 2024-04-26 at 11 44 50 AM

@sdelamo
Copy link
Contributor Author

sdelamo commented Apr 26, 2024

ping @sdelamo @graemerocher

This image hasn't been in any gh-pages branch /x.y.z publication since 1.0.x variants (1.0.0.M1, 1.0.0.M2, 1.0.0.M3, 1.0.0.TEST, 1.0.x).

Note, that it is in /latest and /snapshot which is why we were used to seeing it online, until we changed docs pages to stop using latest by default.

Please, fix it so that it shows. Add it back to the docs.

@wetted
Copy link
Contributor

wetted commented Apr 26, 2024

Please, fix it so that it shows. Add it back to the docs.

OK, I'll check all images (if there are more). I'll work on this next week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants