Issue-327 Number of consumers should be configurable #399
Conversation
| @@ -15,7 +15,7 @@ class ProductListener { | |||
|
|
|||
| CopyOnWriteArraySet<String> threads = new CopyOnWriteArraySet<>() | |||
|
|
|||
| @Queue(value = "product", numberOfConsumers = 5) // <1> | |||
| @Queue(value = "product", numberOfConcurrentConsumers = "5") // <1> | |||
There was a problem hiding this comment.
what is the motivation for changing the member name?
There was a problem hiding this comment.
I was not 100% sure if that is the proper approach, but I added a new member(numberOfConcurrentConsumers) and deprecated the old one(numberOfConsumers) to avoid breaking the backward compatibility contract. The new member is of type String versus int to allow for config property placeholders.
There was a problem hiding this comment.
Perhaps don't deprecate it for type safety a number is still handy. Name it numberOfConsumersValue and this provides the option to use either. You can add @AliasFor("numberOfConsumers") to the new member and then just read it "numberOfConsumers" here (you don't have to check for both) https://github.com/micronaut-projects/micronaut-rabbitmq/pull/399/files#diff-fce8edcc7a5dc02ecf4bf1520cf937dc82991c4fe4571bd3080118152de3c853R137
Assome, I wasn't aware of the @AliasFor option. |
|
Kudos, SonarCloud Quality Gate passed!
|
No description provided.