This repository has been archived by the owner on Sep 6, 2023. It is now read-only.
Add missing uhashlib back in #178 #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
HA! This was on my to-do for tomorrow. |
|
Looks good! The reason for the omission is because esp32 uses its own moduhashlib.c, rather than the core provided one, which would automatically add this uhashlib to the list of built-in modules. esp32 uses its own implementation because it uses mbedtls for the hashing. |
nickzoic
force-pushed
the
esp32-bugfix-178-missing-uhashlib
branch
from
b7c203c
to
5c48e19
Compare
|
I figured I'd take "Looks good!" as a positive review and merge it :-) |
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a one-liner to add uhashlib back into the modules.