os.path: refactor: use sep instead of literal / #730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Hirsch <michael@scivision.dev>
|
Thanks for the contribution. Can you please explain what prompted this change and why it's better this way? |
projectgus
requested changes
Oct 18, 2023
There was a problem hiding this comment.
Change LGTM apart from one small fix needed. However like @dpgeorge I'm curious what the motivation for making it was. (Windows, maybe?)
| return s | ||
|
|
||
|
|
||
| def join(*args): | ||
| # TODO: this is non-compliant | ||
| if type(args[0]) is bytes: | ||
| return b"/".join(args) | ||
| return bytes(sep).join(args) |
There was a problem hiding this comment.
This line will raise an exception:
MicroPython v1.20.0-330-g076bfc7ed8-dirty on 2023-09-26; linux [GCC 13.2.1] version
Use Ctrl-D to exit, Ctrl-E for paste mode
>>> bytes("/")
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
TypeError: string argument without an encoding
>>> "/".encode()
b'/'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.