Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UpdateVersionNumber in CreateRelease fails if appFolders contain wild characters #889

Closed
mazhelez opened this issue Jan 24, 2024 · 0 comments · Fixed by #910
Closed

UpdateVersionNumber in CreateRelease fails if appFolders contain wild characters #889

mazhelez opened this issue Jan 24, 2024 · 0 comments · Fixed by #910
Assignees

Comments

@mazhelez
Copy link
Collaborator

See: https://github.com/mazhelez/BCApps/actions/runs/7583563656/job/20656003973#logs

Reading settings from build\projects\System Application Modules\.AL-Go\settings.json
projectName       : System Application Modules
appFolders        : {..\..\..\src\System Application\App\*}
testFolders       : {..\..\..\src\System Application\Test\*, ..\..\..\src\System Application\Test Library\*}
useCompilerFolder : True
doNotPublishApps  : True
rulesetFile       : ..\..\..\src\rulesets\internal.module.ruleset.json
repoVersion       : 25.0

{
  "projectName": "System Application Modules",
  "appFolders": [
    "..\\..\\..\\src\\System Application\\App\\*"
  ],
  "testFolders": [
    "..\\..\\..\\src\\System Application\\Test\\*",
    "..\\..\\..\\src\\System Application\\Test Library\\*"
  ],
  "useCompilerFolder": true,
  "doNotPublishApps": true,
  "rulesetFile": "..\\..\\..\\src\\rulesets\\internal.module.ruleset.json",
  "repoVersion": "25.0"
}
Modifying app.json in folder build\projects\System Application Modules\..\..\..\src\System Application\App\*
AL-Go action ran: IncrementVersionNumber Telemetry Correlation Id: a1a1d53d-420a-444a-96c5-5f0621c2293d
Error: Unexpected error when running action. Error Message: Application manifest file(build\projects\System Application Modules\..\..\..\src\System Application\App\*\app.json) is malformed., StackTrace: at <ScriptBlock>, D:\a\_actions\mazhelez\AL-Go\fix-hardcoded-release\Actions\IncrementVersionNumber\IncrementVersionNumber.ps1: line 96 <- at <ScriptBlock>, D:\a\_actions\mazhelez\AL-Go\fix-hardcoded-release\Actions\IncrementVersionNumber\IncrementVersionNumber.ps1: line 76 <- at <ScriptBlock>, D:\a\_temp\08513[331](https://github.com/mazhelez/BCApps/actions/runs/7583563656/job/20656003973#step:4:333)-d23d-4506-864d-d6be71137b10.ps1: line 4 <- at <ScriptBlock>, <No file>: line 1
@mazhelez mazhelez self-assigned this Jan 24, 2024
mazhelez added a commit that referenced this issue Feb 12, 2024
Fixes #889 : `appFolders` with wild characters are not resolved when
reading the app.json files.
Also fixes issue that the `version` property in `dependencies` array in
the app.json is not changed.

- [x] Release notes
- [x] More tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant