Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{Freeway-Bug}[AdaptiveCards- Designer - Host app docs]: Screen Reader does convey the incorrect role as button for the 'Host App Docs' link. #8167

Closed
vagpt opened this issue Dec 20, 2022 · 3 comments · Fixed by #8269
Labels
A11ySev2 Accessibility issue with severity 2. This may impact the accessibility score A11yTTValidated A11yWCAG Accessibility issue that affects compliance Area-Accessibility Bugs around feature accessibility Area-Renderers Bug HCL-AdaptiveCards-Web Used by accessibility team for scorecard categorization HCL-E+D

Comments

@vagpt
Copy link
Collaborator

vagpt commented Dec 20, 2022

Target Platforms

Other

SDK Version

1.5

Application Name

Adaptive Cards

Problem Description

Test Environment:
URL: https://adaptivecards.io/
OS Version: 22H2(OS Build 25247.1000)
Browser Version: Version 110.0.1543.0 (Official build) dev (64-bit)
Screen Reader: Narrator

Repro Steps:

  1. Open above URL with valid credential.
  2. Navigate to 'Designer' link and press enter key to activate it.
  3. Navigate to 'Host App docs' link and press enter key and observe the issue.

Actual Result:
Screen Reader does convey the incorrect role for the 'Host App Docs' as a button as on activating it new tab is getting opened.

Expected Result:
Screen Reader should not convey the incorrect role for the 'Host App Docs' button. It should announce as 'Host app docs' link.

Note:

  1. Same issue is repro for the 'Templating Docs' and 'Provide feedback about the designer' button.
  2. Same issue is observed under target version 1.5.

User Experience:
It will impact the screen reader user if the screen reader does convey the incorrect role for the any element on the screen.

MAS Reference:
(https://microsoft.sharepoint.com/:w:/r/sites/accessibility/_layouts/15/Doc.aspx?sourcedoc=%7B507B5D90-F1B9-4AE1-91D1-2F1F2D6C7C1D%7D&file=MAS%204.1.2%20%E2%80%93%20Name%2C%20Role%2C%20Value.docx&action=default&mobileredirect=true)

"Have feedback to share on Bugs ? Please help fill Trusted Tester Bug Feedback (office.com) “.

Screenshots

MAS4 1 2-Incorrect role as button is defined for the host app docs

MAS4.1.2-Incorrect.role.as.button.is.defined.mp4

Card JSON

NA

Sample Code Language

No response

Sample Code

No response

@vagpt vagpt added Bug Area-Renderers Area-Accessibility Bugs around feature accessibility A11ySev2 Accessibility issue with severity 2. This may impact the accessibility score A11yWCAG Accessibility issue that affects compliance HCL-E+D HCL-AdaptiveCards-Web Used by accessibility team for scorecard categorization labels Dec 20, 2022
@vagpt vagpt changed the title [AdaptiveCards- Designer - Host app docs]: Screen Reader does convey the incorrect role as button for the 'Host App Docs' link. {Freeway-Bug}[AdaptiveCards- Designer - Host app docs]: Screen Reader does convey the incorrect role as button for the 'Host App Docs' link. Jan 13, 2023
@vagpt
Copy link
Collaborator Author

vagpt commented Mar 14, 2023

This issue is still repro on the environment below, hence activating this issue.

Test Environment:
URL: https://adaptivecards.io/designer/
OS Version: 22H2(OS Build 25300.1000)
Browser Version: Version 11!.0.1661.27 (Official build) dev (64-bit)
Screen Reader: Narrator

Issue.is.still.repro.mp4

@anna-dingler
Copy link
Contributor

Hi @vagpt,

We have updated our official site, and this bug should be fixed in your test environment now. If the issue persists, try clearing your browser cache.

Thank you!

@vagpt
Copy link
Collaborator Author

vagpt commented Apr 27, 2023

This issue is working fine on the environment below, hence closing this issue.

Test Environment:
URL: https://adaptivecards.io/designer/
OS Version: 22H2(OS Build 25330.1000)
Browser Version: 114.0.1807.1
Screen Reader: Narrator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A11ySev2 Accessibility issue with severity 2. This may impact the accessibility score A11yTTValidated A11yWCAG Accessibility issue that affects compliance Area-Accessibility Bugs around feature accessibility Area-Renderers Bug HCL-AdaptiveCards-Web Used by accessibility team for scorecard categorization HCL-E+D
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants