Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle all successful status codes #268

Merged
merged 1 commit into from Sep 30, 2015
Merged

Handle all successful status codes #268

merged 1 commit into from Sep 30, 2015

Conversation

symm
Copy link
Contributor

@symm symm commented Sep 9, 2015

I have an API which a returns 201 successful status code when an entity is created. Insights is currently incorrectly logging these requests as unsuccessful:

unsuccessful request

@msftclas
Copy link

msftclas commented Sep 9, 2015

Hi @symm, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla.microsoft.com.

TTYL, MSBOT;

@msftclas
Copy link

msftclas commented Sep 9, 2015

@symm, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.

Thanks, MSBOT;

amnonshmsft added a commit that referenced this pull request Sep 30, 2015
Handle all successful status codes
@amnonshmsft amnonshmsft merged commit c6be730 into microsoft:master Sep 30, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants