This repository has been archived by the owner on Oct 12, 2022. It is now read-only.
Add checks for Wcf client operation context #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 9, 2016 10:40
Implement checks to avoid creating a WcfOperationContext over a client-side OperationContext object. Store WcfOperationContext on the thread's CallContext as a backup.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the
WcfOperationContextmore robust with explicit checks to prevent creating a context on a WCF client-sideOperationContextinstance.Also add a workaround for issue #45.
The fundamental issue here is that the WCF design around
OperationContextis broken: You can stack contexts through the use ofOperationContext.Current, but there is no way to navigate from the child context back to the parent.The workaround uses
CallContextto track the originalOperationContextif the service code fails to dispose theOperationContextScopeand we end up withOperationContext.Currentreturning the wrong value.Not sure if using
ThreadLocal<T>coupled with anAsyncLocal<T>here would be better than usingCallContextin this case. Reluctant to have to mirror the jumps that WCFOperationContext.Currentdoes.