Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Porter version in Dockerfile & add missing ARG #99

Merged
merged 1 commit into from
Feb 19, 2024
Merged

Upgrade Porter version in Dockerfile & add missing ARG #99

merged 1 commit into from
Feb 19, 2024

Conversation

jonnyry
Copy link
Contributor

@jonnyry jonnyry commented Feb 19, 2024

Resolves #98

What is being addressed

  • Upgrade Dockerfile Porter version to align with microsoft/AzureTRE repo
  • Fix missing ARG OSS_REPO variable in Dockerfile, it does works without it being declared, however should be explictly declared like ARG OSS_VERSION

marrobi
marrobi approved these changes Feb 19, 2024
View reviewed changes
Copy link
Member

@marrobi marrobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thanks.

@marrobi marrobi enabled auto-merge (squash) February 19, 2024 10:52
@marrobi marrobi merged commit 8bf8fca into microsoft:main Feb 19, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marrobi marrobi marrobi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dockerfile Porter version
2 participants
@jonnyry @marrobi