Support humble #257
Support humble #257
Conversation
src/k4a_ros_device.cpp
Outdated
| // this->declare_parameter({depth_raw_topic + compressed_format}); | ||
| // this->declare_parameter({depth_raw_topic + compressed_png_level}); | ||
| // this->declare_parameter({depth_rect_topic + compressed_format}); | ||
| // this->declare_parameter({depth_rect_topic + compressed_png_level}); |
There was a problem hiding this comment.
I'm not really sure here, these were parameters with their name being the topic name itself? What is the use here? Where are these used?
There was a problem hiding this comment.
Honestly, not sure either. I think this was done as an alternative to topic remapping, but likely should be removed.
src/k4a_ros_device.cpp
Outdated
| // this->declare_parameter({depth_raw_topic + compressed_format}); | ||
| // this->declare_parameter({depth_raw_topic + compressed_png_level}); | ||
| // this->declare_parameter({depth_rect_topic + compressed_format}); | ||
| // this->declare_parameter({depth_rect_topic + compressed_png_level}); |
There was a problem hiding this comment.
Honestly, not sure either. I think this was done as an alternative to topic remapping, but likely should be removed.
thought so too, I'll remove then |
|
Don't worry about CI - I'll have to switch it to humble when the Humble Windows release is completed. |
@microsoft-github-policy-service agree company="Pixel Robotics" |
|
Hi, Do you get the error following when execute the launch? $ ros2 launch azure_kinect_ros_driver driver.launch.py
[INFO] [launch]: All log files can be found below /root/.ros/log/2022-11-03-07-52-45-234984-jun-15580
[INFO] [launch]: Default logging verbosity is set to INFO
Robot description xacro_file : /root/ws_moveit/install/azure_kinect_ros_driver/share/azure_kinect_ros_driver/urdf/azure_kinect.urdf.xacro
Robot description urdf_path : /root/ws_moveit/install/azure_kinect_ros_driver/share/azure_kinect_ros_driver/urdf/azure_kinect.urdf
[ERROR] [launch]: Caught exception in launch (see debug for traceback): package 'azure_kinect_ros_driver' found at '/root/ws_moveit/install/azure_kinect_ros_driver', but libexec directory '/root/ws_moveit/install/azure_kinect_ros_driver/lib/azure_kinect_ros_driver' does not existFinally, it can be executed after revised CMakeLists.txt install(TARGETS ${PROJECT_NAME}_node
RUNTIME DESTINATION lib/${PROJECT_NAME}/
) |
|
Thanks for the feedback, I haven't tried launching it yet actually as I didn't have a camera. I'll try it out and update you, at the latest next week. |
|
@st99315 I can't seem to reproduce your bug. Did you make sure to source setup.bash after building? |
|
@ooeygui FYI I am still adding changes to this PR as I am testing |
|
I'm done here 👍 |
|
Any estimate on when this can be merged? Are we talking days or weeks? |
|
Running CI; although it seems to be targeting Foxy. |
|
Pulled to bootstrap the humble builds. Thank you for your contribution! |
Fixes
#256
Description of the changes:
fatal error: angles/angles.h: No such file or directoryRequired before submitting a Pull Request:
I tested changes on: