[OAuth] Reintroduce OAuthControlAddin for OnPrem support #621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darjoo
approved these changes
Feb 23, 2024
grobyns
approved these changes
Feb 23, 2024
stkillen
added a commit
that referenced
this pull request
Feb 26, 2024
<!-- Thank you for submitting a Pull Request. If you're new to contributing to BCApps please read our pull request guideline below * https://github.com/microsoft/BCApps/Contributing.md --> #### Summary <!-- Provide a general summary of your changes --> OAuthControlAddin was obsoleted in previous PR in favor of OAuthIntegration. Both should exist, as OAuthIntegration is used to create an authorization link and needs a min height and width to do that. The OAuthControlAddin has no height and width. #### Work Item(s) <!-- Add the issue number here after the #. The issue needs to be open and approved. Submitting PRs with no linked issues or unapproved issues is highly discouraged. --> Fixes [AB#502131](https://dynamicssmb2.visualstudio.com/Dynamics%20SMB/_workitems/edit/502131/)
stkillen
added a commit
that referenced
this pull request
Feb 26, 2024
<!-- Thank you for submitting a Pull Request. If you're new to contributing to BCApps please read our pull request guideline below * https://github.com/microsoft/BCApps/Contributing.md --> #### Summary <!-- Provide a general summary of your changes --> OAuthControlAddin was obsoleted in previous PR in favor of OAuthIntegration. Both should exist, as OAuthIntegration is used to create an authorization link and needs a min height and width to do that. The OAuthControlAddin has no height and width. #### Work Item(s) <!-- Add the issue number here after the #. The issue needs to be open and approved. Submitting PRs with no linked issues or unapproved issues is highly discouraged. --> Fixes [AB#502131](https://dynamicssmb2.visualstudio.com/Dynamics%20SMB/_workitems/edit/502131/)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
OAuthControlAddin was obsoleted in previous PR in favor of OAuthIntegration.
Both should exist, as OAuthIntegration is used to create an authorization link and needs a min height and width to do that. The OAuthControlAddin has no height and width.
Work Item(s)
Fixes AB#502131