Codeowners updates #667
Merged
Codeowners updates #667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darjoo
previously approved these changes
Feb 29, 2024
JesperSchulz
previously approved these changes
Mar 1, 2024
aholstrup1
changed the title
mazhelez
approved these changes
Mar 4, 2024
ankosiorek
approved these changes
Mar 4, 2024
aholstrup1
added a commit
that referenced
this pull request
Mar 4, 2024
<!-- Thank you for submitting a Pull Request. If you're new to contributing to BCApps please read our pull request guideline below * https://github.com/microsoft/BCApps/Contributing.md --> #### Summary <!-- Provide a general summary of your changes --> * Reorder codeowners such that e.g. a change to the permissionset in the AI module will trigger a review from the permission set reviewers * Added rules for handling case sensitivity of codeowners file and the fact that AL files can be inconsistently named #### Work Item(s) <!-- Add the issue number here after the #. The issue needs to be open and approved. Submitting PRs with no linked issues or unapproved issues is highly discouraged. --> Fixes [AB#502986](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/502986)
aholstrup1
added a commit
that referenced
this pull request
Mar 4, 2024
<!-- Thank you for submitting a Pull Request. If you're new to contributing to BCApps please read our pull request guideline below * https://github.com/microsoft/BCApps/Contributing.md --> #### Summary <!-- Provide a general summary of your changes --> * Reorder codeowners such that e.g. a change to the permissionset in the AI module will trigger a review from the permission set reviewers * Added rules for handling case sensitivity of codeowners file and the fact that AL files can be inconsistently named #### Work Item(s) <!-- Add the issue number here after the #. The issue needs to be open and approved. Submitting PRs with no linked issues or unapproved issues is highly discouraged. --> Fixes [AB#502986](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/502986)
aholstrup1
added a commit
that referenced
this pull request
Mar 4, 2024
<!-- Thank you for submitting a Pull Request. If you're new to contributing to BCApps please read our pull request guideline below * https://github.com/microsoft/BCApps/Contributing.md --> #### Summary <!-- Provide a general summary of your changes --> * Reorder codeowners such that e.g. a change to the permissionset in the AI module will trigger a review from the permission set reviewers * Added rules for handling case sensitivity of codeowners file and the fact that AL files can be inconsistently named #### Work Item(s) <!-- Add the issue number here after the #. The issue needs to be open and approved. Submitting PRs with no linked issues or unapproved issues is highly discouraged. --> Fixes [AB#502986](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/502986)
aholstrup1
added a commit
that referenced
this pull request
Mar 4, 2024
This pull request backports #667 to releases/24.x Fixes [AB#502986](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/502986)
aholstrup1
added a commit
that referenced
this pull request
Mar 4, 2024
This pull request backports #667 to releases/24.0 Fixes [AB#502986](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/502986)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Work Item(s)
Fixes AB#502986