Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sharepoint SetXHttpMethod should set data to global variable. Cleanup #911

Merged

Conversation

Drakonian
Copy link
Contributor

@Drakonian Drakonian commented Apr 10, 2024

Summary

Sharepoint SetXHttpMethod should set data to global variable. Cleanup

Work Item(s)

Fixes #666

Fixes AB#532990

@Drakonian Drakonian requested a review from a team as a code owner April 10, 2024 08:45
@github-actions github-actions bot added AL: System Application From Fork Pull request is coming from a fork labels Apr 10, 2024
@JesperSchulz
Copy link
Contributor

Looks like you've got an unused variable. Let's make CI pass before we involve developers in the review 🙂

@Drakonian
Copy link
Contributor Author

Drakonian commented Apr 16, 2024

Looks like you've got an unused variable. Let's make CI pass before we involve developers in the review 🙂

How I can do that? I thought CI process starts only after assigning an internal ticket number

@Drakonian
Copy link
Contributor Author

Drakonian commented Apr 16, 2024

@JesperSchulz
I mean, can I run/trigger CI myself to make sure everything is ready? :)

@Drakonian
Copy link
Contributor Author

Fixed

@JesperSchulz
Copy link
Contributor

Looks like you've got an unused variable. Let's make CI pass before we involve developers in the review 🙂

How I can do that? I thought CI process starts only after assigning an internal ticket number

I can kick off the CI process any time. Will do so again to see if it passes now 🙂

@Drakonian
Copy link
Contributor Author

Looks like you've got an unused variable. Let's make CI pass before we involve developers in the review 🙂

How I can do that? I thought CI process starts only after assigning an internal ticket number

I can kick off the CI process any time. Will do so again to see if it passes now 🙂

I would of course like to run CI at least locally before send code -)

This error looks like an internal

image

@JesperSchulz JesperSchulz added the Integration GitHub request for Integration area label Apr 22, 2024
@JesperSchulz
Copy link
Contributor

Let's try this once more, before I bring in the cavalry...

@JesperSchulz JesperSchulz added the Linked Issue is linked to a Azure Boards work item label Apr 30, 2024
@github-actions github-actions bot added this to the Version 25.0 milestone Apr 30, 2024
@JesperSchulz
Copy link
Contributor

@Drakonian, now there actually seem to be real compilation issues (e.g. AL0126 No overload for method 'UpdateListItemMetaDataField' takes 4 arguments.). Could you take another look?

@Drakonian
Copy link
Contributor Author

@JesperSchulz fixed

@JesperSchulz
Copy link
Contributor

All CI checks have passed. Now we'll review 🚀

@JesperSchulz JesperSchulz enabled auto-merge (squash) May 6, 2024 10:55
@JesperSchulz JesperSchulz merged commit 2704be1 into microsoft:main May 6, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AL: System Application From Fork Pull request is coming from a fork Integration GitHub request for Integration area Linked Issue is linked to a Azure Boards work item
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: GetXHttpMethod returns no value in 9107 "SharePoint Http Content"
3 participants