-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sharepoint SetXHttpMethod should set data to global variable. Cleanup #911
Sharepoint SetXHttpMethod should set data to global variable. Cleanup #911
Conversation
Looks like you've got an unused variable. Let's make CI pass before we involve developers in the review 🙂 |
How I can do that? I thought CI process starts only after assigning an internal ticket number |
@JesperSchulz |
Fixed |
I can kick off the CI process any time. Will do so again to see if it passes now 🙂 |
I would of course like to run CI at least locally before send code -) This error looks like an internal |
Let's try this once more, before I bring in the cavalry... |
@Drakonian, now there actually seem to be real compilation issues (e.g. AL0126 No overload for method 'UpdateListItemMetaDataField' takes 4 arguments.). Could you take another look? |
@JesperSchulz fixed |
All CI checks have passed. Now we'll review 🚀 |
Summary
Sharepoint SetXHttpMethod should set data to global variable. Cleanup
Work Item(s)
Fixes #666
Fixes AB#532990