Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[main] [bug] Change default encoding type to MsDos #920

Merged
merged 2 commits into from
May 1, 2024

Conversation

gggdttt
Copy link
Contributor

@gggdttt gggdttt commented Apr 11, 2024

Summary

To keep consistent with all the existing behavior, the default encoding type should be set to MsDos.

Work Item(s)

AB#484133

Copy link

Issue #507906 is not valid. Please make sure you link an issue that exists, is open and is approved.

@github-actions github-actions bot added this to the Version 25.0 milestone Apr 11, 2024
…te/wenjiefan/bug-set-default-encoding-type
@gggdttt gggdttt force-pushed the private/wenjiefan/bug-set-default-encoding-type branch from 1cfc914 to ec3eba1 Compare April 30, 2024 09:15
@gggdttt gggdttt requested a review from JesperSchulz May 1, 2024 10:06
@JesperSchulz JesperSchulz merged commit 50fe5c2 into main May 1, 2024
35 of 45 checks passed
@JesperSchulz JesperSchulz deleted the private/wenjiefan/bug-set-default-encoding-type branch May 1, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants