Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Some editting bugs in Lu editor #2285

Merged
merged 4 commits into from
Mar 17, 2020
Merged

fix: Some editting bugs in Lu editor #2285

merged 4 commits into from
Mar 17, 2020

Conversation

cosmicshuai
Copy link
Contributor

@cosmicshuai cosmicshuai commented Mar 17, 2020 •
edited
Loading

fixes #2141

  1. Incorrect syntax highlight for entity definition. For example:
    image

  2. Wrong place of inserting '-' in auto-completion of utterance
    docFormat

  3. trigger error of lebeling experience
    labeling

@github-actions
Copy link

Coverage Status

Coverage remained the same at 40.962% when pulling 19f264a on shuwan/fixLuLSPbugs into 7e53610 on master.

@zhixzhan
Copy link
Contributor

Can you record a gif or screenshot? that would be very nice.

@cosmicshuai
Copy link
Contributor Author

Can you record a gif or screenshot? that would be very nice.

Sure. You can see the gif now.

@a-b-r-o-w-n a-b-r-o-w-n merged commit abb576e into master Mar 17, 2020
@a-b-r-o-w-n a-b-r-o-w-n deleted the shuwan/fixLuLSPbugs branch March 17, 2020 17:04
@a-b-r-o-w-n a-b-r-o-w-n mentioned this pull request Mar 18, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a-b-r-o-w-n a-b-r-o-w-n a-b-r-o-w-n approved these changes

@boydc2014 boydc2014 Awaiting requested review from boydc2014 boydc2014 is a code owner

@cwhitten cwhitten Awaiting requested review from cwhitten cwhitten is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cosmicshuai @zhixzhan @a-b-r-o-w-n