feat: new validation pipeline - schema existence validation #6645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yeze322
requested review from
a-b-r-o-w-n,
beyackle,
boydc2014,
cwhitten,
GeoffCoxMSFT,
hatpick,
srinaath and
tonyanziano
as code owners
cwhitten
approved these changes
Apr 13, 2021
yeze322
commented
Apr 14, 2021
| const entries = Object.entries(schema.properties); | ||
| for (const entry of entries) { | ||
| const [propertyName, propertyDef] = entry; | ||
| const { type, items } = propertyDef as any; |
There was a problem hiding this comment.
here causes the bug
There was a problem hiding this comment.
needs to check the schema definition
8 tasks
cwhitten
added a commit
that referenced
this pull request
Apr 14, 2021
Merged
lei9444
pushed a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
…t#6645) * add placeholder for schema validator * add schema validator pipeline with mocked fn * add schema visitor * display diagnostics data in debug panel * revert sdk.ts * decrease schema diagnostic severity to 'Warning' * optmize path join logic * impl a unified walker covers SwitchCondition * fix lint error: use BaseSchema * feat: disable actions without schema * wrap in useEffect * optimization: avoid frequent recoil submission * optimization: aggregate paths rather than updatedDialog to reduce time complexity * chore: comments & var name * lint * add comments Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
lei9444
pushed a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
…icrosoft#6645)" (microsoft#6943) This reverts commit 9aa7733.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When a $kind is not defined in sdk.schema, raise a diagnostic error in debug panel and disable this Action.
Task Item
closes #5996
refs #6526
Screenshots