fix: Show CustomRecognizer for non-PVA bots #7634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taicchoumsft
requested review from
a-b-r-o-w-n,
benbrown,
beyackle,
boydc2014,
cwhitten,
GeoffCoxMSFT,
hatpick,
pavolum,
srinaath,
tdurnford and
tonyanziano
as code owners
taicchoumsft
changed the title
taicchoumsft
changed the title
cwhitten
approved these changes
May 5, 2021
alanlong9278
added a commit
that referenced
this pull request
May 6, 2021
* main: (22 commits) feat: detect "old" bots and migrate them to new runtime (#6526) feat: show tunneling information notification when starting bot with remote skills (#7611) fix: Added cleanup logic to app on quit (#7645) fix: Update provision & publishing copy (#7583) (#7642) fix: rephrase Enable Orchestrator dialog (#7639) fix: update left nav and top bar strings (#7609) chore: bump wait-on to v5.3.0 (#7648) special case the fallback recognizer (#7634) fix: fit and finish across the app (#7598) fix: rephrase Open from ABS dialog (#7637) fix: LG Editor Fit & Finish (#7636) fix: ui copy updates (#7599) fix: fixes auth flow on web & electron version (#7623) fix: Adjust build command used for dotnet functions (#7557) Update provisionScript.zip with small syntax changes (#7563) fix: change copy on home page (#7604) fix: get tenant specific arm tokens for connections (#7554) fix: address a regression in the start bot button that caused final 'get started' bubb not to pop (#7567) fix: Update attachment template format to support PVA (#7593) Revert "fix: Update attachment template format to support PVA (#7564)" (#7592) ...
alanlong9278
added a commit
that referenced
this pull request
May 11, 2021
* main: (46 commits) Hides the PVA publish profile from the profle creation dropdown (#7725) fix: converting bot with custom actions (ui update) (#7672) fix: generate manifest file when creating new publish target (#7666) Feed string, not int, to Switch per schema (#7707) fix: (Un) Installing a package now stops the currently running bot beforehand (#7689) Add components field to migrated settings. Guard against missing field during component merge (#7674) exclude items from the package manager list that do not have names or versions -- such as locally implemented custom actions (#7683) chore: Rebase main with 1.4.1 release (#7678) fix: restore line beneath page header (#7676) remove appsettings file from default gitignore (#7679) fix: data race writing on setting file (#7475) feat: detect "old" bots and migrate them to new runtime (#6526) feat: show tunneling information notification when starting bot with remote skills (#7611) fix: Added cleanup logic to app on quit (#7645) fix: Update provision & publishing copy (#7583) (#7642) fix: rephrase Enable Orchestrator dialog (#7639) fix: update left nav and top bar strings (#7609) chore: bump wait-on to v5.3.0 (#7648) special case the fallback recognizer (#7634) fix: fit and finish across the app (#7598) ...
alanlong9278
added a commit
that referenced
this pull request
May 11, 2021
* main: (46 commits) Hides the PVA publish profile from the profle creation dropdown (#7725) fix: converting bot with custom actions (ui update) (#7672) fix: generate manifest file when creating new publish target (#7666) Feed string, not int, to Switch per schema (#7707) fix: (Un) Installing a package now stops the currently running bot beforehand (#7689) Add components field to migrated settings. Guard against missing field during component merge (#7674) exclude items from the package manager list that do not have names or versions -- such as locally implemented custom actions (#7683) chore: Rebase main with 1.4.1 release (#7678) fix: restore line beneath page header (#7676) remove appsettings file from default gitignore (#7679) fix: data race writing on setting file (#7475) feat: detect "old" bots and migrate them to new runtime (#6526) feat: show tunneling information notification when starting bot with remote skills (#7611) fix: Added cleanup logic to app on quit (#7645) fix: Update provision & publishing copy (#7583) (#7642) fix: rephrase Enable Orchestrator dialog (#7639) fix: update left nav and top bar strings (#7609) chore: bump wait-on to v5.3.0 (#7648) special case the fallback recognizer (#7634) fix: fit and finish across the app (#7598) ...
Merged
benbrown
pushed a commit
to benbrown/BotFramework-Composer
that referenced
this pull request
May 24, 2021
* main: (46 commits) Hides the PVA publish profile from the profle creation dropdown (microsoft#7725) fix: converting bot with custom actions (ui update) (microsoft#7672) fix: generate manifest file when creating new publish target (microsoft#7666) Feed string, not int, to Switch per schema (microsoft#7707) fix: (Un) Installing a package now stops the currently running bot beforehand (microsoft#7689) Add components field to migrated settings. Guard against missing field during component merge (microsoft#7674) exclude items from the package manager list that do not have names or versions -- such as locally implemented custom actions (microsoft#7683) chore: Rebase main with 1.4.1 release (microsoft#7678) fix: restore line beneath page header (microsoft#7676) remove appsettings file from default gitignore (microsoft#7679) fix: data race writing on setting file (microsoft#7475) feat: detect "old" bots and migrate them to new runtime (microsoft#6526) feat: show tunneling information notification when starting bot with remote skills (microsoft#7611) fix: Added cleanup logic to app on quit (microsoft#7645) fix: Update provision & publishing copy (microsoft#7583) (microsoft#7642) fix: rephrase Enable Orchestrator dialog (microsoft#7639) fix: update left nav and top bar strings (microsoft#7609) chore: bump wait-on to v5.3.0 (microsoft#7648) special case the fallback recognizer (microsoft#7634) fix: fit and finish across the app (microsoft#7598) ...
benbrown
pushed a commit
to benbrown/BotFramework-Composer
that referenced
this pull request
May 24, 2021
* main: (46 commits) Hides the PVA publish profile from the profle creation dropdown (microsoft#7725) fix: converting bot with custom actions (ui update) (microsoft#7672) fix: generate manifest file when creating new publish target (microsoft#7666) Feed string, not int, to Switch per schema (microsoft#7707) fix: (Un) Installing a package now stops the currently running bot beforehand (microsoft#7689) Add components field to migrated settings. Guard against missing field during component merge (microsoft#7674) exclude items from the package manager list that do not have names or versions -- such as locally implemented custom actions (microsoft#7683) chore: Rebase main with 1.4.1 release (microsoft#7678) fix: restore line beneath page header (microsoft#7676) remove appsettings file from default gitignore (microsoft#7679) fix: data race writing on setting file (microsoft#7475) feat: detect "old" bots and migrate them to new runtime (microsoft#6526) feat: show tunneling information notification when starting bot with remote skills (microsoft#7611) fix: Added cleanup logic to app on quit (microsoft#7645) fix: Update provision & publishing copy (microsoft#7583) (microsoft#7642) fix: rephrase Enable Orchestrator dialog (microsoft#7639) fix: update left nav and top bar strings (microsoft#7609) chore: bump wait-on to v5.3.0 (microsoft#7648) special case the fallback recognizer (microsoft#7634) fix: fit and finish across the app (microsoft#7598) ...
benbrown
pushed a commit
that referenced
this pull request
Jun 11, 2021
benbrown
pushed a commit
that referenced
this pull request
Jun 11, 2021
* main: (46 commits) Hides the PVA publish profile from the profle creation dropdown (#7725) fix: converting bot with custom actions (ui update) (#7672) fix: generate manifest file when creating new publish target (#7666) Feed string, not int, to Switch per schema (#7707) fix: (Un) Installing a package now stops the currently running bot beforehand (#7689) Add components field to migrated settings. Guard against missing field during component merge (#7674) exclude items from the package manager list that do not have names or versions -- such as locally implemented custom actions (#7683) chore: Rebase main with 1.4.1 release (#7678) fix: restore line beneath page header (#7676) remove appsettings file from default gitignore (#7679) fix: data race writing on setting file (#7475) feat: detect "old" bots and migrate them to new runtime (#6526) feat: show tunneling information notification when starting bot with remote skills (#7611) fix: Added cleanup logic to app on quit (#7645) fix: Update provision & publishing copy (#7583) (#7642) fix: rephrase Enable Orchestrator dialog (#7639) fix: update left nav and top bar strings (#7609) chore: bump wait-on to v5.3.0 (#7648) special case the fallback recognizer (#7634) fix: fit and finish across the app (#7598) ...
benbrown
pushed a commit
that referenced
this pull request
Jun 11, 2021
* main: (46 commits) Hides the PVA publish profile from the profle creation dropdown (#7725) fix: converting bot with custom actions (ui update) (#7672) fix: generate manifest file when creating new publish target (#7666) Feed string, not int, to Switch per schema (#7707) fix: (Un) Installing a package now stops the currently running bot beforehand (#7689) Add components field to migrated settings. Guard against missing field during component merge (#7674) exclude items from the package manager list that do not have names or versions -- such as locally implemented custom actions (#7683) chore: Rebase main with 1.4.1 release (#7678) fix: restore line beneath page header (#7676) remove appsettings file from default gitignore (#7679) fix: data race writing on setting file (#7475) feat: detect "old" bots and migrate them to new runtime (#6526) feat: show tunneling information notification when starting bot with remote skills (#7611) fix: Added cleanup logic to app on quit (#7645) fix: Update provision & publishing copy (#7583) (#7642) fix: rephrase Enable Orchestrator dialog (#7639) fix: update left nav and top bar strings (#7609) chore: bump wait-on to v5.3.0 (#7648) special case the fallback recognizer (#7634) fix: fit and finish across the app (#7598) ...
lei9444
pushed a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
cwhitten
added a commit
that referenced
this pull request
Jun 18, 2021
* make jest tests silent * fix path warning in tests * don't hide build/ or node_modules/ * fix createUploadHandler test * fix conversation handler test * use github actions reporter for test results * include test location in output * move jest dep into test-utils and use correct reporter name * ignore tests in dist * fix up botProject open handle * bump browserslist and update caniuse-lite * use node env for node tests supposedly this should help speed up tests that do not require jsdom * perpare server for @swc-node/jest * prepare client for @swc-node/jest * switch to swc for transpiling ts in tests * fix compiler errors * removed unused var * special case the fallback recognizer (#7634) * chore: bump wait-on to v5.3.0 (#7648) * fix: update left nav and top bar strings (#7609) * start fixing header * adjust header chrome and left nav order * Update en-US.json * fix typecheck errors * fix unit tests * Update en-US.json * change Design to Create in e2e tests * Update LuisDeploy.spec.ts * update flaky check in visitPage * add 'checked' flag to visitPage to minimize surface area * fix punctuation * fix e2e test! * fix security issue * Revert "fix security issue" This reverts commit 3aa6e3e4e36a951bb37244e01dd411fa4eca10dd. Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com> * fix: rephrase Enable Orchestrator dialog (#7639) * "Add a skill" page changes * Update EnableOrchestrator.tsx * Update skill.test.tsx * Update package.json * Update yarn.lock * Update en-US.json * fix: Update provision & publishing copy (#7583) (#7642) * Issue-7583: update copy for provision and publishing * en-us json files * Issue-7583: fix formatDialogTitle * Issue-7583: refactor formatDialogTitle * Issue-7583: reformat azure provision dialog block * PR fixes * Fixed spacing Co-authored-by: GeoffCoxMSFT <gcox@microsoft.com> * fix: Added cleanup logic to app on quit (#7645) * Added cleanup logic to app on quit * Added missing electron ipc event listener Co-authored-by: TJ Durnford <tjdford@gmail.com> Co-authored-by: Soroush <hatpick@gmail.com> * feat: show tunneling information notification when starting bot with remote skills (#7611) * add util to get device OS * add port to local publish result * add port to botEndpointsState * show ngrok notification when starting a bot with remote skills * only show the remote skills notification onces per session per bot * update l10n file * address feedback * update locale file after merge * fix failing test Co-authored-by: Soroush <hatpick@gmail.com> * feat: detect "old" bots and migrate them to new runtime (#6526) * introduce a migration system for updating legacy projcts to the 2.0 runtime * updated * ensure root dialog gets updated appropriately * adjust method for updating root dialog * remove comments * fire migration warning when loading bot * use original project name for new project * close modal on submit * address feedback * add confirm modal * Rename azureFunctionsPublish publish targets to azurePublish (new shared id) * Delete a.en-us.lu * Delete a.en-us.qna * Delete b.en-us.lu * Delete b.en-us.qna * Delete bot1.en-us.lu * Delete bot1.en-us.qna * do not require pva to migrate * Add missing parameters * clarify types * Fix tests reduce redundant code * Fixes #6844: migrate appinsights key to new location * fix migrate lint issue * plumb through the yeomanOptions parameter, required to set the location of the settings folder when migrating * feat: new validation pipeline - schema existence validation (#7001) * add placeholder for schema validator * add schema validator pipeline with mocked fn * add schema visitor * display diagnostics data in debug panel * revert sdk.ts * decrease schema diagnostic severity to 'Warning' * optmize path join logic * impl a unified walker covers SwitchCondition * fix lint error: use BaseSchema * feat: disable actions without schema * wrap in useEffect * optimization: avoid frequent recoil submission * optimization: aggregate paths rather than updatedDialog to reduce time complexity * chore: comments & var name * lint * add comments * defense undefined skip-level 'actions' * defense potential exceptions * get sdk.schema content correctly * fix lint * fix folder name case problem * Do not specify the luis endpoint key as a parameter to the runtime if no vlaue is present (#7240) (leaving this paramter blank causes issues on windows) * disable telemetry calls in the provision dialog while we investigate why telemetryclient is null (#7256) Co-authored-by: Geoff Cox (Microsoft) <gcox@microsoft.com> * prefer the botName field instead of the name field when managing connections (#7262) * fix: Empty Webchat inspector text and Disabling items in PVA context (#7241) * show floating notifications over eveything (#7269) Co-authored-by: Soroush <sorgh@microsoft.com> * Region for Microsoft Bot Channels Registration is now global (#7270) Co-authored-by: Ben Brown <benbro@microsoft.com> Co-authored-by: Soroush <hatpick@gmail.com> * fix: adjust package manager feeds (#7243) * Fix #7092: set default page size to 100 items * Fixes #6854: merge community feeds into main feed, sort by downloads * Fixes #7043: include any component tagged msbot-component * improve error handling * restore different checks for declarative only vs code driven components * refactor to use includes instead of indexOf Co-authored-by: Ben Yackley <61990921+beyackle@users.noreply.github.com> * fix: remodel About page (#7191) * remodel About page * add SHA to version * fixes from suggestion * get info from Electron and use it for Release field Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com> Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com> Co-authored-by: Ben Brown <benbro@microsoft.com> Co-authored-by: Geoff Cox (Microsoft) <gcox@microsoft.com> Co-authored-by: Srinaath Ravichandran <srinaath27@gmail.com> Co-authored-by: Soroush <hatpick@gmail.com> Co-authored-by: Soroush <sorgh@microsoft.com> Co-authored-by: Vamsi Modem <12182973+VamsiModem@users.noreply.github.com> Co-authored-by: Ben Yackley <61990921+beyackle@users.noreply.github.com> * fix mapping of schema files during migration * fix lint * fix default name of migrated project * run schema merge as part of the migration * do we need to migrate teh schema? or not? * do not migrate schema * - Adding field for runtime language - Fixing field population for runtime type * Passing runtime lang and type down to yeoman calls * Fixing adaptive runtime name * Hardcoding runtime version and fixing settings page generation on migrate * Fixing check for 'inBotMigration' to be based on CreationStatusState > path substring * Fix default naming * revert preload.js * Resolving PR comments and fixing errors from merge * Change schema diagnostics severity to 'Error' * Fetch @latest version from npm before migration Co-authored-by: Dong Lei <donglei@microsoft.com> Co-authored-by: leilzh <leilzh@microsoft.com> Co-authored-by: zhixzhan <zhixzhan@microsoft.com> Co-authored-by: zeye <zeye@microsoft.com> Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com> Co-authored-by: Geoff Cox (Microsoft) <gcox@microsoft.com> Co-authored-by: Srinaath Ravichandran <srinaath27@gmail.com> Co-authored-by: Soroush <hatpick@gmail.com> Co-authored-by: Soroush <sorgh@microsoft.com> Co-authored-by: Vamsi Modem <12182973+VamsiModem@users.noreply.github.com> Co-authored-by: Ben Yackley <61990921+beyackle@users.noreply.github.com> Co-authored-by: Patrick Volum <pavolum@outlook.com> Co-authored-by: Chris Whitten <christopherwhitten@gmail.com> * fix: data race writing on setting file (#7475) * fix data race writing on setting file * remove isSkill in skillConfiguration * remove default allowedCallers value Co-authored-by: TJ Durnford <tjdford@gmail.com> Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com> Co-authored-by: Ben Yackley <61990921+beyackle@users.noreply.github.com> Co-authored-by: Soroush <hatpick@gmail.com> * remove appsettings file from default gitignore (#7679) * fix: restore line beneath page header (#7676) * Update Page.tsx * Update BotProjectSettings.tsx * chore: Rebase main with 1.4.1 release (#7678) * exclude items from the package manager list that do not have names or versions -- such as locally implemented custom actions (#7683) * Add components field to migrated settings. Guard against missing field during component merge (#7674) Co-authored-by: Dong Lei <donglei@microsoft.com> Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com> * fix: (Un) Installing a package now stops the currently running bot beforehand (#7689) * Feed string, not int, to Switch per schema (#7707) Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com> * fix: generate manifest file when creating new publish target (#7666) * generate manifest file when creating new profile * test Co-authored-by: Lu Han <32191031+luhan2017@users.noreply.github.com> Co-authored-by: TJ Durnford <tjdford@gmail.com> * fix: converting bot with custom actions (ui update) (#7672) * Hides the PVA publish profile from the profle creation dropdown (#7725) * fix: set func-related settings during build step (#7723) * set func-related settings during build step * slight refactor to reduce duplicated code * add type * add typings in runtime plugin definition * set type of port to number * fix types, remove _ on variables that are used * feat: Add preparatory work before connecting remote skill (#7519) * draft dialog * ux css * css * jump to create profile & set microsoftAppId to publish target * comments & lint * refactor dialog wrapper * fix publish types missing in provision dialog (#7697) * test case * refactor * fix type define * fix title and json parse * fix app Id not sync when create new profile * Adds AppID and Password sections * test case fixed * Adds AppID/Password * Update copy Co-authored-by: Soroush <hatpick@gmail.com> Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com> Co-authored-by: Ben Yackley <61990921+beyackle@users.noreply.github.com> Co-authored-by: VanyLaw <wenyluo@microsoft.com> Co-authored-by: Lu Han <32191031+luhan2017@users.noreply.github.com> Co-authored-by: Chris Whitten <christopherwhitten@gmail.com> * fix: Revert changes to adaptive card templates to support PVA (#7808) * fix: Revert changes to adaptive card templates to support PVA * requested changes * fetch publish types for each project * fix: Throttle restart conversation (#7824) * Throttle restart Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> * Remove await Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> * Updated throttle time Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> * Unit test update Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> * Enable only on connected Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> * removed if Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> Co-authored-by: Srinaath Ravichandran <srravich@microsoft.com> * chore: automated localization updates (#7759) * Localized resource files from OneLocBuild * fix typos and stray apostrophes * fix apostrophes * typo fix * Update en-US.json * fix more apostrophes * revert reversions Co-authored-by: Composer Localization <botframework-composer-eng@service.microsoft.com> Co-authored-by: Ben Yackley <61990921+beyackle@users.noreply.github.com> Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com> * Deploy exception returns real error (#7837) * fix: Fix missing data collection settings on server (#7814) * fix: Fix missing data collection settings on server * fix tests * fix test again * minor change Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com> * fix: add inner scrollbar to selection area (#7782) * scroll * css * test Co-authored-by: Lu Han <32191031+luhan2017@users.noreply.github.com> Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com> * Migration: adjust target blob transcript field names (#7848) * fix: Always use intermediate lg template for text and speak modalities (#7842) * allow click outside blocking modals (#7727) Co-authored-by: Soroush <sorgh@microsoft.com> Co-authored-by: TJ Durnford <tjdford@gmail.com> * fix: Remove depth and transparentBorders from FieldProps, remove ObjectArrayField, and refactor OpenObjectField (#6633) * Remove depth and transparentBorder * Update OneOfField dropdown styles * Remove ObjectArrayField * fix tests * Refactor OpenObjectField * updated test * minor * fix test * minor Co-authored-by: Ben Yackley <61990921+beyackle@users.noreply.github.com> * fix: Teaching bubble missing content (#7764) * fix: Teaching bubble missing content * Fix item ref Co-authored-by: Ben Yackley <61990921+beyackle@users.noreply.github.com> Co-authored-by: Soroush <hatpick@gmail.com> * fix: Reset allowed callers cache when switching between project settings (#7874) * fix: Reset allowed callers cache when switching between project settings * comment Co-authored-by: Soroush <hatpick@gmail.com> * fix: breadcrumb & show code button collision (#7720) * fix breadcrumb & show code button collision * use flex * update styles * observe button width, auto layout ... breadcrumb * ignore typescript ResizeObserver declarations missing * fix type in test * useResizeObserver * fix mock Co-authored-by: Srinaath Ravichandran <srinaath27@gmail.com> Co-authored-by: Soroush <sorgh@microsoft.com> Co-authored-by: Soroush <hatpick@gmail.com> * Update home feed for Build 2021 (#7912) * fix (#7440) Co-authored-by: Soroush <sorgh@microsoft.com> Co-authored-by: TJ Durnford <tjdford@gmail.com> * fix: Custom function declaration (#7775) * Custom function declaration Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> * Typo in custom functions Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> Co-authored-by: Srinaath Ravichandran <srravich@microsoft.com> * add new caller when caller still have empty list, just focus on the empty one (#7767) Co-authored-by: Lu Han <32191031+luhan2017@users.noreply.github.com> * Resolve dns-packet to 1.3.4 to fix CVE-2021-23386 (#7942) Co-authored-by: Soroush <hatpick@fmail.com> * fix: invalid profile case (#7784) * invalid profile case * comments * remove unused component * refactor publish profile wrapper dialog * toekn page jump logic err Co-authored-by: Lu Han <32191031+luhan2017@users.noreply.github.com> Co-authored-by: Soroush <hatpick@gmail.com> * fix: Need to wait for zip deployment to be done processing (#7858) * Handled 202 * Added error case for processing * Improvements Co-authored-by: Soroush <hatpick@gmail.com> * Update readme screenshot (#7918) Co-authored-by: Soroush <sorgh@microsoft.com> * upgrade json-ptr (#7988) * update test-utils dependencies * remove console overrides * fix tests for jest 27 * use fake timers for jest * fix more tests for jest 27 * fix merge conflict * clean up * replace HookResult with RenderResult * fix orchestrator test * fix test warning * fix jest-haste-map warning * fix testid error * attempt to resolve NetworkError in tests that use jsdom * rename test file * globally mock http client * fix unhandled rejection error * clear mocks after each test * fix type errors * rename test file * move integration tests into own workspace this is required due to a dependency resolution conflict within @testing-library/dom. See testing-library/dom-testing-library#963 * remove unused dependency * fix integration tests linting errors * use correct directory for running e2e script * re-enable parallel cypress tests * pass --record option to cypress runner * actually set up cypress to run in parallel * add @testing-library/user-event to test-utils exports * fix fixture path * use fs-extra to ensure test bot directory * update cypress comands * remove pr trigger from pipeline 2 runs were happening. Trying to see if this fixes that. * re-enable cleanup after all tests * update lockfile * fix mocks and disabled button checks * add axios mock * remove cypress examples * add hasOrchestrator to useEffect dependencies * add description to integration-tests package.json * fix e2e script for windows * remove console.log Co-authored-by: taicchoumsft <61705609+taicchoumsft@users.noreply.github.com> Co-authored-by: Ben Yackley <61990921+beyackle@users.noreply.github.com> Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com> Co-authored-by: natalgar <82851479+natalgar@users.noreply.github.com> Co-authored-by: GeoffCoxMSFT <gcox@microsoft.com> Co-authored-by: Tony Anziano <tonyanziano5@gmail.com> Co-authored-by: TJ Durnford <tjdford@gmail.com> Co-authored-by: Soroush <hatpick@gmail.com> Co-authored-by: Ben Brown <benbro@microsoft.com> Co-authored-by: Dong Lei <donglei@microsoft.com> Co-authored-by: leilzh <leilzh@microsoft.com> Co-authored-by: zhixzhan <zhixzhan@microsoft.com> Co-authored-by: zeye <zeye@microsoft.com> Co-authored-by: Srinaath Ravichandran <srinaath27@gmail.com> Co-authored-by: Soroush <sorgh@microsoft.com> Co-authored-by: Vamsi Modem <12182973+VamsiModem@users.noreply.github.com> Co-authored-by: Patrick Volum <pavolum@outlook.com> Co-authored-by: Chris Whitten <christopherwhitten@gmail.com> Co-authored-by: Long Alan <alanlong9278@126.com> Co-authored-by: Lu Han <32191031+luhan2017@users.noreply.github.com> Co-authored-by: Long Alan <julong@microsoft.com> Co-authored-by: VanyLaw <wenyluo@microsoft.com> Co-authored-by: Srinaath Ravichandran <srravich@microsoft.com> Co-authored-by: Composer Localization <botframework-composer-eng@service.microsoft.com> Co-authored-by: Carlos Castro <carlosscastro@users.noreply.github.com> Co-authored-by: Gary Pretty <gary@garypretty.co.uk> Co-authored-by: Soroush <hatpick@fmail.com>
luhan2017
added a commit
that referenced
this pull request
Jun 21, 2021
* fix: export display name and sort order for templates outside of Composer (#6936)
* Adding template sort order json
* Moving templates.json
* Cleaning up routing to no longer use old creation experience
* Removing unneeded fetchTemplate param
* Adding logic to attmpt to get template order and display name from git hub with shipped sort order as back up
* Adding ben and patrick as Composer dir code owners
* fixing unit test
* Making PR changes
* Fixing references with extra param
* Fix unused props lint error
* Remove unneeded fetch template call
* Fixing unit test
* Adding correct mocks for unit test
* Adding route to support older paths
* fixing unit test for new creation routing
Co-authored-by: Soroush <hatpick@gmail.com>
Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
* fix: Route to appsettings correctly (#6992)
* Appsettings update
Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com>
* Remove unused event
Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com>
Co-authored-by: Srinaath Ravichandran <srravich@microsoft.com>
Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
Co-authored-by: Soroush <hatpick@gmail.com>
* fix: adjust mechanism used to determine if/when luis and qna teaching bubbles should pop out (#6973)
* adjust mechnaism used to determine if luis and qna bubbs should pop
* change name of variable
Co-authored-by: Srinaath Ravichandran <srinaath27@gmail.com>
Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
* fix: the format of hover info in LG editor (#6858)
* fix hover lg template display format
* add dependency in package json
* fix test case failed
* modify test
Co-authored-by: Soroush <hatpick@gmail.com>
Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
* feature: new design for Connections setting pane (#6724)
* remodel Adapters section into new design
* better formatting
* fix table formatting
* update l10n strings
* Update AdapterSection.tsx
* Update AdapterSection.tsx
* Update AdapterSettings.test.tsx
* Update en-US.json
* Update en-US.json
* Update AdapterSettings.test.tsx
* address PR comments
Co-authored-by: Tony Anziano <tonyanziano5@gmail.com>
Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
* Update query to grab qna template readme (#7021)
* fix: misc bug fixes in creation (#6950)
* Added hash to tab routing
* Fixing manage profile deep link
* Styling changes to remove double scroll bar in package manager
* Cleaning up style naming
Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
* feat: show topics in left nav (#6987)
* display topics in left nav
* only show external link icon on hover
* sort system topics at end of list
* show tooltip when hovering on pva topic
* show system topic icon
* collapse topic list with Enter
Co-authored-by: Ben Yackley <61990921+beyackle@users.noreply.github.com>
Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
* Runtime log for skills (#7030)
* fix abs (#7041)
* chore: update l10n files (#6920)
* update l10n files
* update l10n files
* feat: include pva topics by default (#7058)
* include pva topics by default when pulling from pva
* allow autocomplete on select dialog
* limit height of callout
* update tooltip copy
Co-authored-by: Tony Anziano <tonyanziano5@gmail.com>
* ci: use github-actions eslint formatter (#7015)
dont prefix output for CI
update github-actions formatter
* 7011 (#7018)
Co-authored-by: Soroush <sorgh@microsoft.com>
Co-authored-by: Srinaath Ravichandran <srinaath27@gmail.com>
Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
* fix: homepage header layout (#6926)
* fix header layout
* occupy screen width and fill card with background
* change card title style
* update card styles, color, font
* update styles
* update image setting
* update background , icon
* use NeutralColors.gray160
* define constant width height
Co-authored-by: Srinaath Ravichandran <srravich@microsoft.com>
Co-authored-by: Soroush <hatpick@gmail.com>
Co-authored-by: Srinaath Ravichandran <srinaath27@gmail.com>
* fix: Broken SVG image for QnA maker in provisioning (#7094)
* fix: 6566 Update provision handoff copy
* fix: 6851
* Moved sign-in to config page
* Fixed broken QnA image svg
* fix: pva deep link in new creation (#7100)
* removing unused commented code
* supporting client routing to defineConversation for PVA scenarios
* Ensuring runtimeType does not render as a creation dropdown for PVA scenarios
Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
* feat: new skill manifest creation experience (#6661)
* add skill select profile component
* manifest file cud api
* add skill select page and publish logic
* folder rename
* add lu files writing logic
* add redirect to publishing page action
* change folder name
* add lu file parsing and intents filtering
* Support .lu and .qna for static files
* 'notification'
* manifest file name
* add skill add callers logic
* add manifest path to BotStructureFilesPatterns
* fix e2e
* notification
* add publish skill settings update
* pop auth
* add skill hostendpoint
* fix comments
* title change
* fix copy url wrong
* fix filtered lu files
* merge selectManifest & fetchManifest & description popup
* next bugfix
* bugfix
* merge main & popup err
* Fix endpoint not update issue
* Fix new adaptive runtime copy skill manifests to wwwroot folder
* skip step revert
* tooltip
* add back button & fix url color
* Update the logic of updating skill host endpoint
* callers set
* remove the physical file provider
* back button
* default select publish profie
* disabled generated & publish button when no profie
* url wrong
* default publish target
* callers error
* add create publish profile dialog
* comments
* callers
* lint
* lint fix
* lint ignore
* test case
* remove manifest folder from read patterns
* comments
* comments & conflict
* type
* bugfix
* Fix the logic of updating skill settings
* delete duplicate manifest url
* add profile popup logic
Co-authored-by: Qi Kang <kangqidev@gmail.com>
Co-authored-by: Long Jun <alanlong9278@126.com>
Co-authored-by: Long Alan <julong@microsoft.com>
Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
Co-authored-by: Soroush <hatpick@gmail.com>
* feat: update the experience of adding a remote skill scenario (#6640)
* update add remote skill UI
* polish
* add trigger after skill created
* add action to on intent trigger after add remote skill
* import orchestrator after add remote skill
* add loading spinner
* fix bug
* add skill and alowCalled into appsettings
* fix skill identifier wrong in new action
* fix skill identifier
* remove allowedCaller when remove skill
* fix skill not added after add remote skill
* fix orchestractor modal not show
* remove trigger when remove skill, fix bugs
* polish UI
* add endpoint dropdown
* en-us
* filter duplicate msAppId in allowedCaller
* disable entity in lueditor
* polish
* fix some comments
* fix lint
* fix comments
* add prerelease
* fix test, fix endpoints bug, append intent to multiLanguage lufile
* polish
* disable next if lueditor error
* fix lint
* fix multi language
* show warning msg if remote lufile get fail
* fix typecheck
* fix comments
* fix test
* fix comments
* fix test
* fix comments
* change sidebar back
* enus
Co-authored-by: Lu Han <32191031+luhan2017@users.noreply.github.com>
Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
* fix: provisioning resource groups typing partial existing name (#7103)
* fix: 6566 Update provision handoff copy
* fix: 6851
* Moved sign-in to config page
* Fixed broken QnA image svg
* fix issues with existing name stopping is new
* fix: multiple minor bugs in provision and creation (#7064)
* Make create from qna url modal blocking
* fix for bug in new tab view:
add botProjectData as dep to regenerate botStatusList
* Adding prevew tag to node tab in template selection view
* Fix error message for bot name
* fixing typo
Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
* fix: Update OnChooseIntent template to support Orchestrator (#7004)
* Genericizing OnChooseIntent
* Fix broken schema
* Allow more than 2 choices
* linter fixes
* trigger.ts not sending locale to worker
* Fix to normalize the names in lgUtil
* Remove all OnChooseIntent LG from common
* Rename parent template name to ChooseIntent
* Minor refactor
* fix linter issues
Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
* fix: remodel ProjectTree using ul/li tags (#7063)
* swap out details/summary for ul/li
* fix placement of items
* Update ExpandableNode.tsx
* fix layout issues and clicking behavior
* fix variables
* more fixes
* Update ExpandableNode.tsx
* Update ProjectTree.tsx
* Update ProjectTree.tsx
* remove stray comment
* Update expandableNode.test.tsx
* add new timeout to tests
* Update Breadcrumb.spec.ts
* post-merge fixes
* scope breadcrumb tests to inside breadcrumb
Co-authored-by: Andy Brown <asbrown002@gmail.com>
* feat: diable /hide items when in PVA bot context (#7119)
* feat: migrate E2E test with bot creation v2 (#7040)
* migrate e2e test with create bot v2
* cache created bot from template
* update
* update
* update and merge
* update
Co-authored-by: Ben Brown <benbro@microsoft.com>
Co-authored-by: Andy Brown <asbrown002@gmail.com>
* fix: publish targets was overwrited during opening abs (#7137)
* fix open abs, publish targets overwrite
* fix the get alias issue
Co-authored-by: Lu Han <32191031+luhan2017@users.noreply.github.com>
* fix: Remove tag entity menu from LU Toolbar (#7171)
* fix: Remove tag entity menu from LU Toolbar
* remove en-US changes
* minor
* remove test
* fix: Refactor LUIS, QNA and Speech to use a single base component (#6923)
* Refactor LUIS, QNA and Speech to use a single base component
* fix height, sort order
* fix typing
* use shared colors
* refactor handoff instructions to share some text
* Update BotProjectsSettingsTabView.tsx
* refactor qna maker provisioning into a background process
* fix linter quible:w
* remove dep
* rename setVisible to onToggleVisibility
* Use shared color
* add conditional around missing hostname
* add conditional around missing hostname
* remove duplicate import
Co-authored-by: Ben Yackley <61990921+beyackle@users.noreply.github.com>
Co-authored-by: Srinaath Ravichandran <srinaath27@gmail.com>
* fix: UI bugs in provisioning (#7130)
* Make firendly link and add blank targer for broken azure link
* Fix scrollilng in publish modal
* Fixed comment box in publish confirm modal
* configure resource ui fix #6886
* import existing resources fit and finish #6889
* #7132: standardizing qna plural/singular resource strings
* #7133: disabling Luis and Qna exit modal functionality when resources are being created
* #7126: remove semi colen
* Updating localized text
* Fixing inline conditionals
* Updating unit test
* Initial changes from UI meeting
* Removing unused imports
* Adding back changes reverted during merge
* fix: catch dotnet errors during creation and offer download link (#7062)
* catch dotnet error
* Handle error for missing dotnet 3.1 during creation
* remove unnecessary wrapper funct
* update to syntax of component, small cleanup items from PR
* remove old NodeModal (replaced by InstallDepMOdal)
Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
Co-authored-by: Geoff Cox (Microsoft) <gcox@microsoft.com>
* feat: add filter to begin dialog selection (#7193)
* make custom system topic icon more versitile
ex. it will now inherit font color from parent
* convert select dialog to a contextual menu
in preparation for adding filtering function
* correctly assess whether to show text field
* add filter to dialog list when more than 10
* align system topic centered vertically
* fix issue escaping search box with down arrow
* overflow dialog menu when more than 10 items
Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
* fix publish targets state update (#7207)
* fix: Recent bots sort and update styles (#7140)
* update styles
* recent bots list
* lint
* no hover color for table header
Co-authored-by: Ben Yackley <61990921+beyackle@users.noreply.github.com>
* fix: LG goto definition lost some cross files definitions (#7203)
* fix lg goto missing
* remove log
Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
* fix: sort multi-skill bots in list by first opening of root (without skills) (#7185)
* add isRootBot argument to fetching projects
* Update Home.tsx
* Update project.test.ts
* Update en-US.json
* fix: reset dialog filter upon dismissing menu (#7222)
Co-authored-by: Soroush <hatpick@gmail.com>
* Fix conditional rendering of runtime dropdown (#7228)
Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
* fix: minor UI bugs in provisioning and node modal (#7233)
* Fix conditional rendering of runtime dropdown
* #6890 add resource fit and finish
* Making design requested changes to provisioning form dialog
* Fixing styling in add resource modal
* Add need to restart in node modal
* Revert changes
* Updating template sort order list in anticipation of new package names
* - Adjusting padding to fit multipleof 4
- taking dashes out of formatMessage
* removing new line
* fix: add telemetry events for new qna, luis and speech flows (#7227)
* add telemetry events for new qna, luis and speech flows. add additional telemetry to get started.
* add additional telemetry calls to the provisioning process
* remove some unused imports
* Update extensions/azurePublish/src/components/azureProvisionDialog.tsx
Co-authored-by: TJ Durnford <tjdford@gmail.com>
* Update extensions/azurePublish/src/components/azureProvisionDialog.tsx
Co-authored-by: TJ Durnford <tjdford@gmail.com>
* Update extensions/azurePublish/src/components/azureProvisionDialog.tsx
Co-authored-by: TJ Durnford <tjdford@gmail.com>
* Update extensions/azurePublish/src/components/azureProvisionDialog.tsx
Co-authored-by: TJ Durnford <tjdford@gmail.com>
* Update extensions/azurePublish/src/components/azureProvisionDialog.tsx
Co-authored-by: TJ Durnford <tjdford@gmail.com>
* Update extensions/azurePublish/src/components/azureProvisionDialog.tsx
Co-authored-by: TJ Durnford <tjdford@gmail.com>
* Update extensions/azurePublish/src/components/azureProvisionDialog.tsx
Co-authored-by: TJ Durnford <tjdford@gmail.com>
* change name of event to ProvisionAddResourcesNavigate
* rename event
Co-authored-by: TJ Durnford <tjdford@gmail.com>
* fix ux issues (#7242)
Co-authored-by: Soroush <sorgh@microsoft.com>
* fix: update UI in bot settings page to final R13 design spec (#7065)
* tab name changes
* Updating to latest UI: first/overview tab in settings page
* Adding (root) suffix to root bot in settings view nav pane
* removing old table view of bot settings page
* Fixing Luis and Qna styling
* Fixing fluentUI imports and skills settings page UI
* Fixing UI for appID component in settings page
* Fixing connections tab UI
* Fixing skills tab UI
* language tab UI fixes
* Adding teams callout when teams is enabled
* removing unused variables and deps
* Changing text with links to use formatMessage.rich
* Fix column width
* Fixing luis provision modal read me link
* Updating locale file
* Remove unused import
* Update unit test to reflect new tab text
* Add links to new hyperlinks in settings page
* Adding learnmore links to new qna/luis modal implementation
* Adding keys to rich format message
* updating locale file
* Making minor changes requested in PR
Co-authored-by: Soroush <hatpick@gmail.com>
* fix: Sorted options on Azure & Luis region dropdowns (#7244)
* Sorted options on Azure regions & luis dropdowns
* Fixing the error from unit tests
Co-authored-by: Soroush <hatpick@gmail.com>
* fix: widen column in feed modal (#7239)
Co-authored-by: Andy Brown <asbrown002@gmail.com>
* fix: introduce ability to pick a free or paid tier of QnA (#7184)
* Refactor LUIS, QNA and Speech to use a single base component
* fix height, sort order
* fix typing
* use shared colors
* refactor handoff instructions to share some text
* Update BotProjectsSettingsTabView.tsx
* refactor qna maker provisioning into a background process
* fix linter quible:w
* remove dep
* rename setVisible to onToggleVisibility
* Use shared color
* add conditional around missing hostname
* add conditional around missing hostname
* remove duplicate import
* add ability to specify pricing tiers when provisioing a qna
Co-authored-by: Ben Yackley <61990921+beyackle@users.noreply.github.com>
Co-authored-by: Srinaath Ravichandran <srinaath27@gmail.com>
Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
* Do not specify the luis endpoint key as a parameter to the runtime if no vlaue is present (#7240)
(leaving this paramter blank causes issues on windows)
* disable telemetry calls in the provision dialog while we investigate why telemetryclient is null (#7256)
Co-authored-by: Geoff Cox (Microsoft) <gcox@microsoft.com>
* prefer the botName field instead of the name field when managing connections (#7262)
* fix: Empty Webchat inspector text and Disabling items in PVA context (#7241)
* show floating notifications over eveything (#7269)
Co-authored-by: Soroush <sorgh@microsoft.com>
* Region for Microsoft Bot Channels Registration is now global (#7270)
Co-authored-by: Ben Brown <benbro@microsoft.com>
Co-authored-by: Soroush <hatpick@gmail.com>
* fix: adjust package manager feeds (#7243)
* Fix #7092: set default page size to 100 items
* Fixes #6854: merge community feeds into main feed, sort by downloads
* Fixes #7043: include any component tagged msbot-component
* improve error handling
* restore different checks for declarative only vs code driven components
* refactor to use includes instead of indexOf
Co-authored-by: Ben Yackley <61990921+beyackle@users.noreply.github.com>
* fix: remodel About page (#7191)
* remodel About page
* add SHA to version
* fixes from suggestion
* get info from Electron and use it for Release field
Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
* fix: Remove placeholder before saving import config (#7265)
* fix: 6566 Update provision handoff copy
* fix: 6851
* Moved sign-in to config page
* Fixed broken QnA image svg
* fix issues with existing name stopping is new
* Remove placeholders before saving import config
* Inline remove placeholders
* fix: error dialog should allow scrolling of error text (#7251)
* Issue-6727: update error popup consoleStyle to scroll, change background.
* Issue-6727: refactor format error title
* Issue-6727: use formatMessage, lighten up gray
Co-authored-by: natalgar <natalie.garcia@microsoft.com>
Co-authored-by: pavolum <pavolum@outlook.com>
Co-authored-by: Geoff Cox (Microsoft) <gcox@microsoft.com>
Co-authored-by: Soroush <hatpick@gmail.com>
* fix: replace PVA with Power Virtual Agents (#7279)
* replace PVA with Power Virtual Agents
* update english locale
Co-authored-by: Ben Yackley <61990921+beyackle@users.noreply.github.com>
* fix: Empty setting for recognizer configuration when switch bot (#7302)
* fix: Empty setting for recognizer configuration when switch bot
* update the naming
* fix: delete wrong trigger when delete skill and its trigger (#7305)
* fix repeated luIntent in add remote skill
* enus
* unblock diapatch modal is non
* add await in delete trigger
* fix trigger deleted, if no relevant trigger found
* fix: expose provisionComposer script in easily downloadable way (#7180)
* add an adminHandoff folder and new instructions
* rename folder
* add easily downloadable scripts
* direct download link for scripts
* direct download link for scripts
* correct numbers on steps
* fix: use correct worker script in electron development (#7274)
Co-authored-by: Soroush <sorgh@microsoft.com>
Co-authored-by: Andy Brown <asbrown002@gmail.com>
* fix: use router-based links to project manager (#7271)
* use router-based links to project manager
* fix unit test
* Update AdapterSettings.test.tsx
Co-authored-by: Andy Brown <asbrown002@gmail.com>
Co-authored-by: Soroush <hatpick@gmail.com>
Co-authored-by: TJ Durnford <tjdford@gmail.com>
* Fix for settings being overriden (#7294)
Co-authored-by: Andy Brown <asbrown002@gmail.com>
* fix: Change carousal to carousel in LG Editor (#7318)
* fix: Change carousal to carousel in LG Editor
* l10n
* Moved Web Chat log item keys outside of component (#7319)
* fix: Data loss when cutting / copying & pasting response (#7296)
Co-authored-by: Dong Lei <donglei@microsoft.com>
Co-authored-by: Soroush <hatpick@gmail.com>
* fix: export bot include v2 project structure files (#7248)
* export bot include new structure files
* include js runtime type bot files
* clean up
Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
* fix: refactor way we get COMPOSER_VERSION (#7326)
Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
* fixes 6799 (#7320)
Co-authored-by: Soroush <sorgh@microsoft.com>
* fix: Update provisioning model based on feedback (#7328)
* fix: 6566 Update provision handoff copy
* fix: 6851
* Moved sign-in to config page
* Fixed broken QnA image svg
* fix issues with existing name stopping is new
* Remove placeholders before saving import config
* Inline remove placeholders
* Updated provisioning UI based on change requests
* Add formatMessages
* formatMessage
* Reverting cancel button spacing per design
* Updated link location to SDK release, adds link to documenation on the About page (#7339)
Co-authored-by: Soroush <hatpick@gmail.com>
* Bumps to 2.0.0 (#7350)
* fix: fix LuEditor block entity in skill dialog (#7201)
* update orchestrator
* remove entity check in add remote skill
* update lueditor lufeature
* revert the changes about luFeatures
Co-authored-by: Lu Han <32191031+luhan2017@users.noreply.github.com>
Co-authored-by: Dong Lei <donglei@microsoft.com>
Co-authored-by: Soroush <hatpick@gmail.com>
* fix: allower callers displayed like available to edit (#7361)
* callers ux refactor
* auto focus
* lint
Co-authored-by: Lu Han <32191031+luhan2017@users.noreply.github.com>
* fix: Orchestrator report entity error (#7362)
* Orchestrator report entity error
* set to warning
Co-authored-by: Dong Lei <donglei@microsoft.com>
* fix: re-enable telemetry events in azure provision dialog (#7332)
* make shell available to all plugin types
* re-enable telemetry events in azure publish dialog
Co-authored-by: Ben Brown <benbro@microsoft.com>
Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
* fix: allow scroll on editor parent (#7357)
Co-authored-by: Andy Brown <asbrown002@gmail.com>
* fix: adjust get started tasks (#7344)
* Add 2 new tasks to get started (view readme, complete profile) and make edit LU, edit LG recommended steps
* add formatMessage
Co-authored-by: Andy Brown <asbrown002@gmail.com>
* fix: better display and logic around handling remote skills (#7330)
* handle remote bots better in tree and package manager
* start plugin at root bot
* check remoteness and disable sidebar icons if needed
* Update pageLinks.ts
* fix: Resolve PVA check logic missing (#7369)
* Resolve minor logic error
Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com>
* Hide item
Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com>
Co-authored-by: Srinaath Ravichandran <srravich@microsoft.com>
Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
* fix: dummy skill (#7306)
* Fix dummy skill issue
* dummy skill
* revert
Co-authored-by: Long Alan <julong@microsoft.com>
Co-authored-by: Soroush <hatpick@gmail.com>
Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
* fix: share name field between two create kb modal (#7304)
* share knowledge base name between modal and update text
* update text
* fix UT
* handle comments
* update interface
Co-authored-by: Soroush <hatpick@gmail.com>
Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
* fix: Add hostname default to import publishing profile (#7370)
* fix: 6566 Update provision handoff copy
* fix: 6851
* Moved sign-in to config page
* Fixed broken QnA image svg
* fix issues with existing name stopping is new
* Remove placeholders before saving import config
* Inline remove placeholders
* Updated provisioning UI based on change requests
* Add formatMessages
* formatMessage
* Reverting cancel button spacing per design
* Added hostname default
Co-authored-by: Soroush <hatpick@gmail.com>
* feat: Add RecognizerChanged telemetry event (#7374)
* feat: Add RecognizerChanged telemetry event
* Update RecognizerField.tsx
Co-authored-by: Soroush <hatpick@gmail.com>
* Updating templates.json to remove old display name mappings and match desired ordering. (#7375)
* clean recent projects (#7379)
Co-authored-by: Soroush <sorgh@microsoft.com>
* feat: Move Webchat Panel inside the Page section to prevent overlap over Debug Pane (#7258)
* correct logic for validating connection modal (#7384)
Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
* Remove LUIS from trigger dialog (#7386)
Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
* fix: Update copy of provision step title (#7377)
* fix: 6566 Update provision handoff copy
* fix: 6851
* Moved sign-in to config page
* Fixed broken QnA image svg
* fix issues with existing name stopping is new
* Remove placeholders before saving import config
* Inline remove placeholders
* Updated provisioning UI based on change requests
* Add formatMessages
* formatMessage
* Reverting cancel button spacing per design
* Added hostname default
* Updated step title string
* fix plugin page router (#7400)
* fix: various template bugs (#7378)
* Fix qna template name and prepare sort order for new package names
* Fixing default proj name logic and minor cleaning up
* Partially fix initial template selection bug
* Add timeout to fully fix initial template selection UI bug
* fix qna read me bug
* fix backup sort order
* Adding new templates to sort template unit test
* Fix creation unit test to account for new template name
* Adjusting unit test to check for default name derived by display name vs template package name
* Catch common QNA maker error about limits (#7368)
Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
* fix #7403: include packages based on specific tags, rather than the msbot-component catchall (#7407)
* Fixed luis provisioning to return location (#7431)
Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
* fix: Add a warning about the luis authoring key 1000/month limit (#7430)
* Add a warning about the luis authoring key 1000/month limit unless an endpoint key is set
* add space
Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
* fix: add skills flow refactored to desired R13 spec (#7432)
* Adding new creationflow status and setting of that status in new skills flow
* Adding new modal for 'add skills' flow per spect in #7115
* Changing dialog type to have proper size
Co-authored-by: Ben Brown <benbro@microsoft.com>
* fix: UI fixes in getting started rocket panel (#7418)
* Various style changes to resolve issue #6993
* fix style tagging
* Styling changes after review with Em
* fixing default naming
* fixing unit test to account for new default naming
* creating named css variable for rocket panel description styling
* Adding learn more links
* Cleaning up logic for default name generation
Co-authored-by: TJ Durnford <tjdford@gmail.com>
* fix: bump bf-dialog to 4.13.1 (#7419)
* bump bf-dialog to 4.13.1
* update yarn locks
Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
* fix: address minor UX issues for PVA bots (#7437)
* update getting started blade for pva bots
* disable form dialogs link for pva bots
* disable entity buttons for pva bots
Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
* fix: when add remote skill show manifest json parse error (#7396)
* skill manifest show json parse error
* update
* Update CreateSkillModal.tsx
* Update CreateSkillModal.tsx
* update message
Co-authored-by: Dong Lei <donglei@microsoft.com>
Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
* fix: Improve LG response editor parsing for text/speech variations (#7434)
* fix
* added comments
* minor
* lint
* lint
Co-authored-by: Soroush <sorgh@microsoft.com>
Co-authored-by: TJ Durnford <tjdford@gmail.com>
Co-authored-by: Dong Lei <donglei@microsoft.com>
* Add azure functions existing when hostname there (#7455)
* Removed ARM & graph tokens on signout (#7457)
* fix: address missing links in provisioning, updated tags in package manager (#7458)
* fix #7454: add msbot-middleware to list of tags used to identify a code-driven pacakge
* Fix #7449: update links in provision flow
Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
* Fixed the buttons position on the provisioning modal. (#7459)
* fix: detect bots vs skills in Most Recently Used list (#7463)
* clean up a bit of redundant code
* detect root vs skill in import and creation
* Update project.ts
* fix: Added copy from profile button and dialog (#7465)
* Added copy from profile button and dialog
* Updates and fixes
* PR updates
* PR fixes
* More PR improvements
* Fix of import
* fix: hide recognizers if they don't exist in the app schema (#7469)
Co-authored-by: TJ Durnford <tjdford@gmail.com>
* chore: Temporarily removes save as button for R13 (#7482)
* chore: Temporarily disable save as button for R13
* disable e2e save as test
* Updates Diagnostic message when a Skill is referenced that is not in the current project (#7481)
Co-authored-by: Soroush <hatpick@gmail.com>
* fixes notification container blocking interaction (#7429)
Co-authored-by: Soroush <sorgh@microsoft.com>
Co-authored-by: TJ Durnford <tjdford@gmail.com>
Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
* fix: Add Publish your bot to get started list (#7484)
* Add Publish your bot to get started list
* add learn more link
Co-authored-by: Andy Brown <asbrown002@gmail.com>
Co-authored-by: Soroush <hatpick@gmail.com>
* fix: enable users to select any non multi bot template during add new skills flow (#7494)
* Fix wording and routing in addBotModal
* Adding isMultiBot boolean value to botTemplate type
* setting isMultiBotTemplate based on keyword value from template generator
* Adding logic to not show multibot template if you are in the add skills flow
* Adjusting unit test for new botTEmplate multibot variable
* Adding formatMessages
* Removing unneeded code in conditional
* fix: update gitignore, detect missing func runtime (#7488)
* Fix #7473: add generated/ to .gitignore
* fix #7471: detect missing func runtime
* fix error link text
Co-authored-by: Soroush <hatpick@gmail.com>
* fix: Handle expiration on token used for tenants (#7504)
* Handle expiration on token used for tenants
* Clear expiration on shutdown
* Fix unit test and no account response
* feat: auto publish after creating new provision. (#7249)
* add trigger for publish
* provision & publish
* async problem
* lint
* sync file change
* async publish target
* navigate to publish page after returning publish result
* add url
* comments
* bugifx
* lint
Co-authored-by: Lu Han <32191031+luhan2017@users.noreply.github.com>
Co-authored-by: Dong Lei <donglei@microsoft.com>
Co-authored-by: Soroush <hatpick@gmail.com>
Co-authored-by: Srinaath Ravichandran <srinaath27@gmail.com>
* fix: allow dashes for pva bot names (#7500)
* allow dashes for pva bot names
* update v2 invalid name char
Co-authored-by: Ben Yackley <61990921+beyackle@users.noreply.github.com>
* fix: Check for webchat panel visibility (#7514)
Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com>
Co-authored-by: Srinaath Ravichandran <srravich@microsoft.com>
Co-authored-by: Ben Yackley <61990921+beyackle@users.noreply.github.com>
Co-authored-by: Andy Brown <asbrown002@gmail.com>
* Fix #7525: correct luis link (#7527)
Co-authored-by: Ben Yackley <61990921+beyackle@users.noreply.github.com>
Co-authored-by: Andy Brown <asbrown002@gmail.com>
* feat: add telemetry around new bot creation (#7508)
* Adding missing types
* Simplifying createModal telem
* convert formatMessage variable to function
* Adding creation cancelled telemetry
* telemetry for provision profile creation failure
* Adding telemetry for request template button
* Adding telem for publish success and failure
* Adding telem for publish start button click
* Adding telem for create provision prof started with newResoruceGroup variable
* Adding unary null operator
* - making PR changes
- updating localization file
* removing ununsed imports
* Making requested PR changes
Co-authored-by: Ben Yackley <61990921+beyackle@users.noreply.github.com>
* fix: Added sign out confirmation and notify user on sign out (#7537)
* Removed Signout Link & added title on Add new publishing profile
* Add Notification capability to extensions
* Added notification styles
* Modified authClient api
* Removed deplicate code
* Refactored signout confirmation code
* Added aria role to the div
* User will be notified when signout fails
* Changed the confirmation message & used the exisiting notificationType
* Removed unused type
Co-authored-by: Soroush <hatpick@gmail.com>
* fix: Display Orchestrator Selection Dialog for Local Skills (#7518)
* First pass to add OrchSkillDialog to local skills
* Rename Orchestractor to Orchestrator
* update package to 4.13.1
* Address PR comments
* Use string constants where possible
* Rename Orchestrator component
* Fix another typo
* Change link to bf-orchestrator
* Link and copy changes per PM and Design
* add unit test
Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
* fix: Updates AllowedCallers component to use unique keys for array items (#7540)
* fix: Updates AllowedCallers component to use unique keys for array items
* requested changes
* fix: correct the MS AppID text in the settings view (#7552)
* #7426 Fix appsettings copy
* localization updates
* fix: Add a QNA trigger to the dialog if it doesnt exist (#7534)
* Add a QNA trigger to the dialog if it doesnt exist -- when adding a KB in the KB page
* remove space
Co-authored-by: Soroush <hatpick@gmail.com>
Co-authored-by: Andy Brown <asbrown002@gmail.com>
* fix: split "Add new" button into its own section on Publish Targets page (#7512)
* Update PublishTargets.tsx
* streamline some logic and rename variables for clarity
* fix: Using Get LUIS or Get QnA Key option does not work in Composer (#7553)
* Added auth flow MSA Accounts
* Code review changes
* Removed unnecessary code
* changed function from 'subscriptionSelector' to 'renderSubscriptionSelectionStep'
* Minor UI fixes
* Added new strings to en-US.json
* Formatted regions on LUIS/QnA resource creation dialog and removed unused code.
Co-authored-by: pavolum <pavolum@outlook.com>
* fix: Reopening of dialog due to hash (#7559)
* Fixed reopening of dialog due to hash
* Added back dependencies
* fix: Updated the cypress test for the integration test to succeed (#7575)
* Added auth flow MSA Accounts
* Code review changes
* Removed unnecessary code
* changed function from 'subscriptionSelector' to 'renderSubscriptionSelectionStep'
* Minor UI fixes
* Added new strings to en-US.json
* Formatted regions on LUIS/QnA resource creation dialog and removed unused code.
* Updated cypress test
Co-authored-by: pavolum <pavolum@outlook.com>
* fix: Update attachment template format to support PVA (#7564)
* fix: Update attachment template format to support PVA
* minor changes
* fix tests
* fix lint issue
Co-authored-by: Soroush <hatpick@gmail.com>
* Revert "fix: Update attachment template format to support PVA (#7564)" (#7592)
This reverts commit ee715eb9ee336dce7aabbb2eed585f65ef4dfc3d.
* fix: Update attachment template format to support PVA (#7593)
minor changes
fix tests
lint
* fix: address a regression in the start bot button that caused final 'get started' bubb not to pop (#7567)
* fix #7560: address a regression in the start bot button
* change name of element
Co-authored-by: Soroush <hatpick@gmail.com>
* fix: get tenant specific arm tokens for connections (#7554)
* fix #7536: get tenant specific arm tokens
* combine auth into 1 function
* Attempt various ways to determine tenantId
* only set current resource if auth was successful
Co-authored-by: Andy Brown <asbrown002@gmail.com>
* fix: change copy on home page (#7604)
* edit strings to match suggestions
* Update Home.tsx
* Update Home.tsx
* fixes from review and e2e test
* l10n update
* Update provisionScript.zip with small syntax changes (#7563)
Co-authored-by: Ben Yackley <61990921+beyackle@users.noreply.github.com>
Co-authored-by: Soroush <hatpick@gmail.com>
* fix: Adjust build command used for dotnet functions (#7557)
* Adjust build command used for dotnet functions
* pass in the appid/passwd to functions
* correct source of appid/password ford func deploy
Co-authored-by: Soroush <hatpick@gmail.com>
Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
* fix: fixes auth flow on web & electron version (#7623)
* Added auth flow MSA Accounts
* Code review changes
* Removed unnecessary code
* changed function from 'subscriptionSelector' to 'renderSubscriptionSelectionStep'
* Minor UI fixes
* Added new strings to en-US.json
* Formatted regions on LUIS/QnA resource creation dialog and removed unused code.
* Updated cypress test
* Fixed the auth flow
* Tenant dropdown fix
Co-authored-by: pavolum <pavolum@outlook.com>
Co-authored-by: Soroush <hatpick@gmail.com>
* fix: ui copy updates (#7599)
* copy updates
* Fixes for LUIS service copy
* adjustments for qna and speech copy
* qna maker copy changes
* copy changes
* casing
* address comments
* update locale
* fix test
* fix linter problem
* fix typescript
* fix: LG Editor Fit & Finish (#7636)
* fix: LG Editor Fit & Finish
* l10n
* fix: rephrase Open from ABS dialog (#7637)
* Update constants.ts
* replace text on choices
* remove Learn More for now
Co-authored-by: Soroush <hatpick@gmail.com>
* fix: fit and finish across the app (#7598)
* Remove bot settings tool bar buttons
* Change settings header string and remove subtext
* Fix capitalization in settings tabs
* More space between pivot menu and content--should be consistent on each tab
* - Align content with pivot menu on left side
- Max width of inputs and text 580x in all tabs
* In all tables, headers should be semi-bold rather than bold
* nix tool tip on start command
* "Readme" instead of "Read Me"
* Ensure padding at bottom of page
* Tighten up horizontal spacing between columns in tables
* Replacing routerLink with Link for consistent styling
* Lower-case M in "Open manifest"
* - Action item sub-text too small
- Tighten space between action items more
(between bottom of sub-text and title of next item)
* Sub-titles should be semi-bold
* - Align table with “Publish” (move to the right)
* - "Publishing profile"--lowercase on profile
* - Super long add button (#7491)
* Table needs line under header
* Edit and delete buttons are too small, too high
* Align Target column content with header (move content right)
* Tighten spacing between edit and delete buttons
* "Learn more" move to top sentence after "...Microsoft Azure is required." and lowercase m
* - Lowercase m
* - Do we need description field? Can we remove it?
- If so, maybe runtime type on right?
- Inputs same width (370px?)
- “Create new folder” under input
* Design iteration changes with Em
* add line under bot settings header
* Almost there" bubb is the wrong component, should be the blue one
* urther Tighten spacing between edit and delete buttons in publish view
* DefineConversation: Button should say “Create” instead of OK
* Move json switch to right side and make text smaller size
* Fix existing resource terminology in service provision modal
* #7578: increase width of publish profile dropdown
* Auto close get started pane when bot controller callout is visible
* fixing errors from merge
* Fix unit test
* removing unit test based on old link type
* updating locale strings
Co-authored-by: Soroush <hatpick@gmail.com>
Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
* special case the fallback recognizer (#7634)
* chore: bump wait-on to v5.3.0 (#7648)
* fix: update left nav and top bar strings (#7609)
* start fixing header
* adjust header chrome and left nav order
* Update en-US.json
* fix typecheck errors
* fix unit tests
* Update en-US.json
* change Design to Create in e2e tests
* Update LuisDeploy.spec.ts
* update flaky check in visitPage
* add 'checked' flag to visitPage to minimize surface area
* fix punctuation
* fix e2e test!
* fix security issue
* Revert "fix security issue"
This reverts commit aa008c1f7857667b5e2f4cb3e0fcedbb8c1ad7af.
Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
* fix: rephrase Enable Orchestrator dialog (#7639)
* "Add a skill" page changes
* Update EnableOrchestrator.tsx
* Update skill.test.tsx
* Update package.json
* Update yarn.lock
* Update en-US.json
* fix: Update provision & publishing copy (#7583) (#7642)
* Issue-7583: update copy for provision and publishing
* en-us json files
* Issue-7583: fix formatDialogTitle
* Issue-7583: refactor formatDialogTitle
* Issue-7583: reformat azure provision dialog block
* PR fixes
* Fixed spacing
Co-authored-by: GeoffCoxMSFT <gcox@microsoft.com>
* fix: Added cleanup logic to app on quit (#7645)
* Added cleanup logic to app on quit
* Added missing electron ipc event listener
Co-authored-by: TJ Durnford <tjdford@gmail.com>
Co-authored-by: Soroush <hatpick@gmail.com>
* feat: show tunneling information notification when starting bot with remote skills (#7611)
* add util to get device OS
* add port to local publish result
* add port to botEndpointsState
* show ngrok notification when starting a bot with remote skills
* only show the remote skills notification onces per session per bot
* update l10n file
* address feedback
* update locale file after merge
* fix failing test
Co-authored-by: Soroush <hatpick@gmail.com>
* feat: detect "old" bots and migrate them to new runtime (#6526)
* introduce a migration system for updating legacy projcts to the 2.0 runtime
* updated
* ensure root dialog gets updated appropriately
* adjust method for updating root dialog
* remove comments
* fire migration warning when loading bot
* use original project name for new project
* close modal on submit
* address feedback
* add confirm modal
* Rename azureFunctionsPublish publish targets to azurePublish (new shared id)
* Delete a.en-us.lu
* Delete a.en-us.qna
* Delete b.en-us.lu
* Delete b.en-us.qna
* Delete bot1.en-us.lu
* Delete bot1.en-us.qna
* do not require pva to migrate
* Add missing parameters
* clarify types
* Fix tests
reduce redundant code
* Fixes #6844: migrate appinsights key to new location
* fix migrate lint issue
* plumb through the yeomanOptions parameter, required to set the location of the settings folder when migrating
* feat: new validation pipeline - schema existence validation (#7001)
* add placeholder for schema validator
* add schema validator pipeline with mocked fn
* add schema visitor
* display diagnostics data in debug panel
* revert sdk.ts
* decrease schema diagnostic severity to 'Warning'
* optmize path join logic
* impl a unified walker covers SwitchCondition
* fix lint error: use BaseSchema
* feat: disable actions without schema
* wrap in useEffect
* optimization: avoid frequent recoil submission
* optimization: aggregate paths rather than updatedDialog to reduce time complexity
* chore: comments & var name
* lint
* add comments
* defense undefined skip-level 'actions'
* defense potential exceptions
* get sdk.schema content correctly
* fix lint
* fix folder name case problem
* Do not specify the luis endpoint key as a parameter to the runtime if no vlaue is present (#7240)
(leaving this paramter blank causes issues on windows)
* disable telemetry calls in the provision dialog while we investigate why telemetryclient is null (#7256)
Co-authored-by: Geoff Cox (Microsoft) <gcox@microsoft.com>
* prefer the botName field instead of the name field when managing connections (#7262)
* fix: Empty Webchat inspector text and Disabling items in PVA context (#7241)
* show floating notifications over eveything (#7269)
Co-authored-by: Soroush <sorgh@microsoft.com>
* Region for Microsoft Bot Channels Registration is now global (#7270)
Co-authored-by: Ben Brown <benbro@microsoft.com>
Co-authored-by: Soroush <hatpick@gmail.com>
* fix: adjust package manager feeds (#7243)
* Fix #7092: set default page size to 100 items
* Fixes #6854: merge community feeds into main feed, sort by downloads
* Fixes #7043: include any component tagged msbot-component
* improve error handling
* restore different checks for declarative only vs code driven components
* refactor to use includes instead of indexOf
Co-authored-by: Ben Yackley <61990921+beyackle@users.noreply.github.com>
* fix: remodel About page (#7191)
* remodel About page
* add SHA to version
* fixes from suggestion
* get info from Electron and use it for Release field
Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
Co-authored-by: Ben Brown <benbro@microsoft.com>
Co-authored-by: Geoff Cox (Microsoft) <gcox@microsoft.com>
Co-authored-by: Srinaath Ravichandran <srinaath27@gmail.com>
Co-authored-by: Soroush <hatpick@gmail.com>
Co-authored-by: Soroush <sorgh@microsoft.com>
Co-authored-by: Vamsi Modem <12182973+VamsiModem@users.noreply.github.com>
Co-authored-by: Ben Yackley <61990921+beyackle@users.noreply.github.com>
* fix mapping of schema files during migration
* fix lint
* fix default name of migrated project
* run schema merge as part of the migration
* do we need to migrate teh schema? or not?
* do not migrate schema
* - Adding field for runtime language
- Fixing field population for runtime type
* Passing runtime lang and type down to yeoman calls
* Fixing adaptive runtime name
* Hardcoding runtime version and fixing settings page generation on migrate
* Fixing check for 'inBotMigration' to be based on CreationStatusState > path substring
* Fix default naming
* revert preload.js
* Resolving PR comments and fixing errors from merge
* Change schema diagnostics severity to 'Error'
* Fetch @latest version from npm before migration
Co-authored-by: Dong Lei <donglei@microsoft.com>
Co-authored-by: leilzh <leilzh@microsoft.com>
Co-authored-by: zhixzhan <zhixzhan@microsoft.com>
Co-authored-by: zeye <zeye@microsoft.com>
Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
Co-authored-by: Geoff Cox (Microsoft) <gcox@microsoft.com>
Co-authored-by: Srinaath Ravichandran <srinaath27@gmail.com>
Co-authored-by: Soroush <hatpick@gmail.com>
Co-authored-by: Soroush <sorgh@microsoft.com>
Co-authored-by: Vamsi Modem <12182973+VamsiModem@users.noreply.github.com>
Co-authored-by: Ben Yackley <61990921+beyackle@users.noreply.github.com>
Co-authored-by: Patrick Volum <pavolum@outlook.com>
Co-authored-by: Chris Whitten <christopherwhitten@gmail.com>
* fix: data race writing on setting file (#7475)
* fix data race writing on setting file
* remove isSkill in skillConfiguration
* remove default allowedCallers value
Co-authored-by: TJ Durnford <tjdford@gmail.com>
Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
Co-authored-by: Ben Yackley <61990921+beyackle@users.noreply.github.com>
Co-authored-by: Soroush <hatpick@gmail.com>
* remove appsettings file from default gitignore (#7679)
* fix: restore line beneath page header (#7676)
* Update Page.tsx
* Update BotProjectSettings.tsx
* chore: Rebase main with 1.4.1 release (#7678)
* exclude items from the package manager list that do not have names or versions -- such as locally implemented custom actions (#7683)
* Add components field to migrated settings. Guard against missing field during component merge (#7674)
Co-authored-by: Dong Lei <donglei@microsoft.com>
Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
* fix: (Un) Installing a package now stops the currently running bot beforehand (#7689)
* Feed string, not int, to Switch per schema (#7707)
Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
* fix: generate manifest file when creating new publish target (#7666)
* generate manifest file when creating new profile
* test
Co-authored-by: Lu Han <32191031+luhan2017@users.noreply.github.com>
Co-authored-by: TJ Durnford <tjdford@gmail.com>
* fix: converting bot with custom actions (ui update) (#7672)
* Hides the PVA publish profile from the profle creation dropdown (#7725)
* fix: set func-related settings during build step (#7723)
* set func-related settings during build step
* slight refactor to reduce duplicated code
* add type
* add typings in runtime plugin definition
* set type of port to number
* fix types, remove _ on variables that are used
* feat: Add preparatory work before connecting remote skill (#7519)
* draft dialog
* ux css
* css
* jump to create profile & set microsoftAppId to publish target
* comments & lint
* refactor dialog wrapper
* fix publish types missing in provision dialog (#7697)
* test case
* refactor
* fix type define
* fix title and json parse
* fix app Id not sync when create new profile
* Adds AppID and Password sections
* test case fixed
* Adds AppID/Password
* Update copy
Co-authored-by: Soroush <hatpick@gmail.com>
Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
Co-authored-by: Ben Yackley <61990921+beyackle@users.noreply.github.com>
Co-authored-by: VanyLaw <wenyluo@microsoft.com>
Co-authored-by: Lu Han <32191031+luhan2017@users.noreply.github.com>
Co-authored-by: Chris Whitten <christopherwhitten@gmail.com>
* fix: Revert changes to adaptive card templates to support PVA (#7808)
* fix: Revert changes to adaptive card templates to support PVA
* requested changes
* fetch publish types for each project
* fix: Throttle restart conversation (#7824)
* Throttle restart
Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com>
* Remove await
Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com>
* Updated throttle time
Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com>
* Unit test update
Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com>
* Enable only on connected
Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com>
* removed if
Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com>
Co-authored-by: Srinaath Ravichandran <srravich@microsoft.com>
* chore: automated localization updates (#7759)
* Localized resource files from OneLocBuild
* fix typos and stray apostrophes
* fix apostrophes
* typo fix
* Update en-US.json
* fix more apostrophes
* revert reversions
Co-authored-by: Composer Localization <botframework-composer-eng@service.microsoft.com>
Co-authored-by: Ben Yackley <61990921+beyackle@users.noreply.github.com>
Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
* Deploy exception returns real error (#7837)
* fix: Fix missing data collection settings on server (#7814)
* fix: Fix missing data collection settings on server
* fix tests
* fix test again
* minor change
Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
* fix: add inner scrollbar to selection area (#7782)
* scroll
* css
* test
Co-authored-by: Lu Han <32191031+luhan2017@users.noreply.github.com>
Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
* Migration: adjust target blob transcript field names (#7848)
* fix: Always use intermediate lg template for text and speak modalities (#7842)
* allow click outside blocking modals (#7727)
Co-authored-by: Soroush <sorgh@microsoft.com>
Co-authored-by: TJ Durnford <tjdford@gmail.com>
* fix: Remove depth and transparentBorders from FieldProps, remove ObjectArrayField, and refactor OpenObjectField (#6633)
* Remove depth and transparentBorder
* Update OneOfField dropdown styles
* Remove ObjectArrayField
* fix tests
* Refactor OpenObjectField
* updated test
* minor
* fix test
* minor
Co-authored-by: Ben Yackley <61990921+beyackle@users.noreply.github.com>
* fix: Teaching bubble missing content (#7764)
* fix: Teaching bubble missing content
* Fix item ref
Co-authored-by: Ben Yackley <61990921+beyackle@users.noreply.github.com>
Co-authored-by: Soroush <hatpick@gmail.com>
* fix: Reset allowed callers cache when switching between project settings (#7874)
* fix: Reset allowed callers cache when switching between project settings
* comment
Co-authored-by: Soroush <hatpick@gmail.com>
* fix: breadcrumb & show code button collision (#7720)
* fix breadcrumb & show code button collision
* use flex
* update styles
* observe button width, auto layout ... breadcrumb
* ignore typescript ResizeObserver declarations missing
* fix type in test
* useResizeObserver
* fix mock
Co-authored-by: Srinaath Ravichandran <srinaath27@gmail.com>
Co-authored-by: Soroush <sorgh@microsoft.com>
Co-authored-by: Soroush <hatpick@gmail.com>
* Update home feed for Build 2021 (#7912)
* fix (#7440)
Co-authored-by: Soroush <sorgh@microsoft.com>
Co-authored-by: TJ Durnford <tjdford@gmail.com>
* fix: Custom function declaration (#7775)
* Custom function declaration
Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com>
* Typo in custom functions
Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com>
Co-authored-by: Srinaath Ravichandran <srravich@microsoft.com>
* add new caller when caller still have empty list, just focus on the empty one (#7767)
Co-authored-by: Lu Han <32191031+luhan2017@users.noreply.github.com>
* Resolve dns-packet to 1.3.4 to fix CVE-2021-23386 (#7942)
Co-authored-by: Soroush <hatpick@fmail.com>
* fix: invalid profile case (#7784)
* invalid profile case
* comments
* remove unused component
* refactor publish profile wrapper dialog
* toekn page jump logic err
Co-authored-by: Lu Han <32191031+luhan2017@users.noreply.github.com>
Co-authored-by: Soroush <hatpick@gmail.com>
* update recognizer
* update recognizer
* polish recognizer UI
* polish recognizer UI
* polish
* polish
* fix test
* fix test
* fix e2e test
* fix e2e test
* fix: Need to wait for zip deployment to be done processing (#7858)
* Handled 202
* Added error case for processing
* Improvements
Co-authored-by: Soroush <hatpick@gmail.com>
* Update readme screenshot (#7918)
Co-authored-by: Soroush <sorgh@microsoft.com>
* fix comments
* fix comments
* fix lint and ut
* fix lint and ut
* upgrade json-ptr (#7988)
* fix (#7979)
Co-authored-by: Soroush <hatpick@fmail.com>
Co-authored-by: Andy Brown <asbrown002@gmail.com>
* feat: Add expand to larger editor to LU Editor (#7976)
* pop expand lu editor
* fix labeling menu zIndex in poped out editor
* pr comments
Co-authored-by: Soroush <hatpick@fmail.com>
* fix: LUIS build fails with reason "undefined" with more than 10 phraselist entities (#7399)
* fix luis build error undeifined
* update to dev version
* update bf-lu version
Co-authored-by: Ben Yackley <61990921+beyackle@users.noreply.github.com>
Co-authored-by: Tien Suwandy <tiens@microsoft.com>
* chore(deps): bump ws from 7.4.4 to 7.4.6 in /extensions/localPublish (#7962)
Bumps [ws](https://github.com/websockets/ws) from 7.4.4 to 7.4.6.
- [Release notes](https://github.com/websockets/ws/releases)
- [Commits](https://github.com/websockets/ws/compare/7.4.4...7.4.6)
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* fix: Support vertical bar character ("|") in MicrosoftPassword (#7938)
* fix command with special char
* change quo mark
Co-authored-by: Soroush <hatpick@gmail.com>
Co-authored-by: Dong Lei <donglei@microsoft.com>
* ci: increase unit test timeout to 45 minutes (#7836)
Co-authored-by: Soroush <hatpick@gmail.com>
* fix: rewrite l10n:check to catch more errors and fix some l10n issues (#7857)
* Update l10nCheck.js
* revise l10n:check script and fix more l10n issues
* add Unicode flag to regex and fix more quotes
* update l10n strings
* apply fix from comment
* when add language luFile, update luIntent fileId (#8009)
* chore: Upgrade bf-lu to latest dev version (#7999)
* upgrade bf-lu
* update yarn lock
* chore: upgrade package ws@7.4.6 (#8010)
Co-authored-by: Soroush <hatpick@gmail.com>
* fix: trigger creation LUIS entity labelling (#8011)
* fix: trigger creation LUIS entity labelling
* move useState to parent component
Co-authored-by: Soroush <hatpick@gmail.com>
Co-authored-by: Dong Lei <donglei@microsoft.com>
* Add Orchestrator Logging (#7038)
* chore: bump ws from 7.4.4 to 7.4.6 and browserslist from 4.16.3 to 4.16.6. in /extensions/azurePublish (#8012)
* upgrade ws package
* upgrade browserslist
Co-authored-by: Dong Lei <donglei@microsoft.com>
Co-authored-by: Andy Brown <asbrown002@gmail.com>
* fix: add keys to tags and split license notice by lines (#7389)
* add keys and split license notice by lines
* Update About.tsx
* generate unique IDs for repeated P tags
Co-authored-by: TJ Durnford <tjdford@gmail.com>
Co-authored-by: Soroush <hatpick@gmail.com>
* feat: Added UX to link log items and WC activities (#8006)
* Added UX to link log items and WC activities
* Updated selected visual state of WC activities
* Added some tests
* Factored out WebChat hooks into separate headless component
Co-authored-by: Andy Brown <asbrown002@gmail.com>
* fix comments
* fix comments
* fix: remove old creation code (#8004)
* Removing old components
* marking unit tests for revision
* Removing old creation string
* Updating CreateBot component
* Moving creation files outside of v2 dir
* removing V2 from creation class names
* update migrate and createProjcet api endpoints
* Updating fetchtemplates endpoint and references
* misc v2 verbage and variable name clean up
* update createbot dispatchers
* update createNewBotFromTemplate
* minor fix in navigation in creation flow
* Updating creation flow unit test location
* updating lcoale file and removing unused variable
* Fix Unit test mocking
* Remove old unit test
* reverting en-us to resolve conflict with main
* Rename article to be less confusing (#8030)
Per @cwhitten
> The recommended OS versions are unchanged as of 1.3. We could modify this document to say something like 1.3 and above to be more correct.
* upgrade css-what and css-select (#8041)
* feat: Add dynamic schema for build forms in form dialogs (#8046)
* form dialog generators
* revert
* strings
* test
* chore: Update to the latest generator (#7664)
* Update to .template and new generate call.
* Update latest generator
Co-authored-by: Chris McConnell <chrimc>
* Remove debugger
* Make .template optional in $ref.
* Update to the npm version of bf-generate-library.
* #chore update to latest bf-generate-library
* Update to latest generator which fixes issues in
merge.
* Fix a bug in property grouping for forms.
Changed it so the first of:
* $designer.propertyGroups
* trigger.property
* action.expectedProperties
Is used for the property.
Enable multi-parenting and if not turned on
ensure the trigger does not disappear.
* strings
* yarn update
* lint issues
Co-authored-by: Soroush <sorgh@microsoft.com>
Co-authored-by: Chris McConnell <chrimc>
Co-authored-by: Chris McConnell <chrimc@microsoft.com>
Co-authored-by: Soroush <hatpick@fmail.com>
Co-authored-by: GeoffCoxMSFT <gcox@microsoft.com>
* fix: Monaco editor loader CDN js path (#7968)
* reset monaco loader CDN js path
* upgrade monaco-editor from 0.19.0 to 0.21.2
Co-authored-by: Andy Brown <asbrown002@gmail.com>
Co-authored-by: Soroush <hatpick@gmail.com>
* fix: incorrect expression validation for dialog (#7722)
* fix: incorrect expression validation for dialog
* fix conner case
* update the comments
* add some comment
* fix lint
Co-authored-by: Dong Lei <donglei@microsoft.com>
* feat: Add T&C accept for teams (#7381)
* Add T&C accept for teams
* remove mystery dep
* remove console
* Update formatMessage to use formatMessage.rich for complex content
Co-authored-by: Soroush <hatpick@gmail.com>
Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
* fix: resolving getting started teaching callout not rendering (#8005)
* -Adding getstarted teach bubble to app state
-creating a dispatcher for it
* setting state value to show teaching bubble as opposed to hash routing
* adding onclick state changing to manage state for teaching button dismisal
* Refining naming for distinct teaching bubbles
* polish design
* polish design
* update url
* default selected
* fix comment
* fix e2e test
Co-authored-by: pavolum <pavolum@outlook.com>
Co-authored-by: Soroush <hatpick@gmail.com>
Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
Co-authored-by: Srinaath Ravichandran <srinaath27@gmail.com>
Co-authored-by: Srinaath Ravichandran <srravich@microsoft.com>
Co-authored-by: Ben Brown <benbro@microsoft.com>
Co-authored-by: Shuai Wang <shuwan@microsoft.com>
Co-authored-by: Ben Yackley <61990921+beyackle@users.noreply.github.com>
Co-authored-by: Tony Anziano <tonyanziano5@gmail.com>
Co-authored-by: Andy Brown <asbrown002@gmail.com>
Co-authored-by: Soroush <sorgh@microsoft.com>
Co-authored-by: Zhixiang Zhan <zhixzhan@microsoft.com>
Co-authored-by: Geoff Cox (Microsoft) <gcox@microsoft.com>
Co-authored-by: Lu Han <32191031+luhan2017@users.noreply.github.com>
Co-authored-by: Qi Kang <kangqidev@gmail.com>
Co-authored-by: Long Jun <alanlong9278@126.com>
Co-authored-by: Long Alan <julong@microsoft.com>
Co-authored-by: taicchoumsft <61705609+taicchoumsft@users.noreply.github…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Un-hide Custom Recognizer in dropdown for non-PVA bots.
Task Item
fixes #7568
Screenshots