fix: [#9151] LG for 'choices' field in multi choice input results in Warning #9321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ceciliaavila
requested review from
cwhitten,
boydc2014,
a-b-r-o-w-n,
beyackle,
srinaath,
tonyanziano,
benbrown,
tdurnford,
natalgar and
VamsiModem
as code owners
ceciliaavila
force-pushed
the
southworks/fix/lg-expression-validation
branch
from
886f041
to
6ede2ad
Compare
OEvgeny
previously approved these changes
Sep 14, 2022
ceciliaavila
force-pushed
the
southworks/fix/lg-expression-validation
branch
from
6ede2ad
to
c448cc1
Compare
|
Should be good to go after related package lock hash updates |
OEvgeny
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the validation of LG expressions to avoid showing a warning when LG expressions are used.
A
trimExpressionfunction was added to remove the${}characters of the expression allowing it to be correctly parsed.It also adds a unit test to cover this new function.
Task Item
Fixes #9151
Screenshots
These images show the warning displayed before and the LG expression being properly validated after.
BEFORE
AFTER