Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optionally run ngrok on startup #1273

Merged
merged 5 commits into from
Jan 31, 2019
Merged

optionally run ngrok on startup #1273

merged 5 commits into from
Jan 31, 2019

Conversation

justinwilaby
Copy link
Contributor

@justinwilaby justinwilaby commented Jan 29, 2019

fixes #1272
✓Added option to run ngrok on startup

image

✓Added menu item to copy the ngrok url to the clipboard
image

@coveralls
Copy link

coveralls commented Jan 29, 2019

Pull Request Test Coverage Report for Build 1958

  • 61 of 66 (92.42%) changed or added relevant lines in 10 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.6%) to 50.275%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/app/client/src/ui/editor/index.ts 0 1 0.0%
packages/app/client/src/ui/editor/editor.tsx 0 2 0.0%
packages/app/main/src/appMenuBuilder.ts 2 4 50.0%
Totals Coverage Status
Change from base Build 1954: 0.6%
Covered Lines: 4506
Relevant Lines: 8351

💛 - Coveralls

@cwhitten
Copy link
Member

@mewa1024 do you have a recommendation on the copy used in the Menu item?

Copy link
Contributor

@tonyanziano tonyanziano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work in the <AppSettingsEditor>! Much cleaner now.

Looks good to me, I'll wait for Melanie to respond to Chris' question before approving.

Copy link
Contributor

@tonyanziano tonyanziano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit: 🚢

@justinwilaby justinwilaby merged commit 860c708 into master Jan 31, 2019
@justinwilaby justinwilaby deleted the jwilaby/#1272-ngrok branch January 31, 2019 18:06
@mewa1024 mewa1024 removed their assignment Jan 31, 2019
@mewa1024
Copy link

Sorry for the late reply. Justin and I talked offline about the copy. (Unassigning myself.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Optionally launch ngrok on startup of the Emulator
5 participants