Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

French localization and suggestedActionBorderRadius style option #1327

Merged
merged 5 commits into from
Nov 30, 2018

Conversation

tao1
Copy link
Contributor

@tao1 tao1 commented Nov 8, 2018

No description provided.

@msftclas
Copy link

msftclas commented Nov 8, 2018

CLA assistant check
All CLA requirements met.

@coveralls
Copy link

coveralls commented Nov 8, 2018

Pull Request Test Coverage Report for Build 474

  • 0 of 19 (0.0%) changed or added relevant lines in 1 file are covered.
  • 81 unchanged lines in 18 files lost coverage.
  • Overall coverage decreased (-6.9%) to 39.581%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/component/src/Localization/fr-FR.js 0 19 0.0%
Files with Coverage Reduction New Missed Lines %
packages/core/src/actions/incomingActivity.js 1 50.0%
packages/core/src/sagas/effects/observeOnce.js 1 50.0%
packages/component/src/Attachment/ImageAttachment.js 1 0.0%
packages/component/src/Middleware/Activity/createCoreMiddleware.js 1 62.5%
packages/component/src/Localization/Localize.js 1 34.94%
packages/component/src/Utils/textFormatToContentType.js 1 42.86%
packages/component/src/Attachment/ImageContent.js 2 0.0%
packages/bundle/src/renderMarkdown.js 2 12.5%
packages/component/src/Activity/Timestamp.js 2 0.0%
packages/component/src/Activity/CarouselLayout.js 4 14.29%
Totals Coverage Status
Change from base Build 468: -6.9%
Covered Lines: 630
Relevant Lines: 1385

💛 - Coveralls

@compulim
Copy link
Contributor

compulim commented Nov 8, 2018

Thanks. Love the border radius one, we missed that.

Comment inside. Please ignore coveralls for now, we are not guarding on our test numbers yet.

Thanks for opening the branch for editing. We will help you fix those comments if we have bandwidth.

Corina and others added 2 commits November 29, 2018 21:36
My original fix didn't go through; sorry I'm new to updating PR's =_=
My original fix didn't go through; sorry I'm new to updating PR's =_=
@corinagum corinagum merged commit 33286bd into microsoft:master Nov 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants