Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Dutch localization #1812

Merged
merged 3 commits into from
Mar 15, 2019
Merged

Conversation

iMicknl
Copy link
Member

@iMicknl iMicknl commented Mar 14, 2019

No description provided.

@iMicknl iMicknl changed the title Updated Danish localization Updated Dutch localization Mar 14, 2019
@coveralls
Copy link

coveralls commented Mar 14, 2019

Coverage Status

Coverage decreased (-1.4%) to 52.786% when pulling cdfc2f0 on iMicknl:update_dutch_locale into 4a1a9a5 on Microsoft:master.

@corinagum
Copy link
Contributor

Thanks for the contribution! Please add your username to LOCALIZATION.md and resolve merge conflicts :)

@iMicknl
Copy link
Member Author

iMicknl commented Mar 14, 2019

@corinagum I will fix the merge conflicts. My username is already in the LOCALIZATION.md from the V3 version.

@compulim should these files Localisation files be excluded from coveralls?

# Conflicts:
#	CHANGELOG.md
@compulim
Copy link
Contributor

compulim commented Mar 14, 2019

@iMicknl I won't look too much into coveralls right now.

Design of tests:

  • 90%+ should be visual regression test
    • To lower effort to test stuff
    • To lower effort to verify how a feature work
    • To prevent test bugs (e.g. prevent writing assertions that didn't look at full picture)
  • Visual regression test is not great for small piece of isolated code, like localization
    • At a latter push of code coverage, we should add unit tests specifically for localization code, so it won't dip our code coverage a lot

@compulim
Copy link
Contributor

compulim commented Mar 14, 2019

@corinagum could you do a quick check against machine translator?
@iMicknl we check against machine translator just to prevent accidentally merging in profanity words 😉

Copy link
Contributor

@corinagum corinagum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Machine translation looks good to me. :) @iMicknl could you answer one question above? Then this is ready to merge.

packages/component/src/Localization/nl-NL.js Show resolved Hide resolved
@corinagum corinagum merged commit cf15644 into microsoft:master Mar 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants