Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sample: Single-sign on for enterprise app #2002

Merged
merged 120 commits into from
Jun 19, 2019
Merged

Sample: Single-sign on for enterprise app #2002

merged 120 commits into from
Jun 19, 2019

Conversation

compulim
Copy link
Contributor

@compulim compulim commented May 19, 2019 •
edited
Loading

Fixes #1564.

Changelog Entry

Description

Added a sample for "Single sign-on for enterprise apps using OAuth".

Specific Changes

  • Added /samples/19.a.single-sign-on-for-enterprise-apps

@compulim compulim changed the title Sample: Single-sign on sample for enterprise app Sample: Single-sign on for enterprise app May 19, 2019
corinagum
corinagum suggested changes May 20, 2019
View reviewed changes
Copy link
Contributor

@corinagum corinagum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think at the very least all of the .js files should have a short comment at the top explaining what it's doing, since this is a sample.
I'm going to try implementing this now and let you know if I have more feedback

samples/19.a.single-sign-on-for-enterprise-apps/README.md Outdated Show resolved Hide resolved
samples/19.a.single-sign-on-for-enterprise-apps/README.md Outdated Show resolved Hide resolved
samples/19.a.single-sign-on-for-enterprise-apps/README.md Outdated Show resolved Hide resolved
samples/19.a.single-sign-on-for-enterprise-apps/README.md Outdated Show resolved Hide resolved
samples/19.a.single-sign-on-for-enterprise-apps/README.md Outdated Show resolved Hide resolved
samples/19.a.single-sign-on-for-enterprise-apps/app/README.md Outdated Show resolved Hide resolved
samples/19.a.single-sign-on-for-enterprise-apps/app/README.md Outdated Show resolved Hide resolved
samples/19.a.single-sign-on-for-enterprise-apps/app/public/index.html Show resolved Hide resolved
samples/19.a.single-sign-on-for-enterprise-apps/app/src/microsoftGraphProfile/Context.js Show resolved Hide resolved
...ingle-sign-on-for-enterprise-apps/app/src/microsoftGraphProfile/fetchProfilePhotoAsBase64.js Outdated Show resolved Hide resolved
@corinagum
Copy link
Contributor

can you also run npm audit fix on this sample? thank you

@compulim
Copy link
Contributor Author

compulim commented May 23, 2019 •
edited
Loading

  1. Highlight security concern of DIRECT_LINE_SECRET
  2. Runtime check to see all critical environment variables were set
  3. FAQ section to show the template of two .env files
  4. Use a CI/CD pipeline to build/host the demo, so we can easily update the demo without manually deploying to the site
  5. Move the access token from conversation state to channelData

@compulim compulim marked this pull request as ready for review June 18, 2019 19:20
corinagum
corinagum approved these changes Jun 19, 2019
View reviewed changes
Copy link
Contributor

@corinagum corinagum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very thorough! LGTM :)

samples/19.a.single-sign-on-for-enterprise-apps/app/public/index.html Outdated Show resolved Hide resolved
samples/19.a.single-sign-on-for-enterprise-apps/app/public/index.html Outdated Show resolved Hide resolved
samples/19.a.single-sign-on-for-enterprise-apps/app/public/index.html Outdated Show resolved Hide resolved
samples/19.a.single-sign-on-for-enterprise-apps/app/src/gitHubProfile/Composer.js Outdated Show resolved Hide resolved
samples/19.a.single-sign-on-for-enterprise-apps/app/src/gitHubProfile/Composer.js Outdated Show resolved Hide resolved
samples/19.a.single-sign-on-for-enterprise-apps/app/src/ui/MicrosoftGraphProfileMenu.js Outdated Show resolved Hide resolved
samples/19.a.single-sign-on-for-enterprise-apps/bot/src/createBot.js Outdated Show resolved Hide resolved
samples/19.a.single-sign-on-for-enterprise-apps/bot/src/createBot.js Outdated Show resolved Hide resolved
samples/19.a.single-sign-on-for-enterprise-apps/rest-api/src/index.js Outdated Show resolved Hide resolved
samples/19.a.single-sign-on-for-enterprise-apps/rest-api/src/utils/generateOAuthState.js Outdated Show resolved Hide resolved
compulim and others added 27 commits June 19, 2019 11:02
@compulim
Update URL
d20b73d
@compulim
Add link to badge
8cdf96e
@compulim
Piggyback access token on channel data
6cb5c81
@compulim
Update README.md
bc9ef99
@compulim
Refinement
1a89b36
@compulim
Patch vulnerability
fbc66ab
@compulim
Add mixed conversations
07a8aa4
@compulim @corinagum
Update samples/19.a.single-sign-on-for-enterprise-apps/app/public/ind…
6d0846c 
…ex.html

Co-Authored-By: Corina <14900841+corinagum@users.noreply.github.com>
@compulim @corinagum
Update samples/19.a.single-sign-on-for-enterprise-apps/app/public/ind…
dc5384c 
…ex.html

Co-Authored-By: Corina <14900841+corinagum@users.noreply.github.com>
@compulim @corinagum
Update samples/19.a.single-sign-on-for-enterprise-apps/app/src/gitHub…
5d0efee 
…Profile/Composer.js

Co-Authored-By: Corina <14900841+corinagum@users.noreply.github.com>
@compulim @corinagum
Update samples/19.a.single-sign-on-for-enterprise-apps/app/src/ui/Mic…
6b47349 
…rosoftGraphProfileMenu.js

Co-Authored-By: Corina <14900841+corinagum@users.noreply.github.com>
@compulim @corinagum
Update samples/19.a.single-sign-on-for-enterprise-apps/app/src/gitHub…
56615e3 
…Profile/Composer.js

Co-Authored-By: Corina <14900841+corinagum@users.noreply.github.com>
@compulim @corinagum
Update samples/19.a.single-sign-on-for-enterprise-apps/app/public/ind…
3d31d22 
…ex.html

Co-Authored-By: Corina <14900841+corinagum@users.noreply.github.com>
@compulim @corinagum
Update samples/19.a.single-sign-on-for-enterprise-apps/app/src/micros…
dd397f4 
…oftGraphProfile/Composer.js

Co-Authored-By: Corina <14900841+corinagum@users.noreply.github.com>
@compulim @corinagum
Update samples/19.a.single-sign-on-for-enterprise-apps/bot/src/create…
0c6e032 
…Bot.js

Co-Authored-By: Corina <14900841+corinagum@users.noreply.github.com>
@compulim @corinagum
Update samples/19.a.single-sign-on-for-enterprise-apps/bot/src/create…
0060087 
…Bot.js

Co-Authored-By: Corina <14900841+corinagum@users.noreply.github.com>
@compulim @corinagum
Update samples/19.a.single-sign-on-for-enterprise-apps/rest-api/src/u…
7d429a3 
…tils/generateOAuthState.js

Co-Authored-By: Corina <14900841+corinagum@users.noreply.github.com>
@compulim @corinagum
Update samples/19.a.single-sign-on-for-enterprise-apps/rest-api/src/i…
c142492 
…ndex.js

Co-Authored-By: Corina <14900841+corinagum@users.noreply.github.com>
@compulim @corinagum
Update samples/19.a.single-sign-on-for-enterprise-apps/app/src/micros…
523b0e4 
…oftGraphProfile/fetchProfilePhotoAsBase64.js

Co-Authored-By: Corina <14900841+corinagum@users.noreply.github.com>
@compulim @corinagum
Update samples/19.a.single-sign-on-for-enterprise-apps/app/src/oauth/…
a9f87ee 
…Composer.js

Co-Authored-By: Corina <14900841+corinagum@users.noreply.github.com>
@compulim @corinagum
Update samples/19.a.single-sign-on-for-enterprise-apps/app/src/oauth/…
7aef3f4 
…Composer.js

Co-Authored-By: Corina <14900841+corinagum@users.noreply.github.com>
@compulim @corinagum
Update samples/19.a.single-sign-on-for-enterprise-apps/app/src/oauth/…
f384818 
…Composer.js

Co-Authored-By: Corina <14900841+corinagum@users.noreply.github.com>
@compulim @corinagum
Update samples/19.a.single-sign-on-for-enterprise-apps/app/src/ui/Git…
1878a0d 
…HubProfileMenu.js

Co-Authored-By: Corina <14900841+corinagum@users.noreply.github.com>
@compulim @corinagum
Update samples/19.a.single-sign-on-for-enterprise-apps/app/src/ui/Git…
9d18811 
…HubProfileMenu.js

Co-Authored-By: Corina <14900841+corinagum@users.noreply.github.com>
@compulim @corinagum
Update samples/19.a.single-sign-on-for-enterprise-apps/app/src/ui/Git…
a75492a 
…HubProfileMenu.js

Co-Authored-By: Corina <14900841+corinagum@users.noreply.github.com>
@compulim @corinagum
Update samples/19.a.single-sign-on-for-enterprise-apps/app/src/ui/Git…
bbb1071 
…HubProfileMenu.js

Co-Authored-By: Corina <14900841+corinagum@users.noreply.github.com>
@compulim @corinagum
Update samples/19.a.single-sign-on-for-enterprise-apps/app/src/ui/Git…
b3647b6 
…HubProfileMenu.js

Co-Authored-By: Corina <14900841+corinagum@users.noreply.github.com>
@compulim compulim merged commit 454a9c2 into microsoft:master Jun 19, 2019
@compulim compulim deleted the sample-sso branch June 19, 2019 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corinagum corinagum corinagum approved these changes

@a-b-r-o-w-n a-b-r-o-w-n Awaiting requested review from a-b-r-o-w-n a-b-r-o-w-n is a code owner

@cwhitten cwhitten Awaiting requested review from cwhitten cwhitten is a code owner

@justinwilaby justinwilaby Awaiting requested review from justinwilaby

@tonyanziano tonyanziano Awaiting requested review from tonyanziano

Assignees

@compulim compulim

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sample: Chat bot single sign-on
2 participants
@compulim @corinagum