Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resharper annotations should point to the real ones (or just remove them all) #2

Closed
smera opened this issue Oct 31, 2018 · 0 comments
Closed

Resharper annotations should point to the real ones (or just remove them all) #2

smera opened this issue Oct 31, 2018 · 0 comments

Comments

@smera
Copy link
Member

smera commented Oct 31, 2018

We have a “ResharperAnnotations” folder under Utilities where we mimicked many JetBrains annotations (mirroring exact namespaces as well). I guess this was so we could use all the usual annotations without referring the real JetBrains package. (https://github.com/Microsoft/BuildXL/blob/master/src/Utilities/Utilities/ResharperAnnotations/ResharperAnnotations.cs)

There are many consumers of these annotations. We should use the real ones or remove all.
@smera smera changed the title Resharper annotations should point to the real ones or removed Resharper annotations should point to the real ones or just remove all Oct 31, 2018
@smera smera changed the title Resharper annotations should point to the real ones or just remove all Resharper annotations should point to the real ones (or just remove them all) Oct 31, 2018
Kr1sso added a commit to Kr1sso/BuildXL that referenced this issue Oct 28, 2019
@Kr1sso
Addressed PR comments microsoft#2
0706e99
Kr1sso added a commit that referenced this issue Oct 29, 2019
@Kr1sso
[macOS] Low memory resource throttling improvements (#1106)
98be9b2 
* Adjust some resource throttling mechanisms to better model low memory pressure situations

* Address PR comments

* Fixed a typo

* Addressed PR comments #2

* Address PR comments #3
sluongng pushed a commit to sluongng/BuildXL that referenced this issue Apr 27, 2023
@rongjiecomputer
Launch process with BuildXL Sandbox API (microsoft#2)
b6d7fb7 
Note: no file access blocking yet.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@AndyGerlicher @smera