Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add end-to-end test of multi-bucket indexing #5071

Open
eddyashton opened this issue Feb 28, 2023 · 1 comment
Open

Add end-to-end test of multi-bucket indexing #5071

eddyashton opened this issue Feb 28, 2023 · 1 comment

Comments

@eddyashton
Copy link
Member

While debugging something unrelated, I think I've spotted a bad branch in the sample logging app:

https://github.com/microsoft/CCF/blob/main/samples/apps/logging/logging.cpp#L1463-L1475

I think we should always be returning a next_link here, but that our current end-to-end tests don't hit the bug (full-history audit flows terminating early!) because they don't create sufficiently long ledgers. I noticed this while creating a novelly-long ledger to test long-lived forwarding. To create an end-to-end test for both of these, I think we finally need an app-specific configuration option, and a new e2e instance which starts a logging service with significantly reduced limits (smaller indexing buckets, quicker node-to-node key rotation) to test these edge cases.

@eddyashton eddyashton added the bug label Feb 28, 2023
@achamayou
Copy link
Member

Believed to be fixed, but needs a test.

@achamayou achamayou added this to the 4.x milestone May 15, 2023
@achamayou achamayou removed this from the 4.x milestone Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants