Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardise governance API - remove use of member certs #5084

Closed
eddyashton opened this issue Mar 7, 2023 · 1 comment
Closed

Standardise governance API - remove use of member certs #5084

eddyashton opened this issue Mar 7, 2023 · 1 comment

Comments

@eddyashton
Copy link
Member

We primarily think of members as being identified purely by their key, which is used for signing. Some endpoints still permit TLS auth with the member cert as client identity (POST /gov/recovery_share, GET /gov/recovery_share, and POST /gov/ack/update_state_digest).

To support these, our member cert authentication does not check expiry times (#5083), so it will permit expired member certs.

#5080 attempted to simplify this, removing the old endpoints and insisting on COSE signing. This was too aggressive a change to the API, and had too large a blast radius for an urgent CI fix, so has been reverted. We should revisit this, with deprecation of the old endpoints (redirecting to the new), and the goal of eventually dropping member cert-based auth entirely.

@achamayou
Copy link
Member

This was resolved as a side effect of #5137, with GETs no longer reliant on cert auth and using URL parameters only. Further changes are coming as part of the implementation of #5129, but this is done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants