Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make docs links locale agnostic #67

Merged
merged 1 commit into from
Jan 26, 2021
Merged

Make docs links locale agnostic #67

merged 1 commit into from
Jan 26, 2021

Conversation

RussKie
Copy link
Member

@RussKie RussKie commented Jan 25, 2021

I know we have a docs guideline to not use locale-specific hyperlinks, but I can't find it. @gewarren would have a link to that guideline somewhere handy?

@gewarren
Copy link

@RussKie Here you go: https://review.docs.microsoft.com/en-us/help/contribute/links-how-to?branch=master#locale-codes-in-external-links.

AArnott
AArnott approved these changes Jan 26, 2021
View reviewed changes
Copy link
Member

@AArnott AArnott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@AArnott AArnott merged commit dd1d9e6 into microsoft:main Jan 26, 2021
@RussKie RussKie deleted the make_docs_locale_agnostic branch January 26, 2021 04:34
@RussKie
Copy link
Member Author

RussKie commented Jan 26, 2021

Thank you @gewarren and @AArnott

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AArnott AArnott AArnott approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RussKie @gewarren @AArnott