add net35 fix #890
Closed
add net35 fix #890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@microsoft-github-policy-service agree |
|
This could work. Thank you for offering the code change. Looking more closely at this, it appears the break is because overloads aren't created that net35 is fully compatible with, and it's not yet clear to me why these overloads aren't being created. If we can fix that, we won't need to duplicate the definition of this method by hand. Also, just as a nit, the indentation isn't consistent in the two regions. But we needn't fix this yet while I look to see if there's a better fix. |
|
Thank you again for your contribution. I found a more general fix that addresses the original bug, and much more. Check out #892. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.